feat: add closeOnIframeFocus prop to Popover #28881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
force-pushed
the
feat/popover-focus-iframe
branch
from
5ca8987 to
5e90f62
Compare
layershifter
changed the title
layershifter
force-pushed
the
feat/popover-focus-iframe
branch
from
5e90f62 to
0c14c66
Compare
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | mount | 77 | 81 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 77 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 621 | 638 | 5000 | |
| Button | mount | 309 | 320 | 5000 | |
| Field | mount | 1130 | 1105 | 5000 | |
| FluentProvider | mount | 692 | 686 | 5000 | |
| FluentProviderWithTheme | mount | 77 | 81 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender | 66 | 70 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 77 | 10 | Possible regression |
| InfoButton | mount | 8 | 15 | 5000 | |
| MakeStyles | mount | 842 | 861 | 50000 | |
| Persona | mount | 1700 | 1672 | 5000 | |
| SpinButton | mount | 1363 | 1378 | 5000 |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| TreeWith60ListItems.default | 93 | 83 | 1.12:1 |
| IconMinimalPerf.default | 419 | 386 | 1.09:1 |
| GridMinimalPerf.default | 189 | 179 | 1.06:1 |
| VideoMinimalPerf.default | 450 | 426 | 1.06:1 |
| HeaderMinimalPerf.default | 212 | 201 | 1.05:1 |
| ToolbarMinimalPerf.default | 544 | 516 | 1.05:1 |
| CarouselMinimalPerf.default | 264 | 253 | 1.04:1 |
| DropdownManyItemsPerf.default | 410 | 396 | 1.04:1 |
| FormMinimalPerf.default | 236 | 228 | 1.04:1 |
| ReactionMinimalPerf.default | 209 | 201 | 1.04:1 |
| SplitButtonMinimalPerf.default | 2295 | 2216 | 1.04:1 |
| AccordionMinimalPerf.default | 75 | 73 | 1.03:1 |
| DatepickerMinimalPerf.default | 3566 | 3479 | 1.03:1 |
| EmbedMinimalPerf.default | 1897 | 1843 | 1.03:1 |
| InputMinimalPerf.default | 548 | 530 | 1.03:1 |
| ItemLayoutMinimalPerf.default | 707 | 686 | 1.03:1 |
| LayoutMinimalPerf.default | 204 | 199 | 1.03:1 |
| ListMinimalPerf.default | 307 | 299 | 1.03:1 |
| MenuMinimalPerf.default | 497 | 481 | 1.03:1 |
| RefMinimalPerf.default | 113 | 110 | 1.03:1 |
| TextMinimalPerf.default | 190 | 185 | 1.03:1 |
| TooltipMinimalPerf.default | 1291 | 1257 | 1.03:1 |
| AlertMinimalPerf.default | 153 | 150 | 1.02:1 |
| BoxMinimalPerf.default | 192 | 189 | 1.02:1 |
| CardMinimalPerf.default | 305 | 300 | 1.02:1 |
| LabelMinimalPerf.default | 222 | 218 | 1.02:1 |
| ProviderMergeThemesPerf.default | 667 | 657 | 1.02:1 |
| SliderMinimalPerf.default | 762 | 748 | 1.02:1 |
| AttachmentMinimalPerf.default | 79 | 78 | 1.01:1 |
| AvatarMinimalPerf.default | 107 | 106 | 1.01:1 |
| ButtonMinimalPerf.default | 89 | 88 | 1.01:1 |
| ChatDuplicateMessagesPerf.default | 152 | 150 | 1.01:1 |
| ChatMinimalPerf.default | 433 | 430 | 1.01:1 |
| ChatWithPopoverPerf.default | 195 | 193 | 1.01:1 |
| MenuButtonMinimalPerf.default | 963 | 956 | 1.01:1 |
| AttachmentSlotsPerf.default | 632 | 631 | 1:1 |
| ButtonOverridesMissPerf.default | 656 | 658 | 1:1 |
| CheckboxMinimalPerf.default | 1128 | 1127 | 1:1 |
| FlexMinimalPerf.default | 149 | 149 | 1:1 |
| HeaderSlotsPerf.default | 452 | 452 | 1:1 |
| ListWith60ListItems.default | 366 | 367 | 1:1 |
| LoaderMinimalPerf.default | 186 | 186 | 1:1 |
| RosterPerf.default | 1528 | 1529 | 1:1 |
| PopupMinimalPerf.default | 345 | 346 | 1:1 |
| PortalMinimalPerf.default | 82 | 82 | 1:1 |
| ProviderMinimalPerf.default | 203 | 202 | 1:1 |
| RadioGroupMinimalPerf.default | 258 | 259 | 1:1 |
| StatusMinimalPerf.default | 394 | 394 | 1:1 |
| CustomToolbarPrototype.default | 1465 | 1459 | 1:1 |
| TreeMinimalPerf.default | 465 | 465 | 1:1 |
| DropdownMinimalPerf.default | 1405 | 1418 | 0.99:1 |
| ListNestedPerf.default | 317 | 319 | 0.99:1 |
| TableMinimalPerf.default | 225 | 228 | 0.99:1 |
| AnimationMinimalPerf.default | 296 | 302 | 0.98:1 |
| ImageMinimalPerf.default | 220 | 225 | 0.98:1 |
| TableManyItemsPerf.default | 1100 | 1117 | 0.98:1 |
| ButtonSlotsPerf.default | 303 | 311 | 0.97:1 |
| ListCommonPerf.default | 382 | 392 | 0.97:1 |
| DialogMinimalPerf.default | 446 | 467 | 0.96:1 |
| DividerMinimalPerf.default | 196 | 205 | 0.96:1 |
| SegmentMinimalPerf.default | 191 | 200 | 0.96:1 |
| SkeletonMinimalPerf.default | 189 | 197 | 0.96:1 |
| TextAreaMinimalPerf.default | 276 | 287 | 0.96:1 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a3cf263:
|
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: f194f87b08e489e9c5d9f714e1294bb4d82b9af7 (build) |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
packages/react-components/react-utilities/src/hooks/useOnClickOutside.cy.tsx
Show resolved
Hide resolved
miroslavstastny
approved these changes
Aug 20, 2023
ling1726
reviewed
Aug 22, 2023
packages/react-components/react-popover/src/components/Popover/Popover.types.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Aug 22, 2023
packages/react-components/react-popover/src/components/Popover/Popover.types.ts
Show resolved
Hide resolved
layershifter
force-pushed
the
feat/popover-focus-iframe
branch
from
0c14c66 to
a3cf263
Compare
bsunderhus
pushed a commit
to bsunderhus/fluentui
that referenced
this pull request
Aug 28, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 28, 2023
* master: (23 commits) feat: add closeOnIframeFocus prop to Popover (microsoft#28881) chore: updates .devcontainer to follow new format (microsoft#28990) Line Chart and Area Chart - Component tests (microsoft#28235) applying package updates 28576 small button is using 3px border radius (microsoft#28589) In PeoplePicker, we can now use arrow keys to move cursor around microsoft#28655 (microsoft#28975) chore: Migrate bot config to yml (microsoft#28981) fix(react-card): CardHeader grid layout ignoring line-height of content (microsoft#28968) fix(react-tags-preview): tag with secondary text has no top border under windows high contrast (microsoft#28963) applying package updates feat(Stack): Add deprecated flag to render null when receiving a falsy value (microsoft#28978) feat(react-infobutton): Add inline prop to InfoButton and make it inline by default (microsoft#28605) fix(Dialog): Add displayName for dialog footer and content (microsoft#28939) Revert "Keytips: Align keytipData with visible instance for dupes" (microsoft#28977) Vertical stacked bar chart - Component tests (microsoft#28594) docs: update drawer spec to be inline with changes to component (microsoft#28934) Table/DataGrid: fix visuals for overflow (microsoft#28940) Focus indicator bug in bar charts (microsoft#28414) Pie chart focus spacing (microsoft#28504) applying package updates ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 28, 2023
* master: (24 commits) feat(react-motion): add useMotion hook (microsoft#28699) feat: add closeOnIframeFocus prop to Popover (microsoft#28881) chore: updates .devcontainer to follow new format (microsoft#28990) Line Chart and Area Chart - Component tests (microsoft#28235) applying package updates 28576 small button is using 3px border radius (microsoft#28589) In PeoplePicker, we can now use arrow keys to move cursor around microsoft#28655 (microsoft#28975) chore: Migrate bot config to yml (microsoft#28981) fix(react-card): CardHeader grid layout ignoring line-height of content (microsoft#28968) fix(react-tags-preview): tag with secondary text has no top border under windows high contrast (microsoft#28963) applying package updates feat(Stack): Add deprecated flag to render null when receiving a falsy value (microsoft#28978) feat(react-infobutton): Add inline prop to InfoButton and make it inline by default (microsoft#28605) fix(Dialog): Add displayName for dialog footer and content (microsoft#28939) Revert "Keytips: Align keytipData with visible instance for dupes" (microsoft#28977) Vertical stacked bar chart - Component tests (microsoft#28594) docs: update drawer spec to be inline with changes to component (microsoft#28934) Table/DataGrid: fix visuals for overflow (microsoft#28940) Focus indicator bug in bar charts (microsoft#28414) Pie chart focus spacing (microsoft#28504) ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 28, 2023
* master: (24 commits) feat(react-motion): add useMotion hook (microsoft#28699) feat: add closeOnIframeFocus prop to Popover (microsoft#28881) chore: updates .devcontainer to follow new format (microsoft#28990) Line Chart and Area Chart - Component tests (microsoft#28235) applying package updates 28576 small button is using 3px border radius (microsoft#28589) In PeoplePicker, we can now use arrow keys to move cursor around microsoft#28655 (microsoft#28975) chore: Migrate bot config to yml (microsoft#28981) fix(react-card): CardHeader grid layout ignoring line-height of content (microsoft#28968) fix(react-tags-preview): tag with secondary text has no top border under windows high contrast (microsoft#28963) applying package updates feat(Stack): Add deprecated flag to render null when receiving a falsy value (microsoft#28978) feat(react-infobutton): Add inline prop to InfoButton and make it inline by default (microsoft#28605) fix(Dialog): Add displayName for dialog footer and content (microsoft#28939) Revert "Keytips: Align keytipData with visible instance for dupes" (microsoft#28977) Vertical stacked bar chart - Component tests (microsoft#28594) docs: update drawer spec to be inline with changes to component (microsoft#28934) Table/DataGrid: fix visuals for overflow (microsoft#28940) Focus indicator bug in bar charts (microsoft#28414) Pie chart focus spacing (microsoft#28504) ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 28, 2023
* master: (26 commits) chore: Make triage bot add needs triage label to new issues (microsoft#28994) fix(react-tags-preview): use regular icon for dismiss (microsoft#28958) feat(react-motion): add useMotion hook (microsoft#28699) feat: add closeOnIframeFocus prop to Popover (microsoft#28881) chore: updates .devcontainer to follow new format (microsoft#28990) Line Chart and Area Chart - Component tests (microsoft#28235) applying package updates 28576 small button is using 3px border radius (microsoft#28589) In PeoplePicker, we can now use arrow keys to move cursor around microsoft#28655 (microsoft#28975) chore: Migrate bot config to yml (microsoft#28981) fix(react-card): CardHeader grid layout ignoring line-height of content (microsoft#28968) fix(react-tags-preview): tag with secondary text has no top border under windows high contrast (microsoft#28963) applying package updates feat(Stack): Add deprecated flag to render null when receiving a falsy value (microsoft#28978) feat(react-infobutton): Add inline prop to InfoButton and make it inline by default (microsoft#28605) fix(Dialog): Add displayName for dialog footer and content (microsoft#28939) Revert "Keytips: Align keytipData with visible instance for dupes" (microsoft#28977) Vertical stacked bar chart - Component tests (microsoft#28594) docs: update drawer spec to be inline with changes to component (microsoft#28934) Table/DataGrid: fix visuals for overflow (microsoft#28940) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
closeOnIframeFocus(defaults totrue) toPopoverthat allows to keep popovers opened if an iframe outside a popover is focused.disabledFocusOnIframeto options ofuseOnClickOutside()hook and covers this functionality with Cypress tests.Related Issue(s)
Fixes #28556