chore(react-tree): delegate focus outline to layout components #29293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d2e6839:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 11 | 10 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 669 | 636 | 5000 | |
| Button | mount | 325 | 319 | 5000 | |
| Field | mount | 1145 | 1167 | 5000 | |
| FluentProvider | mount | 706 | 707 | 5000 | |
| FluentProviderWithTheme | mount | 77 | 87 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 69 | 74 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 88 | 77 | 10 | |
| InfoButton | mount | 11 | 10 | 5000 | Possible regression |
| MakeStyles | mount | 874 | 889 | 50000 | |
| Persona | mount | 1782 | 1707 | 5000 | |
| SpinButton | mount | 1406 | 1415 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: f61033d77d6852838c580bfa7379d026128c2dbb (build) |
bsunderhus
changed the title
ling1726
approved these changes
Sep 29, 2023
ling1726
reviewed
Sep 29, 2023
...nts/react-tree/src/components/TreeItemPersonaLayout/useTreeItemPersonaLayoutStyles.styles.ts
Outdated
Show resolved
Hide resolved
bsunderhus
force-pushed
the
react-tree/chore--focus-outline-on-layout
branch
from
41db45f to
c77e932
Compare
bsunderhus
force-pushed
the
react-tree/chore--focus-outline-on-layout
branch
from
c77e932 to
d2e6839
Compare
fabricteam
reviewed
Oct 2, 2023
ling1726
approved these changes
Oct 2, 2023
bsunderhus
modified the milestones:
September Project Cycle Q4 2023,
October Project Cycle Q4 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 4, 2023
* master: (146 commits) remove a11y test ux from theme designer (microsoft#29379) feat: preview release (microsoft#29377) Fixed divider in the tooltip (microsoft#29357) fix (microsoft#29376) docs: Initial documentation pass (microsoft#29372) feat: Integrate Announce context (microsoft#29362) chore(react-tags): stable release (microsoft#29355) chore: delegate focus outline to layout components (microsoft#29293) Vertical bar chart line bug (microsoft#29299) applying package updates Adding axis title examples for line, area, vertical bar and vertical stacked bar charts (microsoft#29254) A11y: Pagination: Add tooltip for all icon buttons (microsoft#29155) A11y: Fix aria attribute for page number and add correct role (microsoft#29349) feat: Implement motion for MessageBar (microsoft#29339) feat: creates getIntrinsicElementProps to replace getNativeElementProps on slots creation (microsoft#29310) chore: replace makeStyles with makeResetStyles (microsoft#29338) applying package updates ci(github/policies): remove bot rules that created and added `Component/Package $1`: labels on PRs (microsoft#29301) fix: handle multiple classes in PortalCompatProvider (microsoft#29351) applying package updates ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 4, 2023
* master: (49 commits) remove a11y test ux from theme designer (microsoft#29379) feat: preview release (microsoft#29377) Fixed divider in the tooltip (microsoft#29357) fix (microsoft#29376) docs: Initial documentation pass (microsoft#29372) feat: Integrate Announce context (microsoft#29362) chore(react-tags): stable release (microsoft#29355) chore: delegate focus outline to layout components (microsoft#29293) Vertical bar chart line bug (microsoft#29299) applying package updates Adding axis title examples for line, area, vertical bar and vertical stacked bar charts (microsoft#29254) A11y: Pagination: Add tooltip for all icon buttons (microsoft#29155) A11y: Fix aria attribute for page number and add correct role (microsoft#29349) feat: Implement motion for MessageBar (microsoft#29339) feat: creates getIntrinsicElementProps to replace getNativeElementProps on slots creation (microsoft#29310) chore: replace makeStyles with makeResetStyles (microsoft#29338) applying package updates ci(github/policies): remove bot rules that created and added `Component/Package $1`: labels on PRs (microsoft#29301) fix: handle multiple classes in PortalCompatProvider (microsoft#29351) applying package updates ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Focus outline is on the
TreeItemcomponent as this is the actual focused component, this is a problem on nested trees as theTreeItemwill contain inside of it a subtree with more tree itemsNew Behavior
Focus outline should be on the
TreeItemLayoutcomponent (although the actual focus is on theTreeItem), this way the focus will be visually on a single element even when focusing on a tree item with other tree items inside of it.Related Issue(s)