-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat: implement motion for Drawer #28133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 60 commits
Commits
Show all changes
143 commits
Select commit
Hold shift + click to select a range
a259627
feat: implement motion for Drawer
marcosmoura a536462
feat: add events based on presence state
marcosmoura 77ca96d
docs: create motion documentation
marcosmoura 8a885d1
docs: add custom motion docs
marcosmoura 88def1b
feat: make transition duration based on drawer size
marcosmoura 010b9fd
dcos: add missing non-modal example
marcosmoura a282740
docs: improve documentation examples to align with motion
marcosmoura 7cd0c8b
fix: generate api
marcosmoura 2e31660
fix: improve imports/exports
marcosmoura 68eab21
fix: improve imports/exports
marcosmoura 251dbd6
fix: add missing changefiles
marcosmoura f3a79d2
refactor: improve overall performance of usePresenceState
marcosmoura 182ea1c
fix: restore styles
marcosmoura 318e9be
fix: improve typings of usePresenceState
marcosmoura e91ea3e
feat: refactor motion hooks to not fire multiple transition events
marcosmoura d7061f9
fix: wrong imports inside stories
marcosmoura 892c4ff
fix: use safe timeout
marcosmoura 580c895
fix: move hook to a dedicated folder
marcosmoura dcd6043
feat: cache styles to only read it when ref changes
marcosmoura d20cece
feat: improve documentation
marcosmoura 8978acf
feat: generate API
marcosmoura 0cb7d13
docs: add better documentation for the hook
marcosmoura 2fafeae
fix: rename variables for better naming
marcosmoura 0b5f2f6
feat: make transitionPresence hook available in react-utilities and a…
marcosmoura 8937475
fix: add missing changefiles
marcosmoura 53ef031
Merge branch 'master' into feat/drawer-motion
marcosmoura b9db84b
fix: expose fewer data to state
marcosmoura 8944102
fix: rename variable
marcosmoura 1be28ce
feat: support css animations as well
marcosmoura 3403a69
fix: make sure object exists before calling
marcosmoura d003320
fix: remove console.log
marcosmoura e1c0990
fix: rename useTransitionPresence to useMotionPresence
marcosmoura 5fa9082
fix: make possible to override and remove transitions
marcosmoura d1292a7
Merge branch 'master' into feat/drawer-motion
marcosmoura a07be56
fix: remove redundant types
marcosmoura dbf907a
Merge branch 'master' into feat/drawer-motion
marcosmoura b000438
docs: add toggle button
marcosmoura 3e9cb0e
fix: remove redundant types
marcosmoura 9f3fc91
Merge branch 'master' into feat/drawer-motion
marcosmoura 38e7bc6
fix: regenerate API files
marcosmoura d2df033
Merge branch 'master' into feat/drawer-motion
marcosmoura a1d9623
Merge branch 'master' into feat/drawer-motion
marcosmoura 27accc9
docs: regenerate API
marcosmoura fd8edd5
docs: remove testing class
marcosmoura b97fe45
feat: syncronize the root/backdrop transition duration
marcosmoura 31c97b8
Merge branch 'master' into feat/drawer-motion
marcosmoura ddae7e1
Merge branch 'master' into feat/drawer-motion
marcosmoura c6c9711
Merge branch 'master' into feat/drawer-motion
marcosmoura 0717cd9
refactor: simplify logic and use computedStyleMap if browser supports it
marcosmoura f08ba00
fix: calculate transition/animation delays in pairs
marcosmoura 56f2638
fix: calculate transition/animation delays in pairs
marcosmoura 0f437db
fix: rename param
marcosmoura 0c98289
feat: add unmounted state and initial tests
marcosmoura 4dd835b
feat: add flag to prevent element to animate on first render
marcosmoura da7a182
fix: add more tests and fix "animateOnFirstMount" not working when tr…
marcosmoura 6a4d05f
fix: add timer explanation
marcosmoura d2287fc
fix: improve TS types/docs and simplify logic
marcosmoura b2d98bb
fix: add transition to box-shadow to prevent glitchy exit animation
marcosmoura 71a0c25
fix: conflicts
marcosmoura 1faa4c8
feat: implement useMotionPresence hook
marcosmoura 230e273
docs: add missing change files
marcosmoura 992cdc7
Merge branch 'master' into feat/drawer-motion
marcosmoura 5da0258
fix: simplify backdrop slot code
marcosmoura b8128e7
fix: improve performance of duration calculation
marcosmoura c721171
feat: implement useAnimationFrame hook to help controlling the motion…
marcosmoura 6bbf319
fix: improve type definition to avoid typecast
marcosmoura 44b58d5
fix: return a blank style declaration in case global "window" do not …
marcosmoura b3124d6
fix: regenerate API
marcosmoura caef0bd
fix: regenerate API
marcosmoura 8234217
Merge branch 'master' into feat/drawer-motion
marcosmoura ac4e941
Merge branch 'master' into feat/use-motion-presence-hook
marcosmoura 8fa8f4a
revert: use RefCallback instead of Ref
marcosmoura 45ac91f
fix: regenerate API
marcosmoura 2497b77
Merge branch 'master' into feat/use-motion-presence-hook
marcosmoura cceb832
fix: regenerate API
marcosmoura 91cdd11
Merge branch 'master' into feat/use-motion-presence-hook
marcosmoura 2e5f04b
docs: improve examples
marcosmoura f1270bb
Merge branch 'master' into feat/drawer-motion
marcosmoura 6061b95
feat: simplify logic of useMotionPresence
marcosmoura d3cbded
feat: simplify API by removing redundant prop
marcosmoura 28fecae
feat: implement useMotion hook instead of useMotionPresence
marcosmoura 003dab8
Merge branch 'master' into feat/drawer-motion
marcosmoura ba8e3fd
Merge branch 'master' into feat/drawer-motion
marcosmoura cfea341
Merge branch 'master' into feat/use-motion-presence-hook
marcosmoura ab9ff66
feat: implement useMotion hook instead of useMotionPresence
marcosmoura 76d1b82
feat: remove useMotionPresence hook
marcosmoura 7fd87f9
fix: remove old changefile
marcosmoura 1e16743
feat: expose useAnimationFrame hook
marcosmoura 41e9e8c
fix: add missing changefile
marcosmoura 647b9e5
Merge branch 'master' into feat/use-motion-presence-hook
marcosmoura f384b82
fix: mismatch dependencies
marcosmoura ce4d183
feat: add motion docs to public site
marcosmoura 05ba7e1
docs: add documentatio for the hook
marcosmoura 5524088
chore: motion with slots
bsunderhus 2068001
feat: implement useMotionFromSlot to better resolve slots with motion…
marcosmoura 1577e9a
feat: create method canRender
marcosmoura 311f5e6
feat: only apply internal motion classes in case no external motion i…
marcosmoura d76e3df
Merge branch 'master' into feat/drawer-motion
marcosmoura f2f976e
fix: mismatch dependencies and regenerate API files
marcosmoura 233c8bc
feat: add missing change files
marcosmoura feeacab
fix: misc little fixes
marcosmoura 7cf6886
fix: misc perf fixes
marcosmoura 392eff5
feat: make react-motion-preview public
marcosmoura e9e8bbe
feat: create useMotion hook accepting either a boolean or motion state
marcosmoura 9152d81
Merge branch 'master' into feat/use-motion-presence-hook
marcosmoura 3872d0a
fix: upgrade stories to use latest changes to hook
marcosmoura d8cdb72
feat: create useMotionStyles to make it easier motion styles to any c…
marcosmoura 6debd98
feat: make package public
marcosmoura 7f27429
fix: add missing change file
marcosmoura 9593026
fix: join two related hooks in one file to be easier to test
marcosmoura fd9970f
fix: remove unused imports
marcosmoura 5cb0a56
docs: move stories to public site
marcosmoura 92ecfed
docs: add title to example
marcosmoura 190493f
Merge branch 'master' into feat/use-motion-presence-hook
marcosmoura 9086d1a
fix: remove leftover property
marcosmoura 969ce87
fix: add type to improve useMemo
marcosmoura 32d4144
fix: use correct import paths
marcosmoura 1d8e9b8
Merge branch 'master' into feat/use-motion-presence-hook
marcosmoura c437db6
Merge branch 'master' into feat/use-motion-presence-hook
marcosmoura f09ff57
feat: use boolean instead of function
marcosmoura e6bb24b
Merge branch 'master' into feat/use-motion-presence-hook
marcosmoura a1616d2
fix: remove outdated changefile
marcosmoura 74b8257
fix: use correct boolean values
marcosmoura 7942e80
fix: improve typings and documentation
marcosmoura 2d89ef2
Merge branch 'master' into feat/use-motion-presence-hook
marcosmoura e869087
Merge branch 'master' into feat/drawer-motion
marcosmoura e88d95a
Merge branch 'feat/use-motion-presence-hook' into feat/drawer-motion
marcosmoura 7606af3
Merge branch 'master' into feat/drawer-motion
marcosmoura b37b106
Discard changes to packages/react-charting/src/components/AreaChart/A…
marcosmoura 48c370e
Discard changes to packages/react-charting/src/components/HorizontalB…
marcosmoura e98ca40
Discard changes to packages/react-charting/src/components/StackedBarC…
marcosmoura 4b27637
Discard changes to packages/react-charting/src/components/LineChart/L…
marcosmoura 74f6a08
Discard changes to packages/react-charting/src/components/StackedBarC…
marcosmoura fa92c7f
Merge branch 'master' into feat/drawer-motion
marcosmoura 58b1e52
Merge branch 'master' into feat/drawer-motion
marcosmoura 491c0df
Discard changes to .github/CODEOWNERS
marcosmoura dd3cf56
Discard changes to apps/vr-tests/src/stories/react-charting/StackedBa…
marcosmoura ccf1188
Discard changes to packages/react-components/react-drawer/stories/Dra…
marcosmoura 482064c
Discard changes to packages/react-components/react-drawer/stories/Dra…
marcosmoura 88180b4
Discard changes to packages/react-components/react-motion-preview/src…
marcosmoura 02baa6c
Discard changes to packages/react-components/react-motion-preview/sto…
marcosmoura d4a3b04
Merge branch 'master' into feat/drawer-motion
marcosmoura cad2b49
upgrade styles
marcosmoura File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@fluentui-react-components-05ea9e2c-59c4-4b95-8d7a-e6fc6ee1bb5c.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "minor", | ||
| "comment": "feat: make useTransitionPresence hook", | ||
| "packageName": "@fluentui/react-components", | ||
| "email": "marcosvmmoura@gmail.com", | ||
| "dependentChangeType": "patch" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@fluentui-react-drawer-906d4815-2dd6-43b5-af6e-4ef4571ed915.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "prerelease", | ||
| "comment": "feat: add transition on open/close", | ||
| "packageName": "@fluentui/react-drawer", | ||
| "email": "marcosvmmoura@gmail.com", | ||
| "dependentChangeType": "patch" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@fluentui-react-utilities-02937573-2ff4-49a6-8fec-9dbc38b1644a.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "minor", | ||
| "comment": "feat: make useTransitionPresence hook", | ||
| "packageName": "@fluentui/react-utilities", | ||
| "email": "marcosvmmoura@gmail.com", | ||
| "dependentChangeType": "patch" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.