Skip to content

Conversation

@ling1726
Copy link
Contributor

@ling1726 ling1726 commented Oct 2, 2023

Integrates the shared AnnounceContext to the MessageBar. The default narration should not include the container actions which is generally the 'close' button of the message bar.

Addresses: #22579
Related to #29371

Integrates the shared AnnounceContext to the MessageBar. The default
narration should not include the container actions which is generally
the 'close' button of the message bar.
@ling1726 ling1726 marked this pull request as ready for review October 2, 2023 19:31
@ling1726 ling1726 requested a review from a team as a code owner October 2, 2023 19:31
@github-actions github-actions bot added this to the October Project Cycle Q4 2023 milestone Oct 2, 2023
@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 20ce41b1804af616985f527761602d49a9d58dd2

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 2, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 07fc3dd:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 2, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 20ce41b1804af616985f527761602d49a9d58dd2 (build)

@ling1726 ling1726 merged commit b1c71b3 into microsoft:master Oct 3, 2023
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 4, 2023
* master: (146 commits)
  remove a11y test ux from theme designer (microsoft#29379)
  feat: preview release (microsoft#29377)
  Fixed divider in the tooltip (microsoft#29357)
  fix (microsoft#29376)
  docs: Initial documentation pass (microsoft#29372)
  feat: Integrate Announce context (microsoft#29362)
  chore(react-tags): stable release (microsoft#29355)
  chore: delegate focus outline to layout components (microsoft#29293)
  Vertical bar chart line bug (microsoft#29299)
  applying package updates
  Adding axis title examples for line, area, vertical bar and vertical stacked bar charts (microsoft#29254)
  A11y: Pagination: Add tooltip for all icon buttons  (microsoft#29155)
  A11y: Fix aria attribute for page number and add correct role (microsoft#29349)
  feat: Implement motion for MessageBar (microsoft#29339)
  feat: creates getIntrinsicElementProps to replace getNativeElementProps on slots creation (microsoft#29310)
  chore: replace makeStyles with makeResetStyles (microsoft#29338)
  applying package updates
  ci(github/policies): remove bot rules that created and added `Component/Package $1`: labels on PRs (microsoft#29301)
  fix: handle multiple classes in PortalCompatProvider (microsoft#29351)
  applying package updates
  ...
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 4, 2023
* master: (49 commits)
  remove a11y test ux from theme designer (microsoft#29379)
  feat: preview release (microsoft#29377)
  Fixed divider in the tooltip (microsoft#29357)
  fix (microsoft#29376)
  docs: Initial documentation pass (microsoft#29372)
  feat: Integrate Announce context (microsoft#29362)
  chore(react-tags): stable release (microsoft#29355)
  chore: delegate focus outline to layout components (microsoft#29293)
  Vertical bar chart line bug (microsoft#29299)
  applying package updates
  Adding axis title examples for line, area, vertical bar and vertical stacked bar charts (microsoft#29254)
  A11y: Pagination: Add tooltip for all icon buttons  (microsoft#29155)
  A11y: Fix aria attribute for page number and add correct role (microsoft#29349)
  feat: Implement motion for MessageBar (microsoft#29339)
  feat: creates getIntrinsicElementProps to replace getNativeElementProps on slots creation (microsoft#29310)
  chore: replace makeStyles with makeResetStyles (microsoft#29338)
  applying package updates
  ci(github/policies): remove bot rules that created and added `Component/Package $1`: labels on PRs (microsoft#29301)
  fix: handle multiple classes in PortalCompatProvider (microsoft#29351)
  applying package updates
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants