Skip to content

Conversation

@micahgodbolt
Copy link
Member

Addresses a couple issues found in #24610

Now that the CDN is immutable, each deploy has a unique URL, so core we can't just add 11.0.1 to the old core URL and get the new version...we need to update the entire URL with the build number. Fortunately, core doesn't rev all that often.

Secondly, it seems the ID that used to be on the 'back to top' button has been removed, so I updated the selector to something that SHOULD be static.

@micahgodbolt micahgodbolt enabled auto-merge (squash) August 31, 2022 16:16
@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 21af8da1d98c070a682b26b7d56775d43a749b3d

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9bc73ec:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@micahgodbolt micahgodbolt merged commit 0174dfc into microsoft:master Aug 31, 2022
@size-auditor
Copy link

size-auditor bot commented Aug 31, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 21af8da1d98c070a682b26b7d56775d43a749b3d (build)

marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 1, 2022
* master: (99 commits)
  applying package updates
  add coastal to @fluentui/react package and components (microsoft#24599)
  fix(react-18-tests-v9): extend correct tsconfig.json (microsoft#24626)
  feat(react-18-tests-v9): Add cypress setup to enable writing cypress tests (microsoft#24619)
  chore: Removing CompoundButtonAsToggleButton story since it was importing non-exported functions (microsoft#24620)
  Update PeoplePicker focus styles for the close button - Add borderRadius to getFocusStyle (microsoft#24596)
  fix(react-theme): Rename colorNeutralForegroundInvertedStatic token to colorNeutralForegroundStaticInverted (microsoft#24611)
  Website fabric core (microsoft#24613)
  fix(react-theme) update react theme colors mapping (microsoft#24608)
  Remove downloaded artifact file after using it (microsoft#24606)
  Fix artifact downloading race condition (microsoft#24607)
  chore(deps): bump moment-timezone from 0.5.34 to 0.5.37 (microsoft#24604)
  Remove check for commit existence and make it optional (microsoft#24587)
  Update "screener-build.yml" to include lage's output (microsoft#24586)
  fix(react-theme): Change colorBrandForeground2 mapping in teamsDark theme (microsoft#24579)
  Add scoping for workflow (microsoft#24466)
  fix(react-theme): Swap Background1 and Foreground1 in HC color palette (microsoft#24498)
  applying package updates
  Add support for javascript date localization (microsoft#24577)
  fix: Combobox and Dropdown hover/active borders and padding style fixes (microsoft#24362)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants