Update PeoplePicker focus styles for the close button - Add borderRadius to getFocusStyle #24596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahgodbolt
added
Component: PeoplePicker
Fluent UI react (v8)
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e11c64c:
|
Asset size changes
Baseline commit: 0174dfc96d5ea925268fb3f51efaa6373ecabcc6 (build) |
Collaborator
📊 Bundle size report🤖 This report was generated against 0174dfc96d5ea925268fb3f51efaa6373ecabcc6 |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 767 | 766 | 5000 | |
| Breadcrumb | mount | 2474 | 2429 | 1000 | |
| Checkbox | mount | 2222 | 2214 | 5000 | |
| CheckboxBase | mount | 1916 | 1938 | 5000 | |
| ChoiceGroup | mount | 3956 | 3953 | 5000 | |
| ComboBox | mount | 826 | 813 | 1000 | |
| CommandBar | mount | 9017 | 9067 | 1000 | |
| ContextualMenu | mount | 10426 | 10460 | 1000 | |
| DefaultButton | mount | 949 | 971 | 5000 | |
| DetailsRow | mount | 3220 | 3285 | 5000 | |
| DetailsRowFast | mount | 3247 | 3252 | 5000 | |
| DetailsRowNoStyles | mount | 3103 | 3101 | 5000 | |
| Dialog | mount | 2661 | 2685 | 1000 | |
| DocumentCardTitle | mount | 155 | 146 | 1000 | |
| Dropdown | mount | 2849 | 2817 | 5000 | |
| FocusTrapZone | mount | 1616 | 1622 | 5000 | |
| FocusZone | mount | 1550 | 1555 | 5000 | |
| IconButton | mount | 1497 | 1484 | 5000 | |
| Label | mount | 301 | 306 | 5000 | |
| Layer | mount | 3859 | 3849 | 5000 | |
| Link | mount | 406 | 396 | 5000 | |
| MenuButton | mount | 1235 | 1271 | 5000 | |
| MessageBar | mount | 1812 | 1851 | 5000 | |
| Nav | mount | 2861 | 2828 | 1000 | |
| OverflowSet | mount | 949 | 920 | 5000 | |
| Panel | mount | 2118 | 2081 | 1000 | |
| Persona | mount | 838 | 848 | 1000 | |
| Pivot | mount | 1214 | 1229 | 1000 | |
| PrimaryButton | mount | 1101 | 1093 | 5000 | |
| Rating | mount | 6575 | 6575 | 5000 | |
| SearchBox | mount | 1079 | 1070 | 5000 | |
| Shimmer | mount | 2439 | 2430 | 5000 | |
| Slider | mount | 1658 | 1656 | 5000 | |
| SpinButton | mount | 4266 | 4301 | 5000 | |
| Spinner | mount | 380 | 374 | 5000 | |
| SplitButton | mount | 2672 | 2690 | 5000 | |
| Stack | mount | 426 | 446 | 5000 | |
| StackWithIntrinsicChildren | mount | 1981 | 1954 | 5000 | |
| StackWithTextChildren | mount | 4420 | 4431 | 5000 | |
| SwatchColorPicker | mount | 10051 | 10183 | 5000 | |
| TagPicker | mount | 2198 | 2265 | 5000 | |
| TeachingBubble | mount | 83122 | 82318 | 5000 | |
| Text | mount | 366 | 364 | 5000 | |
| TextField | mount | 1173 | 1167 | 5000 | |
| ThemeProvider | mount | 1092 | 1108 | 5000 | |
| ThemeProvider | virtual-rerender | 650 | 650 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1728 | 1738 | 5000 | |
| Toggle | mount | 674 | 666 | 5000 | |
| buttonNative | mount | 123 | 119 | 5000 |
spmonahan
reviewed
Aug 31, 2022
| border: `${width}px solid ${borderColor}`, | ||
| outline: `${width}px solid ${outlineColor}`, | ||
| zIndex: ZIndexes.FocusStyle, | ||
| borderRadius: borderRadius, |
Contributor
There was a problem hiding this comment.
Does this also allow the shorthand, e.g.:
border-radius: 1px 2px 3px 4px?
Member
Author
There was a problem hiding this comment.
it allows string or number
smhigley
approved these changes
Aug 31, 2022
Contributor
smhigley
left a comment
smhigley
left a comment
There was a problem hiding this comment.
It looks good! It feels a bit weird to allow a unitless borderRadius, but I guess we already do it with width and inset, so ¯_(ツ)_/¯
| getFocusStyle(theme, { | ||
| inset: 2, | ||
| borderColor: 'transparent', | ||
| highContrastStyle: { left: 1, top: 1, bottom: 1, right: 1, outlineColor: 'ButtonText' }, |
Contributor
There was a problem hiding this comment.
very minor nit: since we use inset above, it might be nice to use inset: 1 here too
spmonahan
approved these changes
Aug 31, 2022
Member
Author
|
just following the typings of normal border radii
|
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 1, 2022
* master: (99 commits) applying package updates add coastal to @fluentui/react package and components (microsoft#24599) fix(react-18-tests-v9): extend correct tsconfig.json (microsoft#24626) feat(react-18-tests-v9): Add cypress setup to enable writing cypress tests (microsoft#24619) chore: Removing CompoundButtonAsToggleButton story since it was importing non-exported functions (microsoft#24620) Update PeoplePicker focus styles for the close button - Add borderRadius to getFocusStyle (microsoft#24596) fix(react-theme): Rename colorNeutralForegroundInvertedStatic token to colorNeutralForegroundStaticInverted (microsoft#24611) Website fabric core (microsoft#24613) fix(react-theme) update react theme colors mapping (microsoft#24608) Remove downloaded artifact file after using it (microsoft#24606) Fix artifact downloading race condition (microsoft#24607) chore(deps): bump moment-timezone from 0.5.34 to 0.5.37 (microsoft#24604) Remove check for commit existence and make it optional (microsoft#24587) Update "screener-build.yml" to include lage's output (microsoft#24586) fix(react-theme): Change colorBrandForeground2 mapping in teamsDark theme (microsoft#24579) Add scoping for workflow (microsoft#24466) fix(react-theme): Swap Background1 and Foreground1 in HC color palette (microsoft#24498) applying package updates Add support for javascript date localization (microsoft#24577) fix: Combobox and Dropdown hover/active borders and padding style fixes (microsoft#24362) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24578
before
after