Skip to content

Conversation

@AtishayMsft
Copy link
Contributor

Current Behavior

Currently the dates of an axis cannot be localized using the localization support provided by javascript.

New Behavior

Provide support for localizing dates of axis using javascript provided toLocaleString method.

Related Issue(s)

Fixes #

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 30, 2022

📊 Bundle size report

🤖 This report was generated against 286479fb4e813506a9560c279215675e8b097500

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 30, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dcd0a3b:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Aug 30, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 286479fb4e813506a9560c279215675e8b097500 (build)

@AtishayMsft AtishayMsft marked this pull request as ready for review August 30, 2022 04:23
@AtishayMsft AtishayMsft requested a review from a team as a code owner August 30, 2022 04:23
@AtishayMsft AtishayMsft merged commit 1fe1f9b into master Aug 30, 2022
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 1, 2022
* master: (99 commits)
  applying package updates
  add coastal to @fluentui/react package and components (microsoft#24599)
  fix(react-18-tests-v9): extend correct tsconfig.json (microsoft#24626)
  feat(react-18-tests-v9): Add cypress setup to enable writing cypress tests (microsoft#24619)
  chore: Removing CompoundButtonAsToggleButton story since it was importing non-exported functions (microsoft#24620)
  Update PeoplePicker focus styles for the close button - Add borderRadius to getFocusStyle (microsoft#24596)
  fix(react-theme): Rename colorNeutralForegroundInvertedStatic token to colorNeutralForegroundStaticInverted (microsoft#24611)
  Website fabric core (microsoft#24613)
  fix(react-theme) update react theme colors mapping (microsoft#24608)
  Remove downloaded artifact file after using it (microsoft#24606)
  Fix artifact downloading race condition (microsoft#24607)
  chore(deps): bump moment-timezone from 0.5.34 to 0.5.37 (microsoft#24604)
  Remove check for commit existence and make it optional (microsoft#24587)
  Update "screener-build.yml" to include lage's output (microsoft#24586)
  fix(react-theme): Change colorBrandForeground2 mapping in teamsDark theme (microsoft#24579)
  Add scoping for workflow (microsoft#24466)
  fix(react-theme): Swap Background1 and Foreground1 in HC color palette (microsoft#24498)
  applying package updates
  Add support for javascript date localization (microsoft#24577)
  fix: Combobox and Dropdown hover/active borders and padding style fixes (microsoft#24362)
  ...
@khmakoto khmakoto deleted the usr/atisjai/0826_localizeDate branch April 5, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants