Skip to content

fix(react-theme) update react theme colors mapping #24608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miroslavstastny merged 4 commits into from
Aug 31, 2022
Merged

fix(react-theme) update react theme colors mapping #24608

miroslavstastny merged 4 commits into from
Aug 31, 2022

Conversation

@miroslavstastny
Copy link
Member

@miroslavstastny miroslavstastny commented Aug 31, 2022

New Behavior

darkTheme

Updated tokens

  • CompoundBrandStroke Brand.90 -> Brand.100
  • CompoundBrandStrokeHover Brand.100 -> Brand.110
  • CompoundBrandStrokePressed Brand.80 -> Brand.90

Spec
image

Code
image

teamsDarkTheme

Updated token

  • NeutralBackgroundInverted Grey.20 -> White

Spec
image

Code
image

@miroslavstastny miroslavstastny requested a review from a team as a code owner August 31, 2022 11:17
@github-actions github-actions bot added this to the July Project Cycle Q3 2022 milestone Aug 31, 2022
@miroslavstastny miroslavstastny self-assigned this Aug 31, 2022
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 31, 2022 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: FluentProvider & webLightTheme		 33.259 kB
10.952 kB		 33.259 kB
10.951 kB
-1 B
react-theme
Teams: all themes		 29.548 kB
6.434 kB		 29.548 kB
6.433 kB
-1 B
react-theme
Teams: Light theme		 17.452 kB
5.054 kB		 17.452 kB
5.053 kB
-1 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-accordion
Accordion (including children components)		 79.349 kB
24.053 kB
react-alert
Alert		 83.79 kB
20.841 kB
react-avatar
Avatar		 48.283 kB
13.644 kB
react-avatar
AvatarGroup		 14.85 kB
5.942 kB
react-avatar
AvatarGroupItem		 68.251 kB
18.987 kB
react-badge
Badge		 22.503 kB
7.153 kB
react-badge
CounterBadge		 23.406 kB
7.449 kB
react-badge
PresenceBadge		 23.947 kB
7.022 kB
react-button
Button		 36.396 kB
9.579 kB
react-button
CompoundButton		 43.469 kB
10.812 kB
react-button
MenuButton		 39.014 kB
10.456 kB
react-button
SplitButton		 46.544 kB
11.84 kB
react-button
ToggleButton		 51.91 kB
11.003 kB
react-card
Card - All		 67.458 kB
19.264 kB
react-card
Card		 63.14 kB
18.176 kB
react-card
CardFooter		 8.461 kB
3.555 kB
react-card
CardHeader		 9.504 kB
3.896 kB
react-card
CardPreview		 8.562 kB
3.61 kB
react-combobox
Combobox (including child components)		 73.757 kB
23.969 kB
react-combobox
Dropdown (including child components)		 73.344 kB
23.876 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 188.818 kB
51.901 kB
react-dialog
Dialog (including children components)		 85.361 kB
25.458 kB
react-divider
Divider		 16.359 kB
5.853 kB
react-image
Image		 10.68 kB
4.215 kB
react-input
Input		 23.498 kB
7.617 kB
react-label
Label		 9.238 kB
3.815 kB
react-link
Link		 12.231 kB
4.925 kB
react-menu
Menu (including children components)		 115.697 kB
35.316 kB
react-menu
Menu (including selectable components)		 118.896 kB
35.806 kB
react-overflow
hooks only		 10.685 kB
4.104 kB
react-popover
Popover		 102.837 kB
31.496 kB
react-portal
Portal		 10.576 kB
3.875 kB
react-positioning
usePositioning		 19.7 kB
7.404 kB
react-provider
FluentProvider		 15.655 kB
5.835 kB
react-radio
Radio		 36.025 kB
11.914 kB
react-radio
RadioGroup		 14.148 kB
5.654 kB
react-select
Select		 20.746 kB
7.299 kB
react-slider
Slider		 32.07 kB
10.033 kB
react-spinbutton
SpinButton		 43.843 kB
12.336 kB
react-spinner
Spinner		 19.855 kB
6.384 kB
react-switch
Switch		 32.562 kB
10.253 kB
react-text
Text - Default		 11.682 kB
4.561 kB
react-text
Text - Wrappers		 14.992 kB
4.995 kB
react-textarea
Textarea		 23.674 kB
7.83 kB
react-theme
Single theme token import		 69 B
89 B
react-tooltip
Tooltip		 41.504 kB
14.622 kB
🤖 This report was generated against d1e8f0764fb477271da45f0dd1f4c1b3beb06699

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 31, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1529 1554 5000
Button mount 1141 1113 5000
FluentProvider mount 1879 1839 5000
FluentProviderWithTheme mount 753 754 10
FluentProviderWithTheme virtual-rerender 702 702 10
FluentProviderWithTheme virtual-rerender-with-unmount 737 740 10
MakeStyles mount 2234 2246 50000
SpinButton mount 3037 3005 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 31, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bab4c48:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Aug 31, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d1e8f0764fb477271da45f0dd1f4c1b3beb06699 (build)

@miroslavstastny miroslavstastny changed the title Fix/update react theme fix(react-theme) update react theme colors mapping Aug 31, 2022
@miroslavstastny miroslavstastny merged commit 21af8da into microsoft:master Aug 31, 2022
@miroslavstastny miroslavstastny deleted the fix/update-react-theme branch August 31, 2022 12:46
@spmonahan spmonahan mentioned this pull request Aug 31, 2022
Closed
2 tasks
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 1, 2022
@marcosmoura
Merge branch 'master' into marcosmoura/feat/selectable-cards
507848a 
* master: (99 commits)
  applying package updates
  add coastal to @fluentui/react package and components (microsoft#24599)
  fix(react-18-tests-v9): extend correct tsconfig.json (microsoft#24626)
  feat(react-18-tests-v9): Add cypress setup to enable writing cypress tests (microsoft#24619)
  chore: Removing CompoundButtonAsToggleButton story since it was importing non-exported functions (microsoft#24620)
  Update PeoplePicker focus styles for the close button - Add borderRadius to getFocusStyle (microsoft#24596)
  fix(react-theme): Rename colorNeutralForegroundInvertedStatic token to colorNeutralForegroundStaticInverted (microsoft#24611)
  Website fabric core (microsoft#24613)
  fix(react-theme) update react theme colors mapping (microsoft#24608)
  Remove downloaded artifact file after using it (microsoft#24606)
  Fix artifact downloading race condition (microsoft#24607)
  chore(deps): bump moment-timezone from 0.5.34 to 0.5.37 (microsoft#24604)
  Remove check for commit existence and make it optional (microsoft#24587)
  Update "screener-build.yml" to include lage's output (microsoft#24586)
  fix(react-theme): Change colorBrandForeground2 mapping in teamsDark theme (microsoft#24579)
  Add scoping for workflow (microsoft#24466)
  fix(react-theme): Swap Background1 and Foreground1 in HC color palette (microsoft#24498)
  applying package updates
  Add support for javascript date localization (microsoft#24577)
  fix: Combobox and Dropdown hover/active borders and padding style fixes (microsoft#24362)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsunderhus bsunderhus bsunderhus approved these changes

Assignees

@miroslavstastny miroslavstastny

Labels

None yet

Projects

None yet

Milestone

July Project Cycle Q3 2022

Development

Successfully merging this pull request may close these issues.

4 participants

@miroslavstastny @fabricteam @bsunderhus @micahgodbolt