Skip to content

Conversation

@ralucapelin
Copy link
Contributor

@ralucapelin ralucapelin commented Aug 23, 2022

Current Behavior

ADO pipelines is used to scope, build and deploy screener tests.

New Behavior

ADO pipelines are replaced with two GitHub Actions workflows:

  • screener-build.yml scopes the test app, builds it and uploads it as an artifact if necessary(i.e. the build is not skipped)
  • screener-run.yml downloads the artifact and uploads the tests to blob storage if necessary then starts the screener runner

Related Issue(s)

Addresses #23903

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 23, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
533 B
341 B
global-context
createContextSelector
554 B
348 B
priority-overflow
createOverflowManager
2.936 kB
1.212 kB
react-accordion
Accordion (including children components)
79.349 kB
24.053 kB
react-alert
Alert
83.79 kB
20.841 kB
react-avatar
Avatar
48.283 kB
13.644 kB
react-avatar
AvatarGroup
14.85 kB
5.942 kB
react-avatar
AvatarGroupItem
68.251 kB
18.987 kB
react-badge
Badge
22.503 kB
7.153 kB
react-badge
CounterBadge
23.406 kB
7.449 kB
react-badge
PresenceBadge
23.947 kB
7.022 kB
react-button
Button
36.396 kB
9.579 kB
react-button
CompoundButton
43.469 kB
10.812 kB
react-button
MenuButton
39.014 kB
10.456 kB
react-button
SplitButton
46.544 kB
11.84 kB
react-button
ToggleButton
51.91 kB
11.003 kB
react-card
Card - All
67.458 kB
19.264 kB
react-card
Card
63.14 kB
18.176 kB
react-card
CardFooter
8.461 kB
3.555 kB
react-card
CardHeader
9.504 kB
3.896 kB
react-card
CardPreview
8.562 kB
3.61 kB
react-combobox
Combobox (including child components)
73.757 kB
23.969 kB
react-combobox
Dropdown (including child components)
73.344 kB
23.876 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
188.818 kB
51.901 kB
react-components
react-components: FluentProvider & webLightTheme
33.19 kB
10.921 kB
react-dialog
Dialog (including children components)
85.361 kB
25.458 kB
react-divider
Divider
16.359 kB
5.853 kB
react-image
Image
10.68 kB
4.215 kB
react-input
Input
23.498 kB
7.617 kB
react-label
Label
9.238 kB
3.815 kB
react-link
Link
12.231 kB
4.925 kB
react-menu
Menu (including children components)
115.697 kB
35.316 kB
react-menu
Menu (including selectable components)
118.896 kB
35.806 kB
react-overflow
hooks only
10.685 kB
4.104 kB
react-popover
Popover
102.837 kB
31.496 kB
react-portal
Portal
10.576 kB
3.875 kB
react-positioning
usePositioning
19.7 kB
7.404 kB
react-provider
FluentProvider
15.655 kB
5.835 kB
react-radio
Radio
36.025 kB
11.914 kB
react-radio
RadioGroup
14.148 kB
5.654 kB
react-select
Select
20.746 kB
7.299 kB
react-slider
Slider
32.07 kB
10.033 kB
react-spinbutton
SpinButton
43.843 kB
12.336 kB
react-spinner
Spinner
19.855 kB
6.384 kB
react-switch
Switch
32.562 kB
10.253 kB
react-text
Text - Default
11.682 kB
4.561 kB
react-text
Text - Wrappers
14.992 kB
4.995 kB
react-textarea
Textarea
23.674 kB
7.83 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
29.479 kB
6.396 kB
react-theme
Teams: Light theme
17.385 kB
5.024 kB
react-tooltip
Tooltip
41.504 kB
14.622 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against 75e8b2c9243c1fe4e3620446540d7e52048af13c

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 23, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1629 1663 5000
Button mount 1144 1164 5000
FluentProvider mount 1946 1917 5000
FluentProviderWithTheme mount 722 720 10
FluentProviderWithTheme virtual-rerender 666 667 10
FluentProviderWithTheme virtual-rerender-with-unmount 722 712 10
MakeStyles mount 2231 2213 50000
SpinButton mount 3324 3202 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 23, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5087bf6:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Aug 23, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 75e8b2c9243c1fe4e3620446540d7e52048af13c (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 23, 2022

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
DividerMinimalPerf.default 432 398 1.09:1
RefMinimalPerf.default 236 218 1.08:1
BoxMinimalPerf.default 382 360 1.06:1
ButtonSlotsPerf.default 643 608 1.06:1
TextMinimalPerf.default 395 373 1.06:1
ChatMinimalPerf.default 827 786 1.05:1
ChatWithPopoverPerf.default 441 420 1.05:1
AlertMinimalPerf.default 303 292 1.04:1
AttachmentSlotsPerf.default 1239 1189 1.04:1
ImageMinimalPerf.default 463 446 1.04:1
CardMinimalPerf.default 632 615 1.03:1
DropdownManyItemsPerf.default 786 761 1.03:1
LayoutMinimalPerf.default 416 402 1.03:1
ListCommonPerf.default 716 698 1.03:1
ListWith60ListItems.default 695 675 1.03:1
SkeletonMinimalPerf.default 383 372 1.03:1
SliderMinimalPerf.default 1867 1807 1.03:1
AccordionMinimalPerf.default 166 162 1.02:1
ChatDuplicateMessagesPerf.default 322 316 1.02:1
CheckboxMinimalPerf.default 2934 2885 1.02:1
DatepickerMinimalPerf.default 6393 6240 1.02:1
FormMinimalPerf.default 449 441 1.02:1
ListNestedPerf.default 631 617 1.02:1
LoaderMinimalPerf.default 753 737 1.02:1
MenuMinimalPerf.default 976 953 1.02:1
MenuButtonMinimalPerf.default 1925 1888 1.02:1
ProviderMinimalPerf.default 426 417 1.02:1
StatusMinimalPerf.default 761 749 1.02:1
ToolbarMinimalPerf.default 1044 1022 1.02:1
ButtonOverridesMissPerf.default 1688 1673 1.01:1
CarouselMinimalPerf.default 543 539 1.01:1
DialogMinimalPerf.default 834 826 1.01:1
InputMinimalPerf.default 1449 1436 1.01:1
ProviderMergeThemesPerf.default 1306 1292 1.01:1
SegmentMinimalPerf.default 383 381 1.01:1
TreeWith60ListItems.default 170 169 1.01:1
VideoMinimalPerf.default 829 823 1.01:1
DropdownMinimalPerf.default 3344 3341 1:1
EmbedMinimalPerf.default 4548 4529 1:1
HeaderSlotsPerf.default 863 861 1:1
SplitButtonMinimalPerf.default 4877 4879 1:1
IconMinimalPerf.default 737 735 1:1
AnimationMinimalPerf.default 581 584 0.99:1
AvatarMinimalPerf.default 206 209 0.99:1
ItemLayoutMinimalPerf.default 1306 1324 0.99:1
TableManyItemsPerf.default 2164 2187 0.99:1
TextAreaMinimalPerf.default 572 578 0.99:1
CustomToolbarPrototype.default 3026 3046 0.99:1
TooltipMinimalPerf.default 2641 2664 0.99:1
TreeMinimalPerf.default 887 898 0.99:1
LabelMinimalPerf.default 416 423 0.98:1
RosterPerf.default 2341 2382 0.98:1
FlexMinimalPerf.default 302 310 0.97:1
GridMinimalPerf.default 388 400 0.97:1
ListMinimalPerf.default 583 600 0.97:1
RadioGroupMinimalPerf.default 481 495 0.97:1
ReactionMinimalPerf.default 412 424 0.97:1
TableMinimalPerf.default 427 438 0.97:1
HeaderMinimalPerf.default 395 411 0.96:1
PortalMinimalPerf.default 162 169 0.96:1
ButtonMinimalPerf.default 199 210 0.95:1
PopupMinimalPerf.default 663 704 0.94:1
AttachmentMinimalPerf.default 169 181 0.93:1

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 23, 2022

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1030 1011 5000
Breadcrumb mount 3039 2955 1000
Checkbox mount 2985 2945 5000
CheckboxBase mount 2527 2610 5000
ChoiceGroup mount 5161 5205 5000
ComboBox mount 1041 1077 1000
CommandBar mount 11291 11460 1000
ContextualMenu mount 12772 12753 1000
DefaultButton mount 1293 1293 5000
DetailsRow mount 4179 4308 5000
DetailsRowFast mount 4121 4193 5000
DetailsRowNoStyles mount 4155 4036 5000
Dialog mount 3475 3426 1000
DocumentCardTitle mount 208 198 1000
Dropdown mount 3697 3687 5000
FocusTrapZone mount 2092 2061 5000
FocusZone mount 1924 1938 5000
IconButton mount 2019 2032 5000
Label mount 395 391 5000
Layer mount 4845 4886 5000
Link mount 515 526 5000
MenuButton mount 1683 1670 5000
MessageBar mount 2388 2441 5000
Nav mount 3669 3841 1000
OverflowSet mount 1206 1177 5000
Panel mount 2698 2663 1000
Persona mount 1095 1121 1000
Pivot mount 1537 1513 1000
PrimaryButton mount 1410 1448 5000
Rating mount 8938 8793 5000
SearchBox mount 1488 1463 5000
Shimmer mount 3236 3404 5000
Slider mount 2126 2212 5000
SpinButton mount 5592 5617 5000
Spinner mount 484 464 5000
SplitButton mount 3458 3527 5000
Stack mount 580 555 5000
StackWithIntrinsicChildren mount 2638 2569 5000
StackWithTextChildren mount 6003 6016 5000
SwatchColorPicker mount 12961 14021 5000
TagPicker mount 2931 2934 5000
TeachingBubble mount 102039 101693 5000
Text mount 498 487 5000
TextField mount 1485 1627 5000
ThemeProvider mount 1368 1411 5000
ThemeProvider virtual-rerender 815 806 5000
ThemeProvider virtual-rerender-with-unmount 2161 2179 5000
Toggle mount 901 883 5000
buttonNative mount 142 132 5000

@ralucapelin ralucapelin marked this pull request as ready for review August 30, 2022 08:06
@ralucapelin ralucapelin requested a review from a team as a code owner August 30, 2022 08:06
Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ralucapelin ralucapelin merged commit 2e140cb into master Aug 30, 2022
@ralucapelin ralucapelin deleted the add-screener-workflows branch August 30, 2022 11:24
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 1, 2022
* master: (99 commits)
  applying package updates
  add coastal to @fluentui/react package and components (microsoft#24599)
  fix(react-18-tests-v9): extend correct tsconfig.json (microsoft#24626)
  feat(react-18-tests-v9): Add cypress setup to enable writing cypress tests (microsoft#24619)
  chore: Removing CompoundButtonAsToggleButton story since it was importing non-exported functions (microsoft#24620)
  Update PeoplePicker focus styles for the close button - Add borderRadius to getFocusStyle (microsoft#24596)
  fix(react-theme): Rename colorNeutralForegroundInvertedStatic token to colorNeutralForegroundStaticInverted (microsoft#24611)
  Website fabric core (microsoft#24613)
  fix(react-theme) update react theme colors mapping (microsoft#24608)
  Remove downloaded artifact file after using it (microsoft#24606)
  Fix artifact downloading race condition (microsoft#24607)
  chore(deps): bump moment-timezone from 0.5.34 to 0.5.37 (microsoft#24604)
  Remove check for commit existence and make it optional (microsoft#24587)
  Update "screener-build.yml" to include lage's output (microsoft#24586)
  fix(react-theme): Change colorBrandForeground2 mapping in teamsDark theme (microsoft#24579)
  Add scoping for workflow (microsoft#24466)
  fix(react-theme): Swap Background1 and Foreground1 in HC color palette (microsoft#24498)
  applying package updates
  Add support for javascript date localization (microsoft#24577)
  fix: Combobox and Dropdown hover/active borders and padding style fixes (microsoft#24362)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants