Skip to content

Website fabric core #24613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
micahgodbolt merged 2 commits into from
Aug 31, 2022
Merged

Website fabric core #24613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86e73bf
update fabric core URL and change selector for back to top button
micahgodbolt Aug 31, 2022
9bc73ec
change file
micahgodbolt Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/public-docsite/src/root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ registerIcons({
},
});

const skipToMain = document.getElementById('uhfSkipToMain') as HTMLAnchorElement;
const skipToMain = document.querySelector('[href="#mainContent"]') as HTMLAnchorElement;
if (skipToMain) {
// This link points to #mainContent by default, which would be interpreted as a route in our app.
// Handle focusing the main content manually instead.
Expand Down
6 changes: 2 additions & 4 deletions apps/public-docsite/src/utilities/createSite.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,9 @@ if (window.__siteConfig?.baseCDNUrl) {

initializeIcons();

const corePackageVersion: string = require<any>('office-ui-fabric-core/package.json').version;
// blog storage is now immutable, so new versions of fabric-core will be at a new url based on the build number
addCSSToHeader(
'https://static2.sharepointonline.com/files/fabric/office-ui-fabric-core/' +
corePackageVersion +
'/css/fabric.min.css',
'https://res-1.cdn.office.net/files/fabric-cdn-prod_20220825.001/office-ui-fabric-core/11.0.1/css/fabric.min.css',
);

let rootElement: HTMLElement;
Expand Down
7 changes: 7 additions & 0 deletions change/@fluentui-public-docsite-setup-fead5804-7705-4646-842d-5bfbf4fd7a28.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: update fabric core URL and change selector for back to top button",
"packageName": "@fluentui/public-docsite-setup",
"email": "[email protected]",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion packages/public-docsite-setup/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@

<body>
<!-- Copied from UHF site -->
<a id="uhfSkipToMain" class="m-skip-to-main" href="#mainContent" tabindex="0">Skip to main content</a>
<a class="m-skip-to-main" href="#mainContent" tabindex="0">Skip to main content</a>
<div id="main">
<div class="loading">
<img
Expand Down