fix(react-theme): Swap Background1 and Foreground1 in HC color palette #24498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8abfe37:
|
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 9e7682f713135742648c4a6144bce5135048d990 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1302 | 1317 | 5000 | |
| Button | mount | 955 | 954 | 5000 | |
| FluentProvider | mount | 1601 | 1572 | 5000 | |
| FluentProviderWithTheme | mount | 640 | 633 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 595 | 600 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 628 | 633 | 10 | |
| MakeStyles | mount | 1917 | 1900 | 50000 | |
| SpinButton | mount | 2478 | 2549 | 5000 |
Member
|
Screener regressions for |
Member
Author
This was actually a problem with the stories, not the component itself. |
Member
Author
|
Another changed screenshot is BEFORE
AFTER
The change fixes |
spmonahan
reviewed
Aug 24, 2022
bsunderhus
approved these changes
Aug 29, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 1, 2022
* master: (99 commits) applying package updates add coastal to @fluentui/react package and components (microsoft#24599) fix(react-18-tests-v9): extend correct tsconfig.json (microsoft#24626) feat(react-18-tests-v9): Add cypress setup to enable writing cypress tests (microsoft#24619) chore: Removing CompoundButtonAsToggleButton story since it was importing non-exported functions (microsoft#24620) Update PeoplePicker focus styles for the close button - Add borderRadius to getFocusStyle (microsoft#24596) fix(react-theme): Rename colorNeutralForegroundInvertedStatic token to colorNeutralForegroundStaticInverted (microsoft#24611) Website fabric core (microsoft#24613) fix(react-theme) update react theme colors mapping (microsoft#24608) Remove downloaded artifact file after using it (microsoft#24606) Fix artifact downloading race condition (microsoft#24607) chore(deps): bump moment-timezone from 0.5.34 to 0.5.37 (microsoft#24604) Remove check for commit existence and make it optional (microsoft#24587) Update "screener-build.yml" to include lage's output (microsoft#24586) fix(react-theme): Change colorBrandForeground2 mapping in teamsDark theme (microsoft#24579) Add scoping for workflow (microsoft#24466) fix(react-theme): Swap Background1 and Foreground1 in HC color palette (microsoft#24498) applying package updates Add support for javascript date localization (microsoft#24577) fix: Combobox and Dropdown hover/active borders and padding style fixes (microsoft#24362) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
colorPalette*Background1was white in High ContrastcolorPalette*Foreground1was black in High ContrastcolorPalette*colors used hardcoded white and black instead of hcCanvas and hcCanvasText in High ContrastcolorPalette*Foreground1used Shade 10 for all Status shared colors in Light ThemeNew Behavior
colorPalette*Background1is hcCanvas (resolves to black in default windows HC theme) in High ContrastcolorPalette*Foreground1is hcCanvasText (resolves to white in default windows HC theme) in High ContrastcolorPalette*colors now use hcCanvas, hcCanvasTest or hcHighlight instead of white and black for all status and persona Color Palette colorscolorPaletteYellowForeground1uses Shade 30 in Light Theme, all other Status shared colors remained unchanged, using Shade 10Related Issue(s)
Fixes #24256