fix(react-theme): Rename colorNeutralForegroundInvertedStatic token to colorNeutralForegroundStaticInverted #24611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rNeutralForegroundStaticInverted
miroslavstastny
requested review from
a team,
behowell,
khmakoto,
sopranopillow and
tomi-msft
as code owners
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a286549:
|
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 21af8da1d98c070a682b26b7d56775d43a749b3d (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1320 | 1287 | 5000 | |
| Button | mount | 947 | 957 | 5000 | |
| FluentProvider | mount | 1581 | 1577 | 5000 | |
| FluentProviderWithTheme | mount | 636 | 638 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 593 | 592 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 623 | 632 | 10 | |
| MakeStyles | mount | 1816 | 1892 | 50000 | |
| SpinButton | mount | 2342 | 2419 | 5000 |
micahgodbolt
approved these changes
Aug 31, 2022
bsunderhus
approved these changes
Aug 31, 2022
spmonahan
approved these changes
Aug 31, 2022
| colorNeutralForegroundInvertedSelected: palette.white, | ||
| colorNeutralForegroundOnBrand: palette.white, | ||
| colorNeutralForegroundInvertedStatic: palette.white, | ||
| colorNeutralForegroundStaticInverted: palette.white, |
Contributor
There was a problem hiding this comment.
The reason I went with "inverted static" is because I felt it better aligned with our other usages of "inverted" which are all "inverted {modifier}". To me "static" feels like a modifier much like "pressed" or "hover".
I'm fine with changing it too :)
Member
Author
There was a problem hiding this comment.
Yeah, that makes sense. But the reason why it is StaticInverted is to point out that for this particular token, Static it is not a modifier of Inverted.
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 1, 2022
* master: (99 commits) applying package updates add coastal to @fluentui/react package and components (microsoft#24599) fix(react-18-tests-v9): extend correct tsconfig.json (microsoft#24626) feat(react-18-tests-v9): Add cypress setup to enable writing cypress tests (microsoft#24619) chore: Removing CompoundButtonAsToggleButton story since it was importing non-exported functions (microsoft#24620) Update PeoplePicker focus styles for the close button - Add borderRadius to getFocusStyle (microsoft#24596) fix(react-theme): Rename colorNeutralForegroundInvertedStatic token to colorNeutralForegroundStaticInverted (microsoft#24611) Website fabric core (microsoft#24613) fix(react-theme) update react theme colors mapping (microsoft#24608) Remove downloaded artifact file after using it (microsoft#24606) Fix artifact downloading race condition (microsoft#24607) chore(deps): bump moment-timezone from 0.5.34 to 0.5.37 (microsoft#24604) Remove check for commit existence and make it optional (microsoft#24587) Update "screener-build.yml" to include lage's output (microsoft#24586) fix(react-theme): Change colorBrandForeground2 mapping in teamsDark theme (microsoft#24579) Add scoping for workflow (microsoft#24466) fix(react-theme): Swap Background1 and Foreground1 in HC color palette (microsoft#24498) applying package updates Add support for javascript date localization (microsoft#24577) fix: Combobox and Dropdown hover/active borders and padding style fixes (microsoft#24362) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
Rename
colorNeutralForegroundInvertedStatictoken tocolorNeutralForegroundStaticInvertedin order to match design spec.NOT a breaking change
Theoretically this would be a breaking change, but since the token was added in #24027 no FUI version has been released.
cc @spmonahan