Update and add token values to improve accessibility #24027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 62b3a34:
|
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 5d985fac3569513a2808a9f3b93ad73907325e55 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1255 | 1278 | 5000 | |
| Button | mount | 972 | 973 | 5000 | |
| FluentProvider | mount | 1588 | 1565 | 5000 | |
| FluentProviderWithTheme | mount | 631 | 630 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 585 | 589 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 641 | 634 | 10 | |
| MakeStyles | mount | 1900 | 1938 | 50000 | |
| SpinButton | mount | 2487 | 2495 | 5000 |
spmonahan
force-pushed
the
fix/token-value-updates
branch
2 times, most recently
from
c5fe111 to
14db56b
Compare
|
Screener issues; [Dark theme] Ghost/subtle badge & [High Contrast] Ghost/subtle badgeSee my exploration and proposed solution to this issue. [Dark theme] Checked switch
|
6 tasks
Contributor
Author
|
@redongreen I had the wrong background colors for Switch but they are now updated. |
spmonahan
requested review from
a team,
behowell,
khmakoto,
sopranopillow and
tomi-msft
as code owners
|
@spmonahan to address issues with Spinner verify that we are using the following tokens;
One known issue is that we do not have an alias token to cover light and dark mode for the inverted track, we are using a global value white @ 20% alpha. Also, the spinner component is intended to be displayed over an overlay; therefore, the tool might fail to contrast test if no overlay is applied. @daisygeng for visibility! |
Updates the values of some neutral foreground and background tokens to achieve better color contrast to meet accessibility requirements.
Updates color tokens for Popover and adds a new Storybook story to make it easier to see the different Popover appearances.
Changed from `colorBrandBackground*` to `colorCompoundBrandBackground*`.
Updates color tokens for better contrast and accessibility. Simplifies some of the styling logic.
Adds a background wrapper to ensure inverted Spinners are consistently visible in all test cases.
spmonahan
force-pushed
the
fix/token-value-updates
branch
from
bcaaccb to
d3bc4b1
Compare
We want to avoid using foreground tokens for backgrounds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Current token values fail some accessibility tests.
New Behavior
New token values pass the failing accessibility tests.
Related Issue(s)
Fixes #24014