Skip to content

Conversation

@ralucapelin
Copy link
Contributor

Current Behavior

GHA workflows do not do anything for now since they are not triggered. In order to migrate to the workflows, testing is needed. The screener-run.yml workflow is triggered by the workflow_run event.

Workflows triggered by the workflow_run event will only run if they are present on the default branch, so in order to test it(PR #24466), the new version of screener-run.yml needs to be on the master branch.

New Behavior

screener-run.yml will be updated but it will not influence anything running on the master branch as it will not get to actually run.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8f60041:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Aug 26, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: dc35ea945b806d4d29750d9b3aa95aa55c4d9dd2 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1584 1581 5000
Button mount 1149 1129 5000
FluentProvider mount 1936 1919 5000
FluentProviderWithTheme mount 732 752 10
FluentProviderWithTheme virtual-rerender 716 716 10
FluentProviderWithTheme virtual-rerender-with-unmount 725 725 10
MakeStyles mount 2270 2149 50000
SpinButton mount 3120 2904 5000

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
533 B
341 B
global-context
createContextSelector
554 B
348 B
priority-overflow
createOverflowManager
2.936 kB
1.212 kB
react-accordion
Accordion (including children components)
79.349 kB
24.053 kB
react-alert
Alert
83.79 kB
20.841 kB
react-avatar
Avatar
48.283 kB
13.644 kB
react-avatar
AvatarGroup
14.85 kB
5.942 kB
react-avatar
AvatarGroupItem
68.251 kB
18.987 kB
react-badge
Badge
22.503 kB
7.153 kB
react-badge
CounterBadge
23.406 kB
7.449 kB
react-badge
PresenceBadge
23.947 kB
7.022 kB
react-button
Button
36.396 kB
9.579 kB
react-button
CompoundButton
43.469 kB
10.812 kB
react-button
MenuButton
39.014 kB
10.456 kB
react-button
SplitButton
46.544 kB
11.84 kB
react-button
ToggleButton
51.91 kB
11.003 kB
react-card
Card - All
67.458 kB
19.264 kB
react-card
Card
63.14 kB
18.176 kB
react-card
CardFooter
8.461 kB
3.555 kB
react-card
CardHeader
9.504 kB
3.896 kB
react-card
CardPreview
8.562 kB
3.61 kB
react-combobox
Combobox (including child components)
72.549 kB
23.686 kB
react-combobox
Dropdown (including child components)
71.741 kB
23.559 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
188.818 kB
51.901 kB
react-components
react-components: FluentProvider & webLightTheme
33.19 kB
10.921 kB
react-dialog
Dialog (including children components)
85.361 kB
25.458 kB
react-divider
Divider
16.359 kB
5.853 kB
react-image
Image
10.68 kB
4.215 kB
react-input
Input
23.498 kB
7.617 kB
react-label
Label
9.238 kB
3.815 kB
react-link
Link
12.231 kB
4.925 kB
react-menu
Menu (including children components)
115.697 kB
35.316 kB
react-menu
Menu (including selectable components)
118.896 kB
35.806 kB
react-overflow
hooks only
10.685 kB
4.104 kB
react-popover
Popover
102.837 kB
31.496 kB
react-portal
Portal
10.576 kB
3.875 kB
react-positioning
usePositioning
19.7 kB
7.404 kB
react-provider
FluentProvider
15.655 kB
5.835 kB
react-radio
Radio
36.025 kB
11.914 kB
react-radio
RadioGroup
14.148 kB
5.654 kB
react-select
Select
20.746 kB
7.299 kB
react-slider
Slider
32.07 kB
10.033 kB
react-spinbutton
SpinButton
43.843 kB
12.336 kB
react-spinner
Spinner
19.855 kB
6.384 kB
react-switch
Switch
32.562 kB
10.253 kB
react-text
Text - Default
11.682 kB
4.561 kB
react-text
Text - Wrappers
14.992 kB
4.995 kB
react-textarea
Textarea
23.674 kB
7.83 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
29.479 kB
6.396 kB
react-theme
Teams: Light theme
17.385 kB
5.024 kB
react-tooltip
Tooltip
41.504 kB
14.622 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against dc35ea945b806d4d29750d9b3aa95aa55c4d9dd2

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ToolbarMinimalPerf.default 977 907 1.08:1
HeaderMinimalPerf.default 382 356 1.07:1
TreeMinimalPerf.default 828 772 1.07:1
ImageMinimalPerf.default 388 365 1.06:1
VideoMinimalPerf.default 756 714 1.06:1
PortalMinimalPerf.default 173 164 1.05:1
AvatarMinimalPerf.default 186 179 1.04:1
ButtonMinimalPerf.default 168 162 1.04:1
LayoutMinimalPerf.default 353 339 1.04:1
ProviderMinimalPerf.default 408 393 1.04:1
RadioGroupMinimalPerf.default 436 418 1.04:1
TreeWith60ListItems.default 156 150 1.04:1
ItemLayoutMinimalPerf.default 1204 1168 1.03:1
LabelMinimalPerf.default 381 371 1.03:1
IconMinimalPerf.default 646 629 1.03:1
AnimationMinimalPerf.default 536 526 1.02:1
CarouselMinimalPerf.default 464 454 1.02:1
DropdownManyItemsPerf.default 680 664 1.02:1
EmbedMinimalPerf.default 4125 4063 1.02:1
ListNestedPerf.default 549 536 1.02:1
MenuMinimalPerf.default 832 816 1.02:1
PopupMinimalPerf.default 642 627 1.02:1
ChatMinimalPerf.default 717 710 1.01:1
DatepickerMinimalPerf.default 5851 5809 1.01:1
DialogMinimalPerf.default 781 775 1.01:1
DividerMinimalPerf.default 357 352 1.01:1
DropdownMinimalPerf.default 3125 3094 1.01:1
TableManyItemsPerf.default 1900 1890 1.01:1
TableMinimalPerf.default 392 387 1.01:1
TextMinimalPerf.default 345 340 1.01:1
BoxMinimalPerf.default 336 336 1:1
ButtonSlotsPerf.default 545 544 1:1
ChatDuplicateMessagesPerf.default 284 284 1:1
ChatWithPopoverPerf.default 368 367 1:1
CheckboxMinimalPerf.default 2667 2678 1:1
FlexMinimalPerf.default 283 282 1:1
InputMinimalPerf.default 1293 1297 1:1
ListCommonPerf.default 623 626 1:1
RefMinimalPerf.default 214 215 1:1
SliderMinimalPerf.default 1685 1680 1:1
TextAreaMinimalPerf.default 475 474 1:1
AttachmentMinimalPerf.default 142 144 0.99:1
ButtonOverridesMissPerf.default 1472 1494 0.99:1
GridMinimalPerf.default 333 335 0.99:1
HeaderSlotsPerf.default 754 759 0.99:1
RosterPerf.default 2148 2171 0.99:1
ProviderMergeThemesPerf.default 1264 1274 0.99:1
ReactionMinimalPerf.default 383 388 0.99:1
SkeletonMinimalPerf.default 334 337 0.99:1
SplitButtonMinimalPerf.default 4417 4444 0.99:1
CustomToolbarPrototype.default 2930 2954 0.99:1
AlertMinimalPerf.default 251 257 0.98:1
AttachmentSlotsPerf.default 1103 1122 0.98:1
CardMinimalPerf.default 513 522 0.98:1
MenuButtonMinimalPerf.default 1725 1762 0.98:1
StatusMinimalPerf.default 671 682 0.98:1
AccordionMinimalPerf.default 141 145 0.97:1
FormMinimalPerf.default 362 374 0.97:1
SegmentMinimalPerf.default 340 352 0.97:1
ListWith60ListItems.default 632 661 0.96:1
LoaderMinimalPerf.default 668 694 0.96:1
TooltipMinimalPerf.default 2323 2449 0.95:1
ListMinimalPerf.default 501 535 0.94:1

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 897 883 5000
Breadcrumb mount 2908 2906 1000
Checkbox mount 2654 2646 5000
CheckboxBase mount 2320 2343 5000
ChoiceGroup mount 4736 4743 5000
ComboBox mount 981 988 1000
CommandBar mount 10869 10847 1000
ContextualMenu mount 12665 12523 1000
DefaultButton mount 1127 1172 5000
DetailsRow mount 3851 4053 5000
DetailsRowFast mount 3842 3915 5000
DetailsRowNoStyles mount 3670 3717 5000
Dialog mount 3232 3216 1000
DocumentCardTitle mount 159 171 1000
Dropdown mount 3355 3356 5000
FocusTrapZone mount 1899 1912 5000
FocusZone mount 1856 1826 5000
IconButton mount 1790 1800 5000
Label mount 358 343 5000
Layer mount 4580 4550 5000
Link mount 455 473 5000
MenuButton mount 1497 1542 5000
MessageBar mount 2160 2202 5000
Nav mount 3373 3399 1000
OverflowSet mount 1104 1142 5000
Panel mount 2525 2524 1000
Persona mount 1018 996 1000
Pivot mount 1447 1443 1000
PrimaryButton mount 1315 1317 5000
Rating mount 7820 7819 5000
SearchBox mount 1325 1284 5000
Shimmer mount 2859 2834 5000
Slider mount 1972 2010 5000
SpinButton mount 5023 5039 5000
Spinner mount 444 443 5000
SplitButton mount 3280 3178 5000
Stack mount 524 518 5000
StackWithIntrinsicChildren mount 2295 2298 5000
StackWithTextChildren mount 5243 5256 5000
SwatchColorPicker mount 11976 11992 5000
TagPicker mount 2687 2623 5000
TeachingBubble mount 98414 99774 5000
Text mount 454 427 5000
TextField mount 1391 1447 5000
ThemeProvider mount 1313 1298 5000
ThemeProvider virtual-rerender 799 782 5000
ThemeProvider virtual-rerender-with-unmount 2092 2068 5000
Toggle mount 803 864 5000
buttonNative mount 134 144 5000

@ralucapelin ralucapelin marked this pull request as ready for review August 26, 2022 12:42
@ralucapelin ralucapelin requested a review from a team as a code owner August 26, 2022 12:43
@layershifter
Copy link
Member

layershifter commented Aug 26, 2022

Force merging to unblock @ralucapelin. This workflow does not run anyway currently. @microsoft/fluentui-react-build feel free to leave comments and we will address them if there will be any.

@layershifter layershifter merged commit d60ab2a into master Aug 26, 2022
@layershifter layershifter deleted the update-screener-workflow branch August 26, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants