-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Update screener-run.yml workflow #24541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8f60041:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: dc35ea945b806d4d29750d9b3aa95aa55c4d9dd2 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1584 | 1581 | 5000 | |
| Button | mount | 1149 | 1129 | 5000 | |
| FluentProvider | mount | 1936 | 1919 | 5000 | |
| FluentProviderWithTheme | mount | 732 | 752 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 716 | 716 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 725 | 725 | 10 | |
| MakeStyles | mount | 2270 | 2149 | 50000 | |
| SpinButton | mount | 3120 | 2904 | 5000 |
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ToolbarMinimalPerf.default | 977 | 907 | 1.08:1 |
| HeaderMinimalPerf.default | 382 | 356 | 1.07:1 |
| TreeMinimalPerf.default | 828 | 772 | 1.07:1 |
| ImageMinimalPerf.default | 388 | 365 | 1.06:1 |
| VideoMinimalPerf.default | 756 | 714 | 1.06:1 |
| PortalMinimalPerf.default | 173 | 164 | 1.05:1 |
| AvatarMinimalPerf.default | 186 | 179 | 1.04:1 |
| ButtonMinimalPerf.default | 168 | 162 | 1.04:1 |
| LayoutMinimalPerf.default | 353 | 339 | 1.04:1 |
| ProviderMinimalPerf.default | 408 | 393 | 1.04:1 |
| RadioGroupMinimalPerf.default | 436 | 418 | 1.04:1 |
| TreeWith60ListItems.default | 156 | 150 | 1.04:1 |
| ItemLayoutMinimalPerf.default | 1204 | 1168 | 1.03:1 |
| LabelMinimalPerf.default | 381 | 371 | 1.03:1 |
| IconMinimalPerf.default | 646 | 629 | 1.03:1 |
| AnimationMinimalPerf.default | 536 | 526 | 1.02:1 |
| CarouselMinimalPerf.default | 464 | 454 | 1.02:1 |
| DropdownManyItemsPerf.default | 680 | 664 | 1.02:1 |
| EmbedMinimalPerf.default | 4125 | 4063 | 1.02:1 |
| ListNestedPerf.default | 549 | 536 | 1.02:1 |
| MenuMinimalPerf.default | 832 | 816 | 1.02:1 |
| PopupMinimalPerf.default | 642 | 627 | 1.02:1 |
| ChatMinimalPerf.default | 717 | 710 | 1.01:1 |
| DatepickerMinimalPerf.default | 5851 | 5809 | 1.01:1 |
| DialogMinimalPerf.default | 781 | 775 | 1.01:1 |
| DividerMinimalPerf.default | 357 | 352 | 1.01:1 |
| DropdownMinimalPerf.default | 3125 | 3094 | 1.01:1 |
| TableManyItemsPerf.default | 1900 | 1890 | 1.01:1 |
| TableMinimalPerf.default | 392 | 387 | 1.01:1 |
| TextMinimalPerf.default | 345 | 340 | 1.01:1 |
| BoxMinimalPerf.default | 336 | 336 | 1:1 |
| ButtonSlotsPerf.default | 545 | 544 | 1:1 |
| ChatDuplicateMessagesPerf.default | 284 | 284 | 1:1 |
| ChatWithPopoverPerf.default | 368 | 367 | 1:1 |
| CheckboxMinimalPerf.default | 2667 | 2678 | 1:1 |
| FlexMinimalPerf.default | 283 | 282 | 1:1 |
| InputMinimalPerf.default | 1293 | 1297 | 1:1 |
| ListCommonPerf.default | 623 | 626 | 1:1 |
| RefMinimalPerf.default | 214 | 215 | 1:1 |
| SliderMinimalPerf.default | 1685 | 1680 | 1:1 |
| TextAreaMinimalPerf.default | 475 | 474 | 1:1 |
| AttachmentMinimalPerf.default | 142 | 144 | 0.99:1 |
| ButtonOverridesMissPerf.default | 1472 | 1494 | 0.99:1 |
| GridMinimalPerf.default | 333 | 335 | 0.99:1 |
| HeaderSlotsPerf.default | 754 | 759 | 0.99:1 |
| RosterPerf.default | 2148 | 2171 | 0.99:1 |
| ProviderMergeThemesPerf.default | 1264 | 1274 | 0.99:1 |
| ReactionMinimalPerf.default | 383 | 388 | 0.99:1 |
| SkeletonMinimalPerf.default | 334 | 337 | 0.99:1 |
| SplitButtonMinimalPerf.default | 4417 | 4444 | 0.99:1 |
| CustomToolbarPrototype.default | 2930 | 2954 | 0.99:1 |
| AlertMinimalPerf.default | 251 | 257 | 0.98:1 |
| AttachmentSlotsPerf.default | 1103 | 1122 | 0.98:1 |
| CardMinimalPerf.default | 513 | 522 | 0.98:1 |
| MenuButtonMinimalPerf.default | 1725 | 1762 | 0.98:1 |
| StatusMinimalPerf.default | 671 | 682 | 0.98:1 |
| AccordionMinimalPerf.default | 141 | 145 | 0.97:1 |
| FormMinimalPerf.default | 362 | 374 | 0.97:1 |
| SegmentMinimalPerf.default | 340 | 352 | 0.97:1 |
| ListWith60ListItems.default | 632 | 661 | 0.96:1 |
| LoaderMinimalPerf.default | 668 | 694 | 0.96:1 |
| TooltipMinimalPerf.default | 2323 | 2449 | 0.95:1 |
| ListMinimalPerf.default | 501 | 535 | 0.94:1 |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 897 | 883 | 5000 | |
| Breadcrumb | mount | 2908 | 2906 | 1000 | |
| Checkbox | mount | 2654 | 2646 | 5000 | |
| CheckboxBase | mount | 2320 | 2343 | 5000 | |
| ChoiceGroup | mount | 4736 | 4743 | 5000 | |
| ComboBox | mount | 981 | 988 | 1000 | |
| CommandBar | mount | 10869 | 10847 | 1000 | |
| ContextualMenu | mount | 12665 | 12523 | 1000 | |
| DefaultButton | mount | 1127 | 1172 | 5000 | |
| DetailsRow | mount | 3851 | 4053 | 5000 | |
| DetailsRowFast | mount | 3842 | 3915 | 5000 | |
| DetailsRowNoStyles | mount | 3670 | 3717 | 5000 | |
| Dialog | mount | 3232 | 3216 | 1000 | |
| DocumentCardTitle | mount | 159 | 171 | 1000 | |
| Dropdown | mount | 3355 | 3356 | 5000 | |
| FocusTrapZone | mount | 1899 | 1912 | 5000 | |
| FocusZone | mount | 1856 | 1826 | 5000 | |
| IconButton | mount | 1790 | 1800 | 5000 | |
| Label | mount | 358 | 343 | 5000 | |
| Layer | mount | 4580 | 4550 | 5000 | |
| Link | mount | 455 | 473 | 5000 | |
| MenuButton | mount | 1497 | 1542 | 5000 | |
| MessageBar | mount | 2160 | 2202 | 5000 | |
| Nav | mount | 3373 | 3399 | 1000 | |
| OverflowSet | mount | 1104 | 1142 | 5000 | |
| Panel | mount | 2525 | 2524 | 1000 | |
| Persona | mount | 1018 | 996 | 1000 | |
| Pivot | mount | 1447 | 1443 | 1000 | |
| PrimaryButton | mount | 1315 | 1317 | 5000 | |
| Rating | mount | 7820 | 7819 | 5000 | |
| SearchBox | mount | 1325 | 1284 | 5000 | |
| Shimmer | mount | 2859 | 2834 | 5000 | |
| Slider | mount | 1972 | 2010 | 5000 | |
| SpinButton | mount | 5023 | 5039 | 5000 | |
| Spinner | mount | 444 | 443 | 5000 | |
| SplitButton | mount | 3280 | 3178 | 5000 | |
| Stack | mount | 524 | 518 | 5000 | |
| StackWithIntrinsicChildren | mount | 2295 | 2298 | 5000 | |
| StackWithTextChildren | mount | 5243 | 5256 | 5000 | |
| SwatchColorPicker | mount | 11976 | 11992 | 5000 | |
| TagPicker | mount | 2687 | 2623 | 5000 | |
| TeachingBubble | mount | 98414 | 99774 | 5000 | |
| Text | mount | 454 | 427 | 5000 | |
| TextField | mount | 1391 | 1447 | 5000 | |
| ThemeProvider | mount | 1313 | 1298 | 5000 | |
| ThemeProvider | virtual-rerender | 799 | 782 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2092 | 2068 | 5000 | |
| Toggle | mount | 803 | 864 | 5000 | |
| buttonNative | mount | 134 | 144 | 5000 |
|
Force merging to unblock @ralucapelin. This workflow does not run anyway currently. @microsoft/fluentui-react-build feel free to leave comments and we will address them if there will be any. |
Current Behavior
GHA workflows do not do anything for now since they are not triggered. In order to migrate to the workflows, testing is needed. The
screener-run.ymlworkflow is triggered by theworkflow_runevent.Workflows triggered by the
workflow_runevent will only run if they are present on the default branch, so in order to test it(PR #24466), the new version ofscreener-run.ymlneeds to be on the master branch.New Behavior
screener-run.ymlwill be updated but it will not influence anything running on the master branch as it will not get to actually run.