test(react-draggable-dialog): add a lot more test cases for better coverage #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…matic-dnd * main: (211 commits) fix(docsite): add missing dependency for extract-storybook-llms target (microsoft#486) feat(react-19-tests): bootstrap react 19 integration tests (microsoft#468) feat(docsite): generate llms.txt (microsoft#476) docs(react-virtualizer): Update virtualizer stories to use the same storybook Meta format as contrib repo (microsoft#474) chore: bump react-components to latest and adjust types to support React 18 (microsoft#387) chore(deps-dev): bump @swc/core from 1.11.24 to 1.13.3 (microsoft#463) chore(deps-dev): bump patch-package from 7.0.0 to 7.0.2 (microsoft#465) chore(deps-dev): bump @swc/cli from 0.7.7 to 0.7.8 (microsoft#467) chore: migrate to nx 21.3.10 (microsoft#453) ci(dependabot): ignore major bumps (microsoft#461) chore(deps-dev): bump eslint-config-prettier from 10.1.5 to 10.1.8 (microsoft#460) chore(deps-dev): bump react-virtualized-auto-sizer and @types/react-virtualized-auto-sizer (microsoft#454) chore(deps): bump nrwl/nx-set-shas from 4.3.0 to 4.3.3 (microsoft#456) applying package updates feat(react-virtualizer): initial/stable release (microsoft#452) docs(gh): add issue templates (microsoft#442) feat(react-virtualizer): migrate package from fluentui core repo (microsoft#441) feat(react-gamepad-navigation): adding unit tests (microsoft#443) fix(react-gamepad-navigation): handling Gamepad API access denied (microsoft#416) fix(react-keytips): remove default event prevention in useHotkeys (microsoft#430) ...
…tion upgrade on Dialog
…ce-after-motion-upgrade * main: feat: enforce module boundary types (microsoft#487) feat: migrate repo to react-components 9.70.0 and resolve initial type issues with react 19 (microsoft#478)
…ce-after-motion-upgrade
…ce-after-motion-upgrade
…tion-upgrade' into test/react-draggable-dialog/add-more-complete-test-cases * fix/react-draggable-dialog/improve-performance-after-motion-upgrade: (32 commits) fix: update swc config for tests fix: remove eslint comment fix: formatting fix: upgrade dnd-kit fix: revert changes to yarn.lock applying package updates fix(houdini-utils): Give wrapper element a different id (microsoft#520) applying package updates fix(react-virtualizer): add missing react-jsx-runtime dependency (microsoft#518) applying package updates fix(houdini-utils): make DOM access to utils safe (microsoft#514) fix (react-virtualizer): Ensure IO buffer gets removed, not added from calculation (microsoft#516) fix (react-virtualizer): Ensure base virtualizer hook recalcs array if numItems change at end (microsoft#515) chore: update peer dependencies for React and @types/react to support versions v19 (microsoft#494) applying package updates fix (react-virtualizer): Ensure accurate positioning for dynamically changing sizes (microsoft#511) chore: upgrade form-data and axios to fix security vulnerabilities (microsoft#509) applying package updates feat (react-virtualizer): Enable complex dynamic virtualization with add and remove items (microsoft#508) chore: add cxe-prg to react-virtualizer codeowners (microsoft#510) ...
…e-test-cases * main: fix(react-draggable-dialog): improve calculation performance after motion upgrade on Dialog (microsoft#493)
dmytrokirpa
approved these changes
Oct 21, 2025
...react-draggable-dialog/src/components/DraggableDialog/utils/getParsedDraggableMargin.test.ts
Outdated
Show resolved
Hide resolved
...t-draggable-dialog/src/components/DraggableDialog/DraggableDialog.component-browser-spec.tsx
Outdated
Show resolved
Hide resolved
marcosmoura
deleted the
test/react-draggable-dialog/add-more-complete-test-cases
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bunch of new tests to improve the coverage of the React Draggable Dialog.