fix(houdini-utils): Give wrapper element a different id #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spmonahan
approved these changes
Oct 3, 2025
layershifter
approved these changes
Oct 6, 2025
Member
|
@spmonahan @CampbellOwen thx, I merged the PR. Please trigger a release ;) |
marcosmoura
added a commit
to marcosmoura/fluentui-contrib
that referenced
this pull request
Oct 15, 2025
…tion-upgrade' into test/react-draggable-dialog/add-more-complete-test-cases * fix/react-draggable-dialog/improve-performance-after-motion-upgrade: (32 commits) fix: update swc config for tests fix: remove eslint comment fix: formatting fix: upgrade dnd-kit fix: revert changes to yarn.lock applying package updates fix(houdini-utils): Give wrapper element a different id (microsoft#520) applying package updates fix(react-virtualizer): add missing react-jsx-runtime dependency (microsoft#518) applying package updates fix(houdini-utils): make DOM access to utils safe (microsoft#514) fix (react-virtualizer): Ensure IO buffer gets removed, not added from calculation (microsoft#516) fix (react-virtualizer): Ensure base virtualizer hook recalcs array if numItems change at end (microsoft#515) chore: update peer dependencies for React and @types/react to support versions v19 (microsoft#494) applying package updates fix (react-virtualizer): Ensure accurate positioning for dynamically changing sizes (microsoft#511) chore: upgrade form-data and axios to fix security vulnerabilities (microsoft#509) applying package updates feat (react-virtualizer): Enable complex dynamic virtualization with add and remove items (microsoft#508) chore: add cxe-prg to react-virtualizer codeowners (microsoft#510) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #514 the creation of the wrapper element for the fallback canvas was given the same id as the canvas element itself. This means that when the id is used to reference the canvas to display the fallback paint animation it is blank instead.
This change gives the wrapper a stable
houdini-fallback-wrapper-<x>id