feat(react-virtualizer): migrate package from fluentui core repo #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
reviewed
Jul 24, 2025
| @@ -0,0 +1,24 @@ | |||
| { | |||
| "name": "@fluentui-contrib/react-virtualizer", | |||
| "version": "0.0.1", | |||
Contributor
There was a problem hiding this comment.
lets start with "private": true and make public once ready for release
Contributor
|
pipeline is failing on formatting issues, it seems we have different prettier setup in comparison with core repo. please run |
Hotell
changed the title
Contributor
|
just to confirm, it seems you used our generators to bootstrap a new package right ? nit: our recommended flow is to bootstrap empty package 1st / add content as follow up PR -> https://github.com/microsoft/fluentui-contrib/blob/main/CONTRIBUTING.md#creating-a-new-package |
Hotell
approved these changes
Jul 24, 2025
Contributor
Hotell
left a comment
Hotell
left a comment
There was a problem hiding this comment.
in general LGTM, needs pipeline fixes
marcosmoura
added a commit
to marcosmoura/fluentui-contrib
that referenced
this pull request
Sep 8, 2025
…matic-dnd * main: (211 commits) fix(docsite): add missing dependency for extract-storybook-llms target (microsoft#486) feat(react-19-tests): bootstrap react 19 integration tests (microsoft#468) feat(docsite): generate llms.txt (microsoft#476) docs(react-virtualizer): Update virtualizer stories to use the same storybook Meta format as contrib repo (microsoft#474) chore: bump react-components to latest and adjust types to support React 18 (microsoft#387) chore(deps-dev): bump @swc/core from 1.11.24 to 1.13.3 (microsoft#463) chore(deps-dev): bump patch-package from 7.0.0 to 7.0.2 (microsoft#465) chore(deps-dev): bump @swc/cli from 0.7.7 to 0.7.8 (microsoft#467) chore: migrate to nx 21.3.10 (microsoft#453) ci(dependabot): ignore major bumps (microsoft#461) chore(deps-dev): bump eslint-config-prettier from 10.1.5 to 10.1.8 (microsoft#460) chore(deps-dev): bump react-virtualized-auto-sizer and @types/react-virtualized-auto-sizer (microsoft#454) chore(deps): bump nrwl/nx-set-shas from 4.3.0 to 4.3.3 (microsoft#456) applying package updates feat(react-virtualizer): initial/stable release (microsoft#452) docs(gh): add issue templates (microsoft#442) feat(react-virtualizer): migrate package from fluentui core repo (microsoft#441) feat(react-gamepad-navigation): adding unit tests (microsoft#443) fix(react-gamepad-navigation): handling Gamepad API access denied (microsoft#416) fix(react-keytips): remove default event prevention in useHotkeys (microsoft#430) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request migrates the library,
react-virtualizerfrom FluentUI core.React-virtualizer provides virtualization using
IntersectionObserver. The changes include adding the library to the codebase, setting up its configuration files, defining its build and test processes, and exporting its core components and utilities to match Fluentui-contrib's repo architecture.Addition of the
react-virtualizerlibrary:Library Initialization:
react-virtualizerto the.github/CODEOWNERSfile for ownership tracking.README.mdfile explaining the purpose, benefits, and usage of thereact-virtualizerlibrary.package.jsonfile specifying dependencies, peer dependencies, and metadata for the library.Configuration Files:
.babelrc,.swcrc, andtsconfig.jsonfiles for build and compilation configurations. [1] [2] [3]jest.config.tsfile for unit testing using Jest and SWC.Storybook Integration:
main.tsandpreview.tsxfiles. [1] [2]Core functionality and exports:
Hooks and Utilities:
useDynamicVirtualizerMeasureand utilities likescrollToItemDynamicfor implementing virtualization features. [1] [2]Components:
VirtualizerandVirtualizerScrollViewalong with their types, styles, and utilities. [1] [2]Project Configuration:
project.jsonfile defining build, lint, test, and Storybook tasks for the library.