feat(react-19-tests): bootstrap react 19 integration tests #468
Conversation
dmytrokirpa
force-pushed
the
tests/react-19-integration
branch
from
d5cf345 to
de20fbb
Compare
| "preinstall": "node ./tools/scripts/preinstall.mjs", | ||
| "postinstall": "patch-package", | ||
| "dedupe": "npx yarn-deduplicate --strategy highest" | ||
| "dedupe": "npx yarn-deduplicate --strategy highest --exclude @types/react-dom @types/react" |
There was a problem hiding this comment.
Running npx yarn-deduplicate --strategy highest leads to this: https://github.com/microsoft/fluentui-contrib/pull/468/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2deR6127-R6130.
This forces @types/[email protected] everywhere, causing pipeline failures. So far, adding excludes is the only workaround I've found. Open to better ideas.
There was a problem hiding this comment.
yeah, either detective work and trying resolutions on sub paths ( which might not work with current yarn ) or this. it's ok for now / once react integration tester CLI will land we will replace current approach which will also not cause this kind of issues
There was a problem hiding this comment.
note that excluding @types/react should be enough
There was a problem hiding this comment.
Unfortunately that doesn't work, removing @types/react-dom leads to:
…matic-dnd * main: (211 commits) fix(docsite): add missing dependency for extract-storybook-llms target (microsoft#486) feat(react-19-tests): bootstrap react 19 integration tests (microsoft#468) feat(docsite): generate llms.txt (microsoft#476) docs(react-virtualizer): Update virtualizer stories to use the same storybook Meta format as contrib repo (microsoft#474) chore: bump react-components to latest and adjust types to support React 18 (microsoft#387) chore(deps-dev): bump @swc/core from 1.11.24 to 1.13.3 (microsoft#463) chore(deps-dev): bump patch-package from 7.0.0 to 7.0.2 (microsoft#465) chore(deps-dev): bump @swc/cli from 0.7.7 to 0.7.8 (microsoft#467) chore: migrate to nx 21.3.10 (microsoft#453) ci(dependabot): ignore major bumps (microsoft#461) chore(deps-dev): bump eslint-config-prettier from 10.1.5 to 10.1.8 (microsoft#460) chore(deps-dev): bump react-virtualized-auto-sizer and @types/react-virtualized-auto-sizer (microsoft#454) chore(deps): bump nrwl/nx-set-shas from 4.3.0 to 4.3.3 (microsoft#456) applying package updates feat(react-virtualizer): initial/stable release (microsoft#452) docs(gh): add issue templates (microsoft#442) feat(react-virtualizer): migrate package from fluentui core repo (microsoft#441) feat(react-gamepad-navigation): adding unit tests (microsoft#443) fix(react-gamepad-navigation): handling Gamepad API access denied (microsoft#416) fix(react-keytips): remove default event prevention in useHotkeys (microsoft#430) ...
2 participants
see PR title