-
Notifications
You must be signed in to change notification settings - Fork 50
feat: add react 19 support #478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c9fa1a to
8b93a46
Compare
hectorjjb
approved these changes
Sep 8, 2025
Collaborator
hectorjjb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as "react-gamepad-navigation" package is concerned. These changes are ok
Hotell
approved these changes
Sep 9, 2025
| Virtualizer, | ||
| useStaticVirtualizerMeasure, | ||
| } from '@fluentui/react-virtualizer'; | ||
| } from '@fluentui-contrib/react-virtualizer'; |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch
layershifter
approved these changes
Sep 9, 2025
marcosmoura
added a commit
to marcosmoura/fluentui-contrib
that referenced
this pull request
Sep 9, 2025
…ce-after-motion-upgrade * main: feat: enforce module boundary types (microsoft#487) feat: migrate repo to react-components 9.70.0 and resolve initial type issues with react 19 (microsoft#478)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fluentui/react-componentsdependency to v9.70.0 (which contains React 19 support)JSX.ElementwithJSXElementfrom@fluentui/react-components)