fix(react-draggable-dialog): improve calculation performance after motion upgrade on Dialog #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…matic-dnd * main: (211 commits) fix(docsite): add missing dependency for extract-storybook-llms target (microsoft#486) feat(react-19-tests): bootstrap react 19 integration tests (microsoft#468) feat(docsite): generate llms.txt (microsoft#476) docs(react-virtualizer): Update virtualizer stories to use the same storybook Meta format as contrib repo (microsoft#474) chore: bump react-components to latest and adjust types to support React 18 (microsoft#387) chore(deps-dev): bump @swc/core from 1.11.24 to 1.13.3 (microsoft#463) chore(deps-dev): bump patch-package from 7.0.0 to 7.0.2 (microsoft#465) chore(deps-dev): bump @swc/cli from 0.7.7 to 0.7.8 (microsoft#467) chore: migrate to nx 21.3.10 (microsoft#453) ci(dependabot): ignore major bumps (microsoft#461) chore(deps-dev): bump eslint-config-prettier from 10.1.5 to 10.1.8 (microsoft#460) chore(deps-dev): bump react-virtualized-auto-sizer and @types/react-virtualized-auto-sizer (microsoft#454) chore(deps): bump nrwl/nx-set-shas from 4.3.0 to 4.3.3 (microsoft#456) applying package updates feat(react-virtualizer): initial/stable release (microsoft#452) docs(gh): add issue templates (microsoft#442) feat(react-virtualizer): migrate package from fluentui core repo (microsoft#441) feat(react-gamepad-navigation): adding unit tests (microsoft#443) fix(react-gamepad-navigation): handling Gamepad API access denied (microsoft#416) fix(react-keytips): remove default event prevention in useHotkeys (microsoft#430) ...
…tion upgrade on Dialog
marcosmoura
added
the
react-draggable-dialog
…ce-after-motion-upgrade * main: feat: enforce module boundary types (microsoft#487) feat: migrate repo to react-components 9.70.0 and resolve initial type issues with react 19 (microsoft#478)
marcosmoura
commented
Sep 9, 2025
packages/react-draggable-dialog/src/components/DraggableDialog/DraggableDialog.test.tsx
Show resolved
Hide resolved
marcosmoura
commented
Sep 9, 2025
packages/react-draggable-dialog/src/components/DraggableDialog/useDraggableDialog.ts
Show resolved
Hide resolved
marcosmoura
commented
Sep 9, 2025
...es/react-draggable-dialog/src/components/DraggableDialogSurface/useDraggableDialogSurface.ts
Show resolved
Hide resolved
marcosmoura
commented
Sep 9, 2025
marcosmoura
commented
Sep 9, 2025
marcosmoura
commented
Sep 9, 2025
dmytrokirpa
reviewed
Sep 10, 2025
...ages/react-draggable-dialog/src/components/DraggableDialogSurface/DraggableDialogSurface.tsx
Outdated
Show resolved
Hide resolved
packages/react-draggable-dialog/src/components/DraggableDialogHandle/DraggableDialogHandle.tsx
Outdated
Show resolved
Hide resolved
...ages/react-draggable-dialog/src/components/DraggableDialogSurface/DraggableDialogSurface.tsx
Outdated
Show resolved
Hide resolved
…ce-after-motion-upgrade
2 tasks
dmytrokirpa
reviewed
Oct 1, 2025
dmytrokirpa
reviewed
Oct 1, 2025
dmytrokirpa
approved these changes
Oct 14, 2025
marcosmoura
deleted the
fix/react-draggable-dialog/improve-performance-after-motion-upgrade
branch
marcosmoura
added a commit
to marcosmoura/fluentui-contrib
that referenced
this pull request
Oct 15, 2025
…e-test-cases * main: fix(react-draggable-dialog): improve calculation performance after motion upgrade on Dialog (microsoft#493)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dialog component, that is used under the hood by the DraggableDialog, was upgraded to use Motion Preview APIs, and that was making the component to misbehave.
This PR adds a bunch of performance optimizations as well, to better calculate the position of the DraggableDialog after the Motion upgrade.