Skip to content

Conversation

@Mitch-At-Work
Copy link
Contributor

Removed a lot of code pertaining to 'optimizations' that were requiring additional work to prevent
Focused on optimizing the flow/layout and always rendering based on the virtualizer parameters passed in
Updated complex story example to showcase add/remove items with optimized mounting/unmounting

Due to the nature of virtualization, it's much safer for us to focus on preventing mounts/unmounts over additional renders - this enables teams to focus on the async lifestyle of a component vs trying to prevent as many renders as possible (which often results in unmounting/remounting).

@Mitch-At-Work Mitch-At-Work requested a review from a team as a code owner September 23, 2025 23:30
@Mitch-At-Work Mitch-At-Work marked this pull request as draft September 24, 2025 00:53
@dmytrokirpa dmytrokirpa self-requested a review September 24, 2025 17:00
@Mitch-At-Work Mitch-At-Work marked this pull request as ready for review September 24, 2025 21:45
@Mitch-At-Work Mitch-At-Work requested a review from a team as a code owner September 24, 2025 21:45
@dmytrokirpa dmytrokirpa merged commit 5b26c48 into main Sep 25, 2025
9 checks passed
@dmytrokirpa dmytrokirpa deleted the user/mifraser/enable-complex-numItems-change branch September 25, 2025 17:16
marcosmoura added a commit to marcosmoura/fluentui-contrib that referenced this pull request Oct 15, 2025
…tion-upgrade' into test/react-draggable-dialog/add-more-complete-test-cases

* fix/react-draggable-dialog/improve-performance-after-motion-upgrade: (32 commits)
  fix: update swc config for tests
  fix: remove eslint comment
  fix: formatting
  fix: upgrade dnd-kit
  fix: revert changes to yarn.lock
  applying package updates
  fix(houdini-utils): Give wrapper element a different id  (microsoft#520)
  applying package updates
  fix(react-virtualizer): add missing react-jsx-runtime dependency (microsoft#518)
  applying package updates
  fix(houdini-utils): make DOM access to utils safe (microsoft#514)
  fix (react-virtualizer): Ensure IO buffer gets removed, not added from calculation (microsoft#516)
  fix (react-virtualizer): Ensure base virtualizer hook recalcs array if numItems change at end (microsoft#515)
  chore: update peer dependencies for React and @types/react to support versions v19 (microsoft#494)
  applying package updates
  fix (react-virtualizer): Ensure accurate positioning for dynamically changing sizes (microsoft#511)
  chore: upgrade form-data and axios to fix security vulnerabilities (microsoft#509)
  applying package updates
  feat (react-virtualizer): Enable complex dynamic virtualization with add and remove items (microsoft#508)
  chore: add cxe-prg to react-virtualizer codeowners (microsoft#510)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants