Skip to content

cmux-next chief inspector: latency bars use the theme accent, not orange (layout pass) - #22839

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
cmux/layout-pass-inspector
Oct 21, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
cmux/layout-pass-inspector

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Layout pass: running list

Running list of defects from the layout pass. ✅ = this PR, ✔ = merged. The full list is in HQ knowledge/layout-pass.md (cmuxterm-hq#2696).

Summary

The Timeline's "Took" bars drew in --view, a mix of the theme's warning and danger colors, so a plain duration read as an alarm in orange. It is a single series, so it now uses the theme accent (--accent, the page's --cmux-app-accent-text). The context segments and legend dots keep their status colors.

Screenshots

Before After
Dark
Light

Testing

  • oxfmt --check passes on the changed file, and prepush-gate.py reports no new violations.
  • I did not run the full bun run check. In my sparse worktree it lints the symlinked node_modules. CI runs it.

Observed / Not run

  • Observed: Linux gallery captures at 760px, light and dark, before and after.
  • Not run: the Mac app. This is a CSS-only change.

Changelog

  • Changed: the Chief memory inspector's latency bars use the theme accent.

🤖 Generated with Claude Code

Agent session: huge-blue

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 9b8131b: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr22839 -f ref=cmux/layout-pass-inspector -f platform=macos -f backend_mode=local

Unclear: web / react-apps-check (4) failed: no known signature; failed step: Build the web bundles. This PR merged before its CI finished: fix forward on main.

CI failed on 9b8131b787 (run 39536301017 attempt 1): 5 unknown.

Job Verdict Why
web / react-apps-check (4) unknown no known signature; failed step: Build the web bundles
web / react-apps-check (2) unknown no known signature; failed step: Build the web bundles
web / react-apps-check (1) unknown no known signature; failed step: Build the web bundles
web / react-apps-check (3) unknown no known signature; failed step: Build the web bundles
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Not re-run automatically: web / react-apps-check (4), web / react-apps-check (2), web / react-apps-check (1), web / react-apps-check (3), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: web / Web status; no finished base run on d581004 to compare; do not merge until green; see lane-rules
red: web / react-apps-check; base red: the same failure on the base d581004; does not block
red: web / react-apps-check (1); NEW: step Build the web bundles passes on the base d581004; do not merge until green; see lane-rules
red: web / react-apps-check (2); NEW: step Build the web bundles passes on the base d581004; do not merge until green; see lane-rules
red: web / react-apps-check (3); NEW: step Build the web bundles passes on the base d581004; do not merge until green; see lane-rules
red: web / react-apps-check (4); NEW: green on the base d581004; do not merge until green; see lane-rules

Tour of 9b8131b787 (run): no media. The tour did not run: only webview code changed (1 path(s)), which the gallery advisory run checks in Linux Chromium on the pull request (its artifact holds any captures); add the media-tour-mac label to tour it on a Mac.

@blacksmith-sh

blacksmith-sh Bot commented Oct 21, 2026

Copy link
Copy Markdown

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)/
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo
teamleaderleo merged commit 50ec56c into feat-cmux-next Oct 21, 2026
@teamleaderleo
teamleaderleo deleted the cmux/layout-pass-inspector branch October 21, 2026 03:11
teamleaderleo added a commit that referenced this pull request Oct 21, 2026
…ge (#22913)

* ci(next): base and PR autofix rebuild a stale Chief memory inspector page

#22839 changed webviews/src/optchat-inspector/styles.css without rebuilding
the committed Native/OptChat/optchat-chief/inspector/index.html. Every
webviews bundle build then failed (react-apps-check "Build the web bundles",
the base autofix's action exports (Mac) and, behind it, defaults-snapshot)
until someone regenerated the page by hand (#22877).

The read-only webviews vp fmt job in both autofix workflows now also runs
build-optchat-inspector-web.sh and puts that one page in its patch, and
base-autofix.sh applies it (any other path outside webviews/ is still
refused). A stale page now heals on the next base push or PR autofix run.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue

* ci(next): only the base autofix rebuilds the inspector page, best effort

Review of #22913: PR autofix's push job applies its patch with
pr-autofix-apply.sh, which refuses any path that isn't an autofix output, so
a rebuilt page there would have cost a PR every repair. The base autofix
heals the page after each merge, so PR autofix goes back to vp fmt only.
A failed rebuild now warns and keeps the committed page instead of failing
the job and losing the formatting repairs; the log's diff summary names the
page.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo pushed a commit that referenced this pull request Oct 21, 2026
…(base red) (#22877)

#22839 changed webviews/src/optchat-inspector/styles.css without rebuilding
Native/OptChat/optchat-chief/inspector/index.html, so every fleet dev build
of feat-cmux-next fails its generated-file check (generated_stale, fleet job
5f13a8b2). Built with scripts/cmux-next/build-optchat-inspector-web.sh on a
Freestyle webviews VM; --check passes there.
teamleaderleo added a commit that referenced this pull request Oct 21, 2026
…e composer they test (#22989)

Both tests landed red: the webviews browser tests were skipped on every PR while the Chief
inspector page was stale (#22839 to #22877), so neither ran before merging.

- agent-pane-trust-ask-corner (#22860): the card's top corners square off under a queue or strip
  on it by design, so the bar is now compared with the card's own (bottom) corner, which is the
  token both read. Send comes in with a draft's first letter (Claude desktop's box), so the test
  types one and reads the disabled Send next to Stop instead of taking Stop as Send.
- agent-pane-soft-edges: since #22860 the foot's fade runs 56px while Jump to latest stands there;
  an edge fades when its ramp is larger than zero, not only at exactly 18px.


Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant