Skip to content

cmux-next settings: Undo bar clears the last row, titles and density names line up (layout pass 1) - #22785

Merged
teamleaderleo merged 3 commits into
feat-cmux-nextfrom
cmux/layout-pass
Oct 21, 2026
Merged

teamleaderleo merged 3 commits into
feat-cmux-nextfrom
cmux/layout-pass

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Layout pass: running list

Defects from the layout pass (gallery, dark, 16x9) and where each goes. ✅ = this PR.

  • ✅ Settings: Undo/Redo/Reset bar covered the last row's control at rest (Borders, Accent)
  • ✅ Settings: group titles 4px off the rows' text edge; Density lead-in 16px off
  • ✅ Settings > Appearance: density names stepped down by preview height, with dead space under the short ones
  • Next (this lane): Settings accounts buttons, switches off-state, profile editor native controls; pages: cloud badge, icon-picker giant tiles, markdown toolbar, changelog duplicate title, chief-inspector orange bars, diff black file bars, quick-surface padding, model-picker popup unstyled in gallery
  • Handed off: transcript-density, message-actions, prompt-queue-edit, composer-scroll, activity-indicators, context-menus, newtab lanes, sidebar-cleanup

Summary

  • The floating Undo/Redo/Reset bar on Appearance/Theme is sticky, and sticky stops at the scroller's content box, so it sat 16px above the 64px end padding and covered the last row's control even at rest. Its offset now reaches into that padding (--content-pad-end), so it rests 16px above the pane's edge.
  • Group titles and the Density lead-in start on the rows' text edge (16px; 10px under 640px), not 12px / 0px.
  • Density tiles: each preview takes the tile's slack, so all five names sit on one line under equal-size previews.

Screenshots

Before After
appearance before appearance after
theme before theme after

Testing

  • bun test src/pages/settings: 211 pass, 0 fail.
  • scripts/web-lint.sh: only the base warning in cv-user__image-failed (not touched here), red on base.

Observed / Not run

  • Observed: Linux gallery before/after captures (Chromium, dark, 16x9), attached.
  • Not run: light mode and the Mac app (CSS only, no native change).

Changelog

  • Fixed: Settings' Undo bar no longer covers the last setting, and the Density tiles and group titles line up.

🤖 Generated with Claude Code

Agent session: huge-blue

…rows' text edge, density names on one line

- The floating Undo/Redo/Reset bar stopped 16px above the scroller's end padding, so at rest it
  covered the last row's control (Borders, Accent). It now sits 16px above the pane's edge.
- Group titles and the Density lead-in start on the rows' text edge (16px, 10px when narrow)
  instead of 12px / 0px.
- Density tiles: each preview takes the tile's slack, so the five names share one line under
  equal-size previews instead of stepping down by preview height.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2a-ee79-7910-9d76-ef0536b9880d&host=huge-blue
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 01a3c4c: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr22785 -f ref=cmux/layout-pass -f platform=macos -f backend_mode=local

Probably yours: agent-pane-wheel-pass-through.test.ts, agent-pane-wheel-pass-through.test.ts fails here but not on main's latest full suite. Seen on other PRs too (likely flaky): composer-location-strip.test.ts, composer-location-strip.test.ts, composer-turn-cycle.test.ts and 11 more. This PR merged before its CI finished: fix forward on main.

CI failed on 01a3c4c622 (run 39533709477 attempt 1): 4 code, 1 unknown.

Job Verdict Why
web / react-apps-check (2) code a web test failed
web / react-apps-check (3) code a web test failed
web / react-apps-check (4) code a web test failed
web / react-apps-check (1) code a web test failed
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Failures:

  • new in this PR agent-pane-wheel-pass-through.test.ts chromium > the wheel over a long draft stops at its ends and moves nothing else: failed (job)
  • new in this PR agent-pane-wheel-pass-through.test.ts webkit > the wheel over a long draft stops at its ends and moves nothing else: failed (job)
  • seen on other PRs composer-location-strip.test.ts the chat composer at 420 px: the strip's marks line up with the prompt's edges: failed (job)
  • seen on other PRs composer-location-strip.test.ts the chat composer at 760 px: the strip's marks line up with the prompt's edges: failed (job)
  • seen on other PRs composer-turn-cycle.test.ts at 420 px typing while the turn runs moves neither the mic nor Stop: failed (job)
  • seen on other PRs composer-turn-cycle.test.ts at 720 px typing while the turn runs moves neither the mic nor Stop: failed (job)
  • seen on other PRs composer-mention.test.ts @ then letters lists the chat's matching files and Return writes the path: failed (job)
  • seen on other PRs composer-mention.test.ts after picking a path markdown escapes, typing on leaves the picker closed: failed (job)
  • seen on other PRs composer-mention.test.ts @proje lists other chats, then folders, then the chat folder's files: failed (job)
  • seen on other PRs composer-mention.test.ts a chat named for a long prompt does not take @app from the file: failed (job)
  • ... 6 more in the job logs
Matched log lines
web / react-apps-check (2): (fail) chromium > the wheel over a long draft stops at its ends and moves nothing else [4085.42ms]
web / react-apps-check (3): (fail) @ then letters lists the chat's matching files and Return writes the path [2017.47ms]
web / react-apps-check (4): (fail) clicking a background task's end opens its terminal beside the chat [934.36ms]
web / react-apps-check (1): (fail) ↑ and ↓ in an empty prompt step through the chat's earlier prompts [1687.22ms]

Not re-run automatically: web / react-apps-check (2), web / react-apps-check (3), web / react-apps-check (4), web / react-apps-check (1), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: web / Web status; NEW: green on the base b2e653c; do not merge until green; see lane-rules
red: web / react-apps-check; no finished base run on b2e653c to compare; do not merge until green; see lane-rules
red: web / react-apps-check (1); no finished base run on b2e653c to compare; do not merge until green; see lane-rules
red: web / react-apps-check (2); no finished base run on b2e653c to compare; do not merge until green; see lane-rules
red: web / react-apps-check (3); no finished base run on b2e653c to compare; do not merge until green; see lane-rules
red: web / react-apps-check (4); no finished base run on b2e653c to compare; do not merge until green; see lane-rules

Tour of 01a3c4c622 (run): no media. The tour did not run: only webview code changed (3 path(s)), which the gallery advisory run checks in Linux Chromium on the pull request (its artifact holds any captures); add the media-tour-mac label to tour it on a Mac.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-q06fb created for this PR by the cmux coordinator.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

owner: 01a15c2a-ee79-7910-9d76-ef0536b9880d

@teamleaderleo
teamleaderleo marked this pull request as ready for review October 21, 2026 02:33
@teamleaderleo
teamleaderleo merged commit 58c24ac into feat-cmux-next Oct 21, 2026
@teamleaderleo
teamleaderleo deleted the cmux/layout-pass branch October 21, 2026 02:40
This was referenced Oct 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant