Repository navigation
fix(webviews): trust-ask-corner and soft-edges browser tests match the composer they test - #22989
Conversation
…e composer they test Both tests landed red: the webviews browser tests were skipped on every PR while the Chief inspector page was stale (#22839 to #22877), so neither ran before merging. - agent-pane-trust-ask-corner (#22860): the card's top corners square off under a queue or strip on it by design, so the bar is now compared with the card's own (bottom) corner, which is the token both read. Send comes in with a draft's first letter (Claude desktop's box), so the test types one and reads the disabled Send next to Stop instead of taking Stop as Send. - agent-pane-soft-edges: since #22860 the foot's fade runs 56px while Jump to latest stands there; an edge fades when its ramp is larger than zero, not only at exactly 18px. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue
|
owner: 01a15c2c-32f4-7bb3-97e5-4c17864ff52e on huge-blue |
|
owner: 01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d on huge-blue |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Unclear: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: web / Web status; no finished base run on 1db7859 to compare; do not merge until green; see lane-rules Tour of |
|
Bead |
|
Shipped in:
|
Two browser tests that landed red on feat-cmux-next pass again. #22860 added one of them and broke the other. Neither ever ran before merging: every webviews browser test was skipped on PRs while the Chief inspector page was stale (#22839, fixed by #22877). Both are test fixes. The composer behaves as #22860 intends.
agent-pane-trust-ask-corner(added by Agent chat: trust bar takes the composer's corner, no orphan caption, fade behind Jump to latest #22860):borderTopLeftRadius, which is 0px by design when a queue or strip stands on the card (composerLocation.csssquares the card's top corners there). It now reads the card's own corner, a bottom one, which is the--acpmux-composer-radiusboth read: 11px and 11px in the inline look..acpmux-sendto be Send, but mid-turn that's Stop (acpmux-send acpmux-cancel), and Send only appears with a draft's first letter (Claude desktop's box). It now types a draft and checks that the disabled Send's tooltip is "Answer the trust question first".agent-pane-soft-edges: since Agent chat: trust bar takes the composer's corner, no orphan caption, fade behind Jump to latest #22860, the foot's fade runs 56px while Jump to latest stands there. The probe counted an edge as fading only at exactly 18px, so scrolled-up states read as "no fade". An edge now fades when its ramp is larger than zero. Reduce Transparency still reads as no fade, since it sets both ramps to 0px.Testing
CMUX_BROWSER_TESTS=1 bun test test/<file>inwebviews/on Linux, bun 1.4.2:af8fbaad6adagent-pane-trust-ask-corner.test.ts@1100: bar 11px, card 0px;Received: "Stop")agent-pane-soft-edges.test.tsmiddle.bottom/start.bottomfalse)git bisect runwith soft-edges from #22876 to the tip names #22860 (f42ed81cbc3). trust-ask-corner already fails at #22860's own merge commit.scripts/web-lint.shandprepush-gate.pyare clean.Observed / Not run
Observed: the runs above. Not run: the other base browser-test reds.
agent-pane-adopted-tool-calls(red since at least 03:03Z, before the skip window), theagent-pane-stream-jitterWebKit case, and the composer-* tests pane-toolbar owns (#22902) are separate.Changelog
none
Agent session: huge-blue
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the two webviews browser tests that landed red on the base branch. Both are test fixes; composer behavior is unchanged, and the tests were skipped on PRs while the Chief inspector page was stale, so neither ran before the change that broke them landed.
agent-pane-trust-ask-cornerreads the card's bottom corner instead of its top-left (which squares off by design under a queue or strip) and types a draft to find the disabled Send rather than taking Stop for Send.agent-pane-soft-edgesnow treats an edge as fading when its ramp is larger than zero, since the foot fade runs 56px while Jump to latest stands there; Reduce Transparency still reads as no fade.Written for commit fa73483. Summary will update on new commits.