Skip to content

fix(webviews): trust-ask-corner and soft-edges browser tests match the composer they test - #22989

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
cmux/land-and-ci-b1
Oct 21, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
cmux/land-and-ci-b1

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Two browser tests that landed red on feat-cmux-next pass again. #22860 added one of them and broke the other. Neither ever ran before merging: every webviews browser test was skipped on PRs while the Chief inspector page was stale (#22839, fixed by #22877). Both are test fixes. The composer behaves as #22860 intends.

  • agent-pane-trust-ask-corner (added by Agent chat: trust bar takes the composer's corner, no orphan caption, fade behind Jump to latest #22860):
    • Corner case: it compared the trust bar with the card's borderTopLeftRadius, which is 0px by design when a queue or strip stands on the card (composerLocation.css squares the card's top corners there). It now reads the card's own corner, a bottom one, which is the --acpmux-composer-radius both read: 11px and 11px in the inline look.
    • Caption case: it took the first .acpmux-send to be Send, but mid-turn that's Stop (acpmux-send acpmux-cancel), and Send only appears with a draft's first letter (Claude desktop's box). It now types a draft and checks that the disabled Send's tooltip is "Answer the trust question first".
  • agent-pane-soft-edges: since Agent chat: trust bar takes the composer's corner, no orphan caption, fade behind Jump to latest #22860, the foot's fade runs 56px while Jump to latest stands there. The probe counted an edge as fading only at exactly 18px, so scrolled-up states read as "no fade". An edge now fades when its ramp is larger than zero. Reduce Transparency still reads as no fade, since it sets both ramps to 0px.

Testing

CMUX_BROWSER_TESTS=1 bun test test/<file> in webviews/ on Linux, bun 1.4.2:

file base af8fbaad6ad this head
agent-pane-trust-ask-corner.test.ts 0 pass 2 fail (@1100: bar 11px, card 0px; Received: "Stop") 2 pass
agent-pane-soft-edges.test.ts 0 pass 1 fail (middle.bottom/start.bottom false) 1 pass

git bisect run with soft-edges from #22876 to the tip names #22860 (f42ed81cbc3). trust-ask-corner already fails at #22860's own merge commit. scripts/web-lint.sh and prepush-gate.py are clean.

Observed / Not run

Observed: the runs above. Not run: the other base browser-test reds. agent-pane-adopted-tool-calls (red since at least 03:03Z, before the skip window), the agent-pane-stream-jitter WebKit case, and the composer-* tests pane-toolbar owns (#22902) are separate.

Changelog

none

Agent session: huge-blue

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the two webviews browser tests that landed red on the base branch. Both are test fixes; composer behavior is unchanged, and the tests were skipped on PRs while the Chief inspector page was stale, so neither ran before the change that broke them landed.

  • agent-pane-trust-ask-corner reads the card's bottom corner instead of its top-left (which squares off by design under a queue or strip) and types a draft to find the disabled Send rather than taking Stop for Send.
  • agent-pane-soft-edges now treats an edge as fading when its ramp is larger than zero, since the foot fade runs 56px while Jump to latest stands there; Reduce Transparency still reads as no fade.

Written for commit fa73483. Summary will update on new commits.

View guided diff Turn on auto-fix

…e composer they test

Both tests landed red: the webviews browser tests were skipped on every PR while the Chief
inspector page was stale (#22839 to #22877), so neither ran before merging.

- agent-pane-trust-ask-corner (#22860): the card's top corners square off under a queue or strip
  on it by design, so the bar is now compared with the card's own (bottom) corner, which is the
  token both read. Send comes in with a draft's first letter (Claude desktop's box), so the test
  types one and reads the disabled Send next to Stop instead of taking Stop as Send.
- agent-pane-soft-edges: since #22860 the foot's fade runs 56px while Jump to latest stands there;
  an edge fades when its ramp is larger than zero, not only at exactly 18px.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

owner: 01a15c2c-32f4-7bb3-97e5-4c17864ff52e on huge-blue

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

owner: 01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d on huge-blue

@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review fa73483: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr22989 -f ref=cmux/land-and-ci-b1 -f platform=macos -f backend_mode=local

Unclear: web / react-apps-check failed: no known signature; failed step: Check webview test shards. This PR merged before its CI finished: fix forward on main.

CI failed on fa734838d9 (run 39549755100 attempt 1): 4 code, 1 unknown.

Job Verdict Why
web / react-apps-check (4) code a web test failed
web / react-apps-check (1) code a web test failed
web / react-apps-check (2) code a web test failed
web / react-apps-check (3) code a web test failed
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Failures:

  • seen on other PRs composer-location-strip.test.ts the chat composer at 420 px: the strip's marks line up with the prompt's edges: failed (job)
  • seen on other PRs composer-location-strip.test.ts the chat composer at 760 px: the strip's marks line up with the prompt's edges: failed (job)
  • seen on other PRs quiet-access-chip.test.ts chromium: Full access draws in the model chip's color: failed (job)
  • seen on other PRs quiet-access-chip.test.ts webkit: Full access draws in the model chip's color: failed (job)
  • seen on other PRs agent-pane-queue-steer.test.ts queued and steering prompts > the queue takes its own place in the stack: nothing is cut off or draw...: failed (job)
  • seen on other PRs agent-pane-stream-jitter.test.ts webkit: scrolling up while a reply streams is never pulled back: failed (job)
  • seen on other PRs composer-mention.test.ts @ then letters lists the chat's matching files and Return writes the path: failed (job)
  • seen on other PRs composer-mention.test.ts after picking a path markdown escapes, typing on leaves the picker closed: failed (job)
  • seen on other PRs composer-mention.test.ts @proje lists other chats, then folders, then the chat folder's files: failed (job)
  • seen on other PRs composer-mention.test.ts a chat named for a long prompt does not take @app from the file: failed (job)
  • ... 18 more in the job logs
Matched log lines
web / react-apps-check (4): (fail) the chat composer at 420 px: the strip's marks line up with the prompt's edges [1757.98ms]
web / react-apps-check (1): (fail) queued and steering prompts > the queue takes its own place in the stack: nothing is cut off or drawn over [1363.07ms]
web / react-apps-check (2): (fail) chromium, Catppuccin Mocha, 300px: the context's Copy trails its label and covers no text [1897.83ms]
web / react-apps-check (3): (fail) no description line on any Settings page is over 60 characters, in any language [16066.97ms]

Not re-run automatically: web / react-apps-check (4), web / react-apps-check (1), web / react-apps-check (2), web / react-apps-check (3), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: web / Web status; no finished base run on 1db7859 to compare; do not merge until green; see lane-rules
red: web / react-apps-check; no finished base run on 1db7859 to compare; do not merge until green; see lane-rules
red: web / react-apps-check (1); no finished base run on 1db7859 to compare; do not merge until green; see lane-rules
red: web / react-apps-check (2); no finished base run on 1db7859 to compare; do not merge until green; see lane-rules
red: web / react-apps-check (3); no finished base run on 1db7859 to compare; do not merge until green; see lane-rules
red: web / react-apps-check (4); no finished base run on 1db7859 to compare; do not merge until green; see lane-rules

Tour of fa734838d9 (run): no media. The tour did not run: only webview code changed (2 path(s)), which the gallery advisory run checks in Linux Chromium on the pull request (its artifact holds any captures); add the media-tour-mac label to tour it on a Mac.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-hq5dq created for this PR by the cmux coordinator.

@teamleaderleo
teamleaderleo merged commit 0e91b1e into feat-cmux-next Oct 21, 2026
@teamleaderleo
teamleaderleo deleted the cmux/land-and-ci-b1 branch October 21, 2026 05:31
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant