Repository navigation
fix(cmux-next editor): the find pill stays inside a narrow editor - #22872
Merged
Merged
Conversation
…th Replace open (red) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2a-ee79-7910-9d76-ef0536b9880d&host=huge-blue
…nstead of running off the left edge Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2a-ee79-7910-9d76-ef0536b9880d&host=huge-blue
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2a-ee79-7910-9d76-ef0536b9880d&host=huge-blue
Collaborator
Author
|
owner: 01a15c2a-ee79-7910-9d76-ef0536b9880d |
… editor, Replace closed too (red) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2a-ee79-7910-9d76-ef0536b9880d&host=huge-blue
…stays in reach with Replace closed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2a-ee79-7910-9d76-ef0536b9880d&host=huge-blue
Collaborator
Author
|
Bead |
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
This was referenced Oct 21, 2026
This was referenced Oct 21, 2026
teamleaderleo
added a commit
that referenced
this pull request
Oct 21, 2026
…ase type-check red from #22872) (#22927) Indexing an object literal by role widened each icon to string, so vp check failed with TS2322 (string is not assignable to IconName) on every webviews push. Name the map with satisfies Record<FindPillIconRole, IconName>, as find/FindBar.tsx does. Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c08-3514-7430-9c71-6b7ba4fdac72&host=cosmic-gray Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 21, 2026
Merged
Contributor
|
Shipped in:
|
Contributor
|
Shipped in:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layout pass, running list (lane: layout-pass; full list in cmuxterm-hq
knowledge/layout-pass.md)What
In a narrow code editor, the find pill with Replace open ran off the pane's left edge. At 360px it started at x≈−39, which clipped the expand chevron and cut the Replace placeholder to "place".
.ed-findwas absolutely positioned with onlyright, so the pill kept its 150px fields and grew leftwards..ed-findnow has the left inset too, with the pill packed right in a click-through band (pointer-events: none; the pill already setsauto). The pill and its rows can now shrink (min-width: 0), so in a narrow pane the fields give way down to their 40px minimum, in both Find's one row and Replace's two. At normal widths nothing moves, because the pill is still sized to its content and pinned top right.Test
CMUX_BROWSER_TESTS=1 bun test test/editor-find-narrow.test.tsx(real Chromium) renders the pill with Replace open inside.ed-frameat 360px and 300px, with Replace closed and open. It checks that the pill stays within the 10px insets and that every button and input stays inside the pill.Screenshots
Gallery
editor.find-barat 360px. "Before" is the base gallery. "After" is the same gallery page with this PR's two rules injected. The advisory capture didn't help here: it rendered base, then exited before the head stage.Observed / Not run
prepush-gate.py: no new violations.bun run check, because heavy lints moved off huge-blue. CI's web lint runs it.Changelog
Fixed: the code editor's find bar stays inside a narrow editor instead of running off its left edge.
Agent session: huge-blue
🤖 Generated with Claude Code