Skip to content

fix(cmux-next editor): the find pill stays inside a narrow editor - #22872

Merged
teamleaderleo merged 5 commits into
feat-cmux-nextfrom
cmux/layout-pass-editor-find
Oct 21, 2026
Merged

teamleaderleo merged 5 commits into
feat-cmux-nextfrom
cmux/layout-pass-editor-find

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Layout pass, running list (lane: layout-pass; full list in cmuxterm-hq knowledge/layout-pass.md)

What

In a narrow code editor, the find pill with Replace open ran off the pane's left edge. At 360px it started at x≈−39, which clipped the expand chevron and cut the Replace placeholder to "place". .ed-find was absolutely positioned with only right, so the pill kept its 150px fields and grew leftwards.

.ed-find now has the left inset too, with the pill packed right in a click-through band (pointer-events: none; the pill already sets auto). The pill and its rows can now shrink (min-width: 0), so in a narrow pane the fields give way down to their 40px minimum, in both Find's one row and Replace's two. At normal widths nothing moves, because the pill is still sized to its content and pinned top right.

Test

CMUX_BROWSER_TESTS=1 bun test test/editor-find-narrow.test.tsx (real Chromium) renders the pill with Replace open inside .ed-frame at 360px and 300px, with Replace closed and open. It checks that the pill stays within the 10px insets and that every button and input stays inside the pill.

  • Base: fails. The pill's x is −39.45 at 360px and −99.45 at 300px.
  • First fix: Replace-closed failed, because the row kept its 389px min-content and Close went off-screen. The reviewer caught it, and the test now covers it.
  • Head: 4 pass.

Screenshots

Gallery editor.find-bar at 360px. "Before" is the base gallery. "After" is the same gallery page with this PR's two rules injected. The advisory capture didn't help here: it rendered base, then exited before the head stage.

Before After
Replace, dark
Replace, light
Find, dark
Find, light

Observed / Not run

  • Observed: the test above, red then green, on huge-blue. prepush-gate.py: no new violations.
  • Not run locally: bun run check, because heavy lints moved off huge-blue. CI's web lint runs it.

Changelog

Fixed: the code editor's find bar stays inside a narrow editor instead of running off its left edge.

Agent session: huge-blue

🤖 Generated with Claude Code

@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

owner: 01a15c2a-ee79-7910-9d76-ef0536b9880d

@teamleaderleo teamleaderleo added risk:normal Risk tier (docs/ci/risk-tiers.md) and removed risk:low Risk tier (docs/ci/risk-tiers.md) labels Oct 21, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-v4dww created for this PR by the cmux coordinator.

@github-actions

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 93957e9: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr22872 -f ref=cmux/layout-pass-editor-find -f platform=macos -f backend_mode=local

@teamleaderleo
teamleaderleo merged commit ec6828e into feat-cmux-next Oct 21, 2026
@teamleaderleo
teamleaderleo deleted the cmux/layout-pass-editor-find branch October 21, 2026 03:50
teamleaderleo added a commit that referenced this pull request Oct 21, 2026
…ase type-check red from #22872) (#22927)

Indexing an object literal by role widened each icon to string, so vp check
failed with TS2322 (string is not assignable to IconName) on every webviews
push. Name the map with satisfies Record<FindPillIconRole, IconName>, as
find/FindBar.tsx does.


Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c08-3514-7430-9c71-6b7ba4fdac72&host=cosmic-gray

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant