Repository navigation
Agent chat: trust bar takes the composer's corner, no orphan caption, fade behind Jump to latest - #22860
Conversation
Red on base: the bar is 12px under the card's 11px (inline look) or 18px corner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15bf1-fdc7-79b0-b869-8ac78b0edd90&host=cosmic-gray
The bar and the card read one --acpmux-composer-radius: the rules that set the card's corner (18px, and 11px in the inline look) also set it on the asks stack, so the bar follows whatever corner the card's look sets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15bf1-fdc7-79b0-b869-8ac78b0edd90&host=cosmic-gray
|
owner: 01a15bf1-fdc7-79b0-b869-8ac78b0edd90 |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: web / Web status; base red: the same failure on the base 51338c0; does not block Tour of |
|
Found 1 test failure on Blacksmith runners: Failure
|
|
Bead |
…es past Jump to latest Red on base: "Answer the trust question first" stands between the trust bar and the card, and the bottom fade stays 18px under the 44px-high Jump to latest button. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15bf1-fdc7-79b0-b869-8ac78b0edd90&host=cosmic-gray
…Jump to latest The open trust question's "Answer the trust question first" no longer draws as a caption between the bar and the card (SendBlock.shownAbove); Send's tooltip keeps it. While Jump to latest shows, the transcript's bottom fade runs 56px, past the button, so a date line passes out of sight behind it. From the layout pass (hq#2696). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15bf1-fdc7-79b0-b869-8ac78b0edd90&host=cosmic-gray
…ason Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15bf1-fdc7-79b0-b869-8ac78b0edd90&host=cosmic-gray
|
Merged at ea5f9ce after a fresh independent review passed. The webview test shards stopped at "Build the web bundles" on a base red (stale generated |
…e composer they test (#22989) Both tests landed red: the webviews browser tests were skipped on every PR while the Chief inspector page was stale (#22839 to #22877), so neither ran before merging. - agent-pane-trust-ask-corner (#22860): the card's top corners square off under a queue or strip on it by design, so the bar is now compared with the card's own (bottom) corner, which is the token both read. Send comes in with a draft's first letter (Claude desktop's box), so the test types one and reads the disabled Send next to Stop instead of taking Stop as Send. - agent-pane-soft-edges: since #22860 the foot's fade runs 56px while Jump to latest stands there; an edge fades when its ramp is larger than zero, not only at exactly 18px. Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
Shipped in:
|
|
Shipped in:
|
Summary
Fixes the composer-scroll lane's three defects from the layout pass (manaflow-ai/cmuxterm-hq#2696,
knowledge/layout-pass.md). All three reproduce on current base in the gallery frameagent-pane.bottom-stack/trust-permission-queue, or in any chat scrolled up.composerLocation.cssthat set the card's--acpmux-composer-radius(18px, and 11px in the inline look) now also set it on.acpmux-asks-stack..acpmux-trust-askreads that token, with a 12px fallback elsewhere. So the bar follows whatever corner the card's look sets, including composer-polish's cmux NEXT composer: model names, an inline box, one ↵ steer control, room at the bottom #22667. On base the bar was 12px. Tool cards inside the permission panel reuse the trust-ask class, so they take the card's corner too. Tool cards in the transcript keep 12px.SendBlock.shownAbovedrops that caption, and Send's tooltip keeps the reason. The remote and Don't trust reasons still draw, because nothing above says them.Changelog
Fixed: In agent chat, the folder trust bar matches the composer's corners and no longer has a repeated caption under it, and the transcript fades out behind the Jump to latest button.
Testing
Commands (real Chromium and WebKit):
cd webviews && bun test test/agent-pane-trust-ask-corner.test.ts: the bar's corner equals the card's at 1100px and 420px, and no caption shows while the question is open, with Send's tooltip keeping the reason.cd webviews && bun test test/agent-pane-wheel-pass-through.test.ts: the fade is 56px while Jump to latest shows.agent-pane-column-edgesno longer lists the trust note in that frame, because the note is gone.Expected red on the test commits (ea38368, 6f3700c) and green on the head.
Observed / Not run
Agent session: cosmic-gray
🤖 Generated with Claude Code