Skip to content

Agent chat: trust bar takes the composer's corner, no orphan caption, fade behind Jump to latest - #22860

Merged
teamleaderleo merged 5 commits into
feat-cmux-nextfrom
cmux/trust-radius
Oct 21, 2026
Merged

teamleaderleo merged 5 commits into
feat-cmux-nextfrom
cmux/trust-radius

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Fixes the composer-scroll lane's three defects from the layout pass (manaflow-ai/cmuxterm-hq#2696, knowledge/layout-pass.md). All three reproduce on current base in the gallery frame agent-pane.bottom-stack / trust-permission-queue, or in any chat scrolled up.

  • The trust bar's radius doesn't match the composer's. The rules in composerLocation.css that set the card's --acpmux-composer-radius (18px, and 11px in the inline look) now also set it on .acpmux-asks-stack. .acpmux-trust-ask reads that token, with a 12px fallback elsewhere. So the bar follows whatever corner the card's look sets, including composer-polish's cmux NEXT composer: model names, an inline box, one ↵ steer control, room at the bottom #22667. On base the bar was 12px. Tool cards inside the permission panel reuse the trust-ask class, so they take the card's corner too. Tool cards in the transcript keep 12px.
  • An orphan caption sits between the trust bar and the composer. While the trust question is open, the composer drew "Answer the trust question first" as a caption under the bar that already asks it. SendBlock.shownAbove drops that caption, and Send's tooltip keeps the reason. The remote and Don't trust reasons still draw, because nothing above says them.
  • Jump to latest overlaps the date line, with no fade. While the button shows, the transcript's bottom fade runs 56px instead of 18px, reaching a gap past the 32px button that sits 12px up. Rows, including a centered date line, pass out of sight behind it instead of reading through its glass.

Changelog

Fixed: In agent chat, the folder trust bar matches the composer's corners and no longer has a repeated caption under it, and the transcript fades out behind the Jump to latest button.

Testing

Commands (real Chromium and WebKit):

  • cd webviews && bun test test/agent-pane-trust-ask-corner.test.ts: the bar's corner equals the card's at 1100px and 420px, and no caption shows while the question is open, with Send's tooltip keeping the reason.
  • cd webviews && bun test test/agent-pane-wheel-pass-through.test.ts: the fade is 56px while Jump to latest shows.
  • agent-pane-column-edges no longer lists the trust note in that frame, because the note is gone.

Expected red on the test commits (ea38368, 6f3700c) and green on the head.

Observed / Not run

  • Observed: pre-commit and pre-push hooks pass. A review subagent passed the corner change.
  • Not run: tests on this Mac (load rule), so CI's browser lane is the check. No native app look. No gallery before/after, because the layout pass's captures are on huge-blue, which is unreachable.

Agent session: cosmic-gray

🤖 Generated with Claude Code

teamleaderleo and others added 2 commits October 20, 2026 20:16
Red on base: the bar is 12px under the card's 11px (inline look) or 18px corner.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15bf1-fdc7-79b0-b869-8ac78b0edd90&host=cosmic-gray
The bar and the card read one --acpmux-composer-radius: the rules that set the card's corner (18px,
and 11px in the inline look) also set it on the asks stack, so the bar follows whatever corner the
card's look sets.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15bf1-fdc7-79b0-b869-8ac78b0edd90&host=cosmic-gray
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

owner: 01a15bf1-fdc7-79b0-b869-8ac78b0edd90

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review ea5f9ce: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr22860 -f ref=cmux/trust-radius -f platform=macos -f backend_mode=local

red: web / Web status; base red: the same failure on the base 51338c0; does not block
red: web / react-apps-check; base red: the same failure on the base 51338c0; does not block
red: web / react-apps-check (1); base red: the same failure on the base 51338c0; does not block
red: web / react-apps-check (2); base red: the same failure on the base 51338c0; does not block
red: web / react-apps-check (3); base red: the same failure on the base 51338c0; does not block
red: web / react-apps-check (4); base red: the same failure on the base 51338c0; does not block

Tour of ea5f9ce67a (run): no media. The tour did not run: only webview code changed (10 path(s)), which the gallery advisory run checks in Linux Chromium on the pull request (its artifact holds any captures); add the media-tour-mac label to tour it on a Mac.

@blacksmith-sh

blacksmith-sh Bot commented Oct 21, 2026

Copy link
Copy Markdown

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)/
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-7r9nx created for this PR by the cmux coordinator.

teamleaderleo and others added 2 commits October 20, 2026 20:21
…es past Jump to latest

Red on base: "Answer the trust question first" stands between the trust bar and the card, and the
bottom fade stays 18px under the 44px-high Jump to latest button.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15bf1-fdc7-79b0-b869-8ac78b0edd90&host=cosmic-gray
…Jump to latest

The open trust question's "Answer the trust question first" no longer draws as a caption between
the bar and the card (SendBlock.shownAbove); Send's tooltip keeps it. While Jump to latest shows,
the transcript's bottom fade runs 56px, past the button, so a date line passes out of sight behind
it. From the layout pass (hq#2696).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15bf1-fdc7-79b0-b869-8ac78b0edd90&host=cosmic-gray
@teamleaderleo teamleaderleo changed the title Agent chat: the folder trust bar takes the composer card's corner Agent chat: trust bar takes the composer's corner, no orphan caption, fade behind Jump to latest Oct 21, 2026
@teamleaderleo
teamleaderleo merged commit f42ed81 into feat-cmux-next Oct 21, 2026
@teamleaderleo
teamleaderleo deleted the cmux/trust-radius branch October 21, 2026 03:42
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Merged at ea5f9ce after a fresh independent review passed. The webview test shards stopped at "Build the web bundles" on a base red (stale generated Native/OptChat/optchat-chief/inspector/index.html; src/optchat-inspector imports nothing this PR changed), so this PR's new tests have not run in CI yet. I'll fix forward if they go red once the base is green.

teamleaderleo added a commit that referenced this pull request Oct 21, 2026
…e composer they test (#22989)

Both tests landed red: the webviews browser tests were skipped on every PR while the Chief
inspector page was stale (#22839 to #22877), so neither ran before merging.

- agent-pane-trust-ask-corner (#22860): the card's top corners square off under a queue or strip
  on it by design, so the bar is now compared with the card's own (bottom) corner, which is the
  token both read. Send comes in with a draft's first letter (Claude desktop's box), so the test
  types one and reads the disabled Send next to Stop instead of taking Stop as Send.
- agent-pane-soft-edges: since #22860 the foot's fade runs 56px while Jump to latest stands there;
  an edge fades when its ramp is larger than zero, not only at exactly 18px.


Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant