Skip to content

fix(cmux-next harnesses): a harness with no mark keeps the text column - #22847

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
cmux/layout-pass-harnesses
Oct 21, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
cmux/layout-pass-harnesses

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Layout pass, harnesses surface.

Running list (layout pass, 2026-10-20 GUI push): fixed #22785 (Settings: Undo bar over the last row, title edge, density names), #22825 (Markdown toolbar width), #22839 (Chief inspector latency bars in the theme accent), and this PR (harness rows without a mark). The full list is in HQ knowledge/layout-pass.md.

What

Harness rows without an agent mark (Vercel AI Gateway) started the name at the icon's left edge, which broke the text column every other row shares. AgentMark already has a reserve prop for exactly this case: it keeps the empty 18px slot. The fix is that one prop in the harness list.

Before / after (gallery agent-pane.harnesses, this-mac, 560px)

Before After
before dark after dark
before light after light

Changelog

  • Fixed: In Harnesses, a harness without an icon lines up with the other names.

Observed / Not run

  • Ran: gallery build on base and head on Linux, then captured agent-pane.harnesses (this-mac, install-failed) at 360, 560 and 760px in light and dark, 12 shots each side. Only the Vercel row moves. oxfmt --check and prepush-gate.py pass.
  • Not run: the full bun run check (the sparse worktree symlinks node_modules, so it lints that), and no macOS build (layout-only webview change).

Agent session: huge-blue

🤖 Generated with Claude Code

Rows without an agent mark (Vercel AI Gateway) started their name at the
icon's edge. AgentMark's reserve prop keeps the empty slot.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2a-ee79-7910-9d76-ef0536b9880d&host=huge-blue
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

owner: 01a15c2a-ee79-7910-9d76-ef0536b9880d

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review d02768f: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr22847 -f ref=cmux/layout-pass-harnesses -f platform=macos -f backend_mode=local

Unclear: web / react-apps-check (4) failed: no known signature; failed step: Build the web bundles. This PR merged before its CI finished: fix forward on main.

CI failed on d02768fe75 (run 39537189470 attempt 1): 5 unknown.

Job Verdict Why
web / react-apps-check (4) unknown no known signature; failed step: Build the web bundles
web / react-apps-check (2) unknown no known signature; failed step: Build the web bundles
web / react-apps-check (1) unknown no known signature; failed step: Build the web bundles
web / react-apps-check (3) unknown no known signature; failed step: Build the web bundles
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Not re-run automatically: web / react-apps-check (4), web / react-apps-check (2), web / react-apps-check (1), web / react-apps-check (3), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: red check: Script tests (pin-cmux-tui, embed-cef, ensure-cef store) (+1 more) is not red on the base 50ec56c; do not merge until green; see lane-rules
red: web / Web status; base red: the same failure on the base 50ec56c; does not block
red: web / react-apps-check; base red: the same failure on the base 50ec56c; does not block
red: web / react-apps-check (1); base red: the same failure on the base 50ec56c; does not block
red: web / react-apps-check (2); base red: the same failure on the base 50ec56c; does not block
red: web / react-apps-check (3); base red: the same failure on the base 50ec56c; does not block
red: web / react-apps-check (4); base red: the same failure on the base 50ec56c; does not block

Tour of d02768fe75 (run): no media. The tour did not run: only webview code changed (1 path(s)), which the gallery advisory run checks in Linux Chromium on the pull request (its artifact holds any captures); add the media-tour-mac label to tour it on a Mac.

@blacksmith-sh

blacksmith-sh Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Found 3 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmph6i31xyx/summary-missing.json (live):/summary-missing.json (live): View Logs
/tmp/tmpsroyps54/summary-fail.json (live):/summary-fail.json (live): View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)/
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-ktmaz created for this PR by the cmux coordinator.

@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant