Skip to content

fix(cmux-next coderouter): provider and account rows are one height - #23017

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
cmux/layout-pass-coderouter-rows
Oct 21, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
cmux/layout-pass-coderouter-rows

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Layout pass, running list (full list in cmuxterm-hq knowledge/layout-pass.md):

Summary

CodeRouter's provider and linked-account rows were two heights. A row with a pill button (Connect, Sign In Again) was 37px; a row without one (Gemini "Not found", the Pro account) was 31px, so the list's rules stepped. Rows now hold one control's height whether or not they show a button: min-height: calc(var(--cmux-control-height) + 13px), which covers the 6px padding on each side and the 1px rule. The pill buttons use the shared --cmux-control-height instead of padding, so they follow the interface scale.

Before / after

/coderouter/?mock. Measured row heights: before [37, 37, 31, 31], after [37, 37, 37, 37] at 420 and at 900.

Before After
900, dark
420, light

Test

cd webviews && CMUX_BROWSER_TESTS=1 bun test test/coderouter-row-heights.test.ts

  • Base (red commit 197f4bd): fails with 2 distinct row heights.
  • Head: passes.

Observed / Not run

  • Ran: the test above (red, then green). Also ran oxfmt, oxlint, tsc (no errors in the changed files), check:{layers,type-scale,status-glyphs,system-blue,text-focus,dialog-keys,switch-fetches,browser-lanes} and prepush-gate.py. The stills come from the Vite dev entry in Chromium.
  • Not run: the full bun run check (it's fleet-only on huge-blue; CI runs it) and the native app.

Changelog

Fixed: CodeRouter's provider and account rows are one height.

Agent session: huge-blue

🤖 Generated with Claude Code

teamleaderleo and others added 2 commits October 21, 2026 05:46
…eight

A row with a pill button was 37px and one without 31px, so the list's rules stepped. Rows now
hold one control's height either way, and the pill buttons are the shared control height.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2a-ee79-7910-9d76-ef0536b9880d&host=huge-blue
@teamleaderleo teamleaderleo added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@cursor

cursor Bot commented Oct 21, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

owner: 01a15c2a-ee79-7910-9d76-ef0536b9880d on huge-blue

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 775d42b: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr23017 -f ref=cmux/layout-pass-coderouter-rows -f platform=macos -f backend_mode=local

Unclear: web / react-apps-check failed: no known signature; failed step: Check webview test shards.

CI failed on 775d42b4c9 (run 39551672817 attempt 1): 4 code, 1 unknown.

Job Verdict Why
web / react-apps-check (2) code a web test failed
web / react-apps-check (4) code a web test failed
web / react-apps-check (3) code a web test failed
web / react-apps-check (1) code a web test failed
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Failures:

  • seen on other PRs agent-pane-queue-steer.test.ts queued and steering prompts > the queue takes its own place in the stack: nothing is cut off or draw...: failed (job)
  • seen on other PRs agent-pane-stream-jitter.test.ts webkit: scrolling up while a reply streams is never pulled back: failed (job)
  • seen on other PRs composer-history.test.ts ↑ and ↓ in an empty prompt step through the chat's earlier prompts: failed (job)
  • seen on other PRs rowSummary.test.tsx no description line on any Settings page is over 60 characters, in any language: failed (job)
  • seen on other PRs rowSummary.test.tsx every schema summary fits 60 characters in every language: failed (job)
  • seen on other PRs agent-pane-adopted-tool-calls.test.ts the adopted turn's Worked for opens to its commands and edited files: failed (job)
  • seen on other PRs agent-pane-adopted-tool-calls.test.ts a patch whose files only its input names counts each file, not one: failed (job)
  • seen on other PRs agent-pane-column-edges.test.ts the strip or queue and the card meet square in one rim, and the queue keeps room above: failed (job)
  • seen on other PRs agent-pane-wheel-pass-through.test.ts chromium > the wheel over a long draft stops at its ends and moves nothing else: failed (job)
  • seen on other PRs agent-pane-wheel-pass-through.test.ts webkit > the wheel over a long draft stops at its ends and moves nothing else: failed (job)
  • ... 11 more in the job logs
Matched log lines
web / react-apps-check (2): (fail) queued and steering prompts > the queue takes its own place in the stack: nothing is cut off or drawn over [1272.68ms]
web / react-apps-check (4): (fail) no description line on any Settings page is over 60 characters, in any language [15159.81ms]
web / react-apps-check (3): (fail) the chat composer at 420 px: the strip's marks line up with the prompt's edges [1780.70ms]
web / react-apps-check (1): (fail) nothing is suggested from another folder, another worktree, a merged PR, an old chat or a busy one [43.82ms]

Not re-run automatically: web / react-apps-check (2), web / react-apps-check (4), web / react-apps-check (3), web / react-apps-check (1), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: web / Web status; NEW: green on the base 3c73ce6; do not merge until green; see lane-rules
red: web / react-apps-check; no finished base run on 3c73ce6 to compare; do not merge until green; see lane-rules
red: web / react-apps-check (1); no finished base run on 3c73ce6 to compare; do not merge until green; see lane-rules
red: web / react-apps-check (2); no finished base run on 3c73ce6 to compare; do not merge until green; see lane-rules
red: web / react-apps-check (3); no finished base run on 3c73ce6 to compare; do not merge until green; see lane-rules
red: web / react-apps-check (4); no finished base run on 3c73ce6 to compare; do not merge until green; see lane-rules

CI fast guards failed on 775d42b4c9 (https://github.com/manaflow-ai/cmux/actions/runs/39551672817). It does not block the merge; a red guard merged into main breaks it for every open PR.
The log named no failed step; see the run.

Agents: python3 scripts/ci/guard_attribution.py fix applies the mechanical fixes locally.

Tour of 775d42b4c9 (run): no media. The tour did not run: only webview code changed (2 path(s)), which the gallery advisory run checks in Linux Chromium on the pull request (its artifact holds any captures); add the media-tour-mac label to tour it on a Mac.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-x46e4 created for this PR by the cmux coordinator.

@blacksmith-sh

blacksmith-sh Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Found 26 test failures on Blacksmith runners:

Failures

Test View Logs
src/pages/settings/rowSummary.test.tsx/rowSummary.test.tsx View Logs
src/pages/settings/rowSummary.test.tsx/rowSummary.test.tsx View Logs
test/agent-pane-adopted-tool-calls.test.ts/agent-pane-adopted-tool-calls.test View Logs
test/agent-pane-adopted-tool-calls.test.ts/agent-pane-adopted-tool-calls.test View Logs
test/agent-pane-column-edges.test.ts/agent-pane-column-edges.test View Logs
test/agent-pane-column-edges.test.ts/agent-pane-column-edges.test View Logs
test/agent-pane-queue-steer.test.ts/agent-pane-queue-steer.test View Logs
test/agent-pane-queue-steer.test.ts/agent-pane-queue-steer.test View Logs
test/agent-pane-stream-jitter.test.ts/agent-pane-stream-jitter.test View Logs
test/agent-pane-stream-jitter.test.ts/agent-pane-stream-jitter.test View Logs

...and 16 more test failures. View all on Blacksmith

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant