Repository navigation
fix(cmux-next coderouter): provider and account rows are one height - #23017
Conversation
…height (red) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2a-ee79-7910-9d76-ef0536b9880d&host=huge-blue
…eight A row with a pill button was 37px and one without 31px, so the list's rules stepped. Rows now hold one control's height either way, and the pill buttons are the shared control height. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2a-ee79-7910-9d76-ef0536b9880d&host=huge-blue
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
owner: 01a15c2a-ee79-7910-9d76-ef0536b9880d on huge-blue |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Unclear: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: web / Web status; NEW: green on the base 3c73ce6; do not merge until green; see lane-rules
Agents: Tour of |
|
Bead |
|
Found 26 test failures on Blacksmith runners: Failures
...and 16 more test failures. View all on Blacksmith
|
|
Shipped in:
|
Layout pass, running list (full list in cmuxterm-hq
knowledge/layout-pass.md):Summary
CodeRouter's provider and linked-account rows were two heights. A row with a pill button (Connect, Sign In Again) was 37px; a row without one (Gemini "Not found", the Pro account) was 31px, so the list's rules stepped. Rows now hold one control's height whether or not they show a button:
min-height: calc(var(--cmux-control-height) + 13px), which covers the 6px padding on each side and the 1px rule. The pill buttons use the shared--cmux-control-heightinstead of padding, so they follow the interface scale.Before / after
/coderouter/?mock. Measured row heights: before[37, 37, 31, 31], after[37, 37, 37, 37]at 420 and at 900.Test
cd webviews && CMUX_BROWSER_TESTS=1 bun test test/coderouter-row-heights.test.tsObserved / Not run
check:{layers,type-scale,status-glyphs,system-blue,text-focus,dialog-keys,switch-fetches,browser-lanes}andprepush-gate.py. The stills come from the Vite dev entry in Chromium.bun run check(it's fleet-only on huge-blue; CI runs it) and the native app.Changelog
Fixed: CodeRouter's provider and account rows are one height.
Agent session: huge-blue
🤖 Generated with Claude Code