Skip to content

cmux-next markdown: the toolbar spans the page again (layout pass) - #22825

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
cmux/layout-pass-markdown
Oct 21, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
cmux/layout-pass-markdown

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Layout pass: running list

Running list of defects from the layout pass, with where each one goes. ✅ = this PR, ✔ = merged.

Summary

.ui-toolbar (ui.css, display: inline-flex) and .md-toolbar (display: flex) had the same specificity, so the stylesheet that loaded last won. In the gallery bundle that was ui.css, so the toolbar shrank to fit its content: its bottom border stopped about 286px in, and the file name ran into "Saved" because .md-file's flex: 1 had no room to grow. The rule now sits under its host (.md-toolbar-host > .md-toolbar), so it wins whatever order the bundle loads the stylesheets in. [data-cmux-md-toolbar="false"] still hides the toolbar, since that rule is more specific.

Screenshots

Before After
420px
1200px

Testing

  • scripts/web-lint.sh passed.

Observed / Not run

  • Observed: before/after captures from the Linux gallery (Chromium, dark), at 420 and 1200px.
  • Not run: the Mac app. I didn't check whether the app's own bundle loads the stylesheets in the same order. The fix holds either way.

Changelog

  • Fixed: the Markdown viewer's toolbar spans the whole page again, and the file name no longer runs into "Saved".

🤖 Generated with Claude Code

Agent session: huge-blue

…e bundle loads ui.css in

.ui-toolbar's inline-flex (ui.css) and .md-toolbar's flex had the same specificity, so load order
decided; in the gallery bundle ui.css came last and the bar shrank to its content: its border
stopped at ~286px and the file name ran into "Saved". The rule is now scoped under its host.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2a-ee79-7910-9d76-ef0536b9880d&host=huge-blue
@cursor

cursor Bot commented Oct 21, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 5f9e5be: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr22825 -f ref=cmux/layout-pass-markdown -f platform=macos -f backend_mode=local

Unclear: web / react-apps-check failed: no known signature; failed step: Check webview test shards. This PR merged before its CI finished: fix forward on main.

CI failed on 5f9e5be85c (run 39534378555 attempt 1): 4 code, 1 unknown.

Job Verdict Why
web / react-apps-check (4) code a web test failed
web / react-apps-check (3) code a web test failed
web / react-apps-check (1) code a web test failed
web / react-apps-check (2) code a web test failed
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Failures:

  • seen on other PRs agent-pane-background-tasks.test.ts clicking a background task's end opens its terminal beside the chat: failed (job)
  • seen on other PRs composer-mention.test.ts @ then letters lists the chat's matching files and Return writes the path: failed (job)
  • seen on other PRs composer-mention.test.ts after picking a path markdown escapes, typing on leaves the picker closed: failed (job)
  • seen on other PRs composer-mention.test.ts @proje lists other chats, then folders, then the chat folder's files: failed (job)
  • seen on other PRs composer-mention.test.ts a chat named for a long prompt does not take @app from the file: failed (job)
  • seen on other PRs composer-mention.test.ts a bare @ lists the most recent other chats: failed (job)
  • seen on other PRs composer-mention.test.ts an @ inside a word opens nothing and asks the host for nothing: failed (job)
  • seen on other PRs composer-row-rhythm.test.ts at 760 px (light): one gap in a group, one between groups, Send at the edge: failed (job)
  • seen on other PRs composer-row-rhythm.test.ts at 760 px (dark): one gap in a group, one between groups, Send at the edge: failed (job)
  • seen on other PRs composer-history.test.ts ↑ and ↓ in an empty prompt step through the chat's earlier prompts: failed (job)
  • ... 6 more in the job logs
Matched log lines
web / react-apps-check (4): (fail) clicking a background task's end opens its terminal beside the chat [933.17ms]
web / react-apps-check (3): (fail) @ then letters lists the chat's matching files and Return writes the path [1947.06ms]
web / react-apps-check (1): (fail) ↑ and ↓ in an empty prompt step through the chat's earlier prompts [1804.77ms]
web / react-apps-check (2): (fail) chromium > the wheel over a long draft stops at its ends and moves nothing else [4034.06ms]

Not re-run automatically: web / react-apps-check (4), web / react-apps-check (3), web / react-apps-check (1), web / react-apps-check (2), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: web / Web status; base red: the same failure on the base bb709e3; does not block
red: web / react-apps-check; base red: the same failure on the base bb709e3; does not block
red: web / react-apps-check (1); base red: the same failure on the base bb709e3; does not block
red: web / react-apps-check (2); base red: the same failure on the base bb709e3; does not block
red: web / react-apps-check (3); base red: the same failure on the base bb709e3; does not block
red: web / react-apps-check (4); base red: the same failure on the base bb709e3; does not block

Tour of 5f9e5be85c (run): no media. The tour did not run: only webview code changed (1 path(s)), which the gallery advisory run checks in Linux Chromium on the pull request (its artifact holds any captures); add the media-tour-mac label to tour it on a Mac.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-959ks created for this PR by the cmux coordinator.

@blacksmith-sh

blacksmith-sh Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Found 14 test failures on Blacksmith runners:

Failures

Test View Logs
test/agent-pane-background-tasks.test.ts/agent-pane-background-tasks.test View Logs
test/agent-pane-background-tasks.test.ts/agent-pane-background-tasks.test View Logs
test/agent-pane-wheel-pass-through.test.ts/agent-pane-wheel-pass-through.test View Logs
test/agent-pane-wheel-pass-through.test.ts/agent-pane-wheel-pass-through.test View Logs
test/composer-history.test.ts/composer-history.test View Logs
test/composer-history.test.ts/composer-history.test View Logs
test/composer-location-strip.test.ts/composer-location-strip.test View Logs
test/composer-location-strip.test.ts/composer-location-strip.test View Logs
test/composer-mention.test.ts/composer-mention.test View Logs
test/composer-mention.test.ts/composer-mention.test View Logs

...and 4 more test failures. View all on Blacksmith

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo
teamleaderleo merged commit 97c1e65 into feat-cmux-next Oct 21, 2026
@teamleaderleo
teamleaderleo deleted the cmux/layout-pass-markdown branch October 21, 2026 02:54
@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant