ci(cmux-next): web nits and CI-only changes skip the Mac tiers; a routing replay guards the router by teamleaderleo · Pull Request #18310 · manaflow-ai/cmux

teamleaderleo · 2026-10-07T08:12:16Z

Summary

Two cheap classes in cmux_next_route.py select no Mac tier. Only the Linux checks job runs here, along with ci-web or ci.yml's guards.

Web nits. A one-line CSS nit (#18296) ran the Release compile, the Debug scheme compile and swift test on minis, and a runner refusal blocked it for an hour. These files are now covered on Linux:

webviews/ sources;
the webviews app;
the agent-pane bundle (CmuxNextAgentPane/Resources/agent-pane/);
docs.

ci-web type-checks, lints and tests them. build-agent-pane-web.sh --check proves the committed bundle matches the sources, and the bundle is a .copy resource, so the app takes it without a compile. gallery-pr diffs the touched entries.

CI-only changes. These change no app code, so they now skip the Mac tiers. Before, a workflow or router change ran every tier:

.github/workflows/;
scripts/ci/;
the router;
scripts/gh-merge-green;
their Python tests.

They're checked on Linux instead:

ci.yml's guards run actionlint and the CI unit tests.
When the router changes, the new Routing replay (router changes) step runs scripts/ci/cmux_next_route_replay.py. It replays the last 30 merged PRs' changed files through the base router (HEAD^1 of the merge commit) and the PR's router. It fails on any tier the new router adds, or drops without naming a fast tier.
gh-merge-green --revert (feat(gh-merge-green): --revert rolls back a merged PR in one command #18312, landed) undoes a bad change in one command.

Files a Mac tier reads keep their tier, whatever their name. That covers:

the Xcode pins;
.github/actions/setup-cmux-tui-rust/;
daemon and cmux-tui tree inputs;
generated-file inputs;
every file a Swift test reads.

This also fixes a gap in the first web-nit commit: scripts/ci/xcode-pins.txt matched the *.txt docs pattern and would have skipped every tier.

A dev-build PR still compiles its dogfood app.

Verification

Each class went in red first:

Web: c9d98f0 (red, 3 failures), then 75c2b64 (green).
CI class and the pinned-inputs guard: d5dece0 (red, 4 failures), then 5efc36a (green).
Replay: ec27901 (red, module missing), then 5efc36a (green).

python3 -m unittest tests.test_cmux_next_route tests.test_cmux_next_route_replay tests.test_cmux_next_checks_workflow passes. actionlint passes.

Replay dry run (--base origin/feat-cmux-next --limit 30): 29 merged PRs, 0 unexplained.

19 route exactly as before.
10 drop their Mac tiers as web or CI fast-tier changes: test(webviews): keep base green on ui-rules growth from 7f67cf1a538 and eb596157723 #18317, ci: install web dependencies before the Cloud VM image lock tests #18311, cmux VM: staging on vm-staging.cmux.dev from feat-cmux-next, cross-tenant smoke, jsonb param fix #18282, fix: let the composer attachment row follow the macOS scrollers #18296, style(webviews): format gen-strings.mjs's gallery catalog entry #18253, test(webviews): list base files the ui-rules and gallery-coverage ratchets miss #18245, Agent pane: show header status only for problems #18188, gallery: agent-pane.docked-chat at the chat dock's widths #18198, Add settings and passwords gallery entries #18203 and cmux-next: align composer context and effort controls #18115. For ci: install web dependencies before the Cloud VM image lock tests #18311, a workflow-only change, the old router had picked the native and scheme tiers.

Changelog

none

🤖 Generated with Claude Code

Note

Medium Risk
Changes which merge-gate Mac jobs run on PRs; mis-routing could under-test merges, though replay, consumed(), and expanded unit tests mitigate that.

Overview
Skips Mac CI tiers for two PR classes when every changed file qualifies and nothing a Mac job reads: web nits (webviews, checked agent-pane bundles, docs) and CI-only edits (workflows, scripts/ci/, router, gh-merge-green, related tests). Linux cmux-next checks, ci-web, and ci.yml guards cover those paths instead. dev-build still runs the scheme compile for dogfood.

cmux_next_route.py adds web_fast, ci_only, and consumed so pins, tree inputs, generator inputs, and Swift test fixtures keep their tiers despite doc-like names (e.g. xcode-pins.txt).

Routing replay (cmux_next_route_replay.py): on PRs that change the router, the checks job replays the last 30 merged PRs through HEAD^1 vs the PR router and fails on tier adds, unexplained drops, or Swift target churn. Tier routing in the workflow also runs the new unit tests; docs and test-execution.toml are updated.

^{Reviewed by Cursor Bugbot for commit e6de287. Bugbot is set up for automated code reviews on this repo. Configure here.}

A one-line CSS change and its regenerated agent-pane bundle (#18296) ran the Release compile, the Debug scheme compile and swift test on minis. ci-web already checks the sources and proves the committed bundle matches them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

When a pull request changes only webviews sources, the webviews app, the agent-pane bundle or docs, and no Swift test reads those files, the router selects no Mac tier. ci-web checks the sources and the bundle's freshness, the bundle is a .copy resource, and gh-merge-green already passes skipped checks. A dev-build PR keeps its scheme compile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

coderabbitai · 2026-10-07T08:12:27Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 6c0c31e8-d4db-4fa1-b4c5-ddfc7d35acac

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

cursor

Stale Bugbot comment from a previous run.

…ep theirs A workflow, CI script, router or gh-merge-green change needs no Mac tier, but scripts/ci/xcode-pins.txt (a *.txt) and plans/cmux-next/*.md (docs by name) feed Mac tiers and must keep them, which the web fast tier's early return missed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…uards the router Workflows, scripts/ci, the router, gh-merge-green and their tests route to no Mac tier, alone or with web files. A file a Mac tier reads keeps its tier whatever its name (the Xcode pins, the cmux-tui Rust action, daemon and tree inputs, generated-file inputs, files a Swift test reads), which also closes the web fast tier's gap where scripts/ci/xcode-pins.txt and plans/cmux-next/*.md matched the docs patterns. When the router changes, the checks job replays the last 30 merged PRs through the base router and the new one and fails on any unexplained tier change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…-tier # Conflicts: # tests/test-execution.toml

cursor

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit e6de287. Configure here.}

cursor · 2026-10-07T09:02:57Z

+    for number in merged:
+        files = json.loads(subprocess.run(
+            ["gh", "api", "--paginate", f"repos/{repo}/pulls/{number}/files?per_page=100", "--jq", "[.[].filename]"],
+            check=True, capture_output=True, text=True).stdout.replace("][", ","))


Replay pagination breaks on large PRs

Medium Severity

recent_prs asks gh api --paginate for filenames as one JSON array per page, then joins pages with a ][ replace. Paginated gh --jq output is newline-separated arrays, so json.loads throws on any merged PR with more than 100 files and the routing replay fails closed. The rest of this repo already fetches those names as one path per line.

^{Reviewed by Cursor Bugbot for commit e6de287. Configure here.}

teamleaderleo and others added 2 commits October 7, 2026 01:11

teamleaderleo mentioned this pull request Oct 7, 2026

feat(gh-merge-green): --revert rolls back a merged PR in one command #18312

Merged

cursor Bot reviewed Oct 7, 2026

View reviewed changes

Comment thread scripts/ci/cmux_next_route.py

teamleaderleo and others added 3 commits October 7, 2026 01:46

test(cmux-next): a routing replay fails on any unexplained tier change

ec27901

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

teamleaderleo requested a review from lawrencecchen as a code owner October 7, 2026 08:50

teamleaderleo changed the title ~~ci(cmux-next): web nits take a fast tier with no Mac jobs~~ ci(cmux-next): web nits and CI-only changes skip the Mac tiers; a routing replay guards the router Oct 7, 2026

Merge remote-tracking branch 'origin/feat-cmux-next' into ci/web-fast…

e6de287

…-tier # Conflicts: # tests/test-execution.toml

cursor Bot reviewed Oct 7, 2026

View reviewed changes

teamleaderleo merged commit c148a9f into feat-cmux-next Oct 7, 2026
73 of 90 checks passed

teamleaderleo deleted the ci/web-fast-tier branch October 7, 2026 09:40

teamleaderleo mentioned this pull request Oct 7, 2026

ci(cmux-next): cache the web bundles by source key, restore them on the Mac jobs #18360

Merged

Navigation Menu

Repository navigation

ci(cmux-next): web nits and CI-only changes skip the Mac tiers; a routing replay guards the router - #18310

ci(cmux-next): web nits and CI-only changes skip the Mac tiers; a routing replay guards the router#18310
teamleaderleo merged 6 commits into
feat-cmux-nextfrom
ci/web-fast-tier

teamleaderleo commented Oct 7, 2026 •

edited by cursor Bot

Loading

Uh oh!

coderabbitai Bot commented Oct 7, 2026 •

edited

Loading

Review skipped

Uh oh!

cursor Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

cursor Bot Oct 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

teamleaderleo commented Oct 7, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Changelog

Uh oh!

coderabbitai Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Oct 7, 2026

Choose a reason for hiding this comment

Replay pagination breaks on large PRs

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

teamleaderleo commented Oct 7, 2026 •

edited by cursor Bot

Loading

coderabbitai Bot commented Oct 7, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading