Skip to content

cmux-next: align composer context and effort controls - #18115

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
next-composer-controls
Oct 7, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
next-composer-controls

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

The composer model control now sits before the context ring, the effort detail is a small-radius rectangle with 8px separation, and Trust asks no longer expose a hover folder preview.

Validation:

  • Added focused context order and trust tooltip coverage
  • git diff --check passed
  • Native validation is through CI and fleet

Changelog

Changed: align composer context and effort controls for a stable compact bar.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Aligns the composer bar's context and effort controls for a stable compact layout: the model chip now sits before the context ring, effort detail renders as a small rounded rectangle, and Trust asks no longer expose a folder tooltip on hover. The agent pane bundle is regenerated to match.

  • Added coverage for the chip order relative to the context ring and for the absent Trust-ask folder tooltip.

Written for commit 15e808f. Summary will update on new commits.

Review in cubic Turn on auto-fix

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 2e8991f8-c546-4986-a571-833661cc1d74

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Unclear: web / react-apps-check failed: no known signature; failed step: Test webviews.

CI failed on 15e808f11e (run 37551843700 attempt 1): 1 unknown.
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped.

Job Verdict Why
web / react-apps-check unknown no known signature; failed step: Test webviews

Not re-run automatically: web / react-apps-check is not a machine failure.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

CI attribution for the exact-head Swift test red: withTheSidebarHiddenTheStripStartsAfterTheToggle fails in StaticSidebarToggleTests.swift:95 on this PR at 52a61907e2d. The same test fails on the current feat-cmux-next base 29371b1fd54 in run 37545413691, with the same strip/toggle geometry assertion. This is base-owned and unrelated to the composer controls changes.

@teamleaderleo
teamleaderleo force-pushed the next-composer-controls branch from 52a6190 to 5667fc8 Compare October 6, 2026 23:53
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Exact-head CI audit for 5667fc806aa on base 8096756a8d2:

  • Release compile and generated files passed on the exact head.
  • withTheSidebarHiddenTheStripStartsAfterTheToggle fails at StaticSidebarToggleTests.swift:95, the same base-owned geometry failure documented from base run https://github.com/manaflow-ai/cmux/actions/runs/37545413691/job/112556590156.
  • revealTurnAsksThePageToScrollToTheTurn fails at AgentPaneActionTests.swift:75. This is in the agent-pane area changed by base commits between 29371b1fd54 and 8096756a8d2 (b3f6b60cbf5, 21936ef54a2, f3b8f4f7ed1, 9025f514b60, b0da162df35), and the composer controls diff does not touch that area.

The exact-head Swift job log is https://github.com/manaflow-ai/cmux/actions/runs/37549024133/job/112560008924. This comment is the audit record for the exact-head override check.

teamleaderleo and others added 2 commits October 6, 2026 17:24
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@teamleaderleo
teamleaderleo force-pushed the next-composer-controls branch from 5667fc8 to 15e808f Compare October 7, 2026 00:24
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Exact-head CI audit for 15e808f11ef on base 4764d5d6265:

The controls diff does not touch the sidebar test area. This comment is the audit record for the exact-head override check.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

merge-override: Exact-head Release passed; Swift red is the documented base-owned sidebar geometry failure.

@teamleaderleo
teamleaderleo merged commit 3344b54 into feat-cmux-next Oct 7, 2026
60 of 71 checks passed
@teamleaderleo
teamleaderleo deleted the next-composer-controls branch October 7, 2026 00:59
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

merge-override: Exact-head Release passed; Swift red is the documented base-owned sidebar geometry failure.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37555112268 at 2df79b5 failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at d7167cb. This pull request is one of 3 merged since: #18115, #17630, #17635.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37555118221 at ea3879d failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at d7167cb. This pull request is one of 4 merged since: #18115, #17630, #17635, #17535.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant