Repository navigation
Agent pane: show header status only for problems - #18188
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Preserve the pane name for accessibility and keep status labels out of header sizing. Retire normal status strings and regenerate the shipped web bundle. Co-Authored-By: Codex <noreply@openai.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Unclear: CI failed on
Not re-run automatically: Written by |
Co-Authored-By: Codex <noreply@openai.com>
Keep the chat pane accessible name independent of the harness and expose Changes counts only to VoiceOver. Co-Authored-By: Codex <noreply@openai.com>
|
Found 2 test failures on Blacksmith runners: Failures
|
Removes the repeated title and normal connection/turn status from the agent pane header. Disconnected, retrying after a failure, and failed states show a muted icon label with details in a tooltip. The status slot cannot resize the right-side tools, and the pane keeps the chat title as its accessible name.
The gallery directory is absent on this base. Includes regenerated agent-pane HTML, JavaScript, and all 21 locale bundles. Related: #18152 removes the title only; this follows the lead’s broader problem-only status decision on the assigned branch.
Changelog
Fixed: Removed redundant agent chat header text while keeping connection problems and the pane’s accessible name.
Validation
3109b8f403bf:cd webviews && bun test src/agent-session/acpmux/transcript.test.tsx --test-name-pattern 'agent pane header'— 9 expected failures.scripts/cmux-next/check-l10n.sh: 94 tables, 21 languages, 0 errors. Agent-pane catalog/generated-key audit passed for all 21 locales; retired status keys removed.localize-changeshas no outstanding changed translation rows, but its strict global validator fails on the existing translation backlog.verify-local.pyfound existing localization, localization-default mismatch, and workspace-package-group failures before the fix.The selected design was provided by the lead; no alternate variants or new settings/actions were added.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Removes the repeated title, normal connection status, and changes counts from the agent pane header, showing status only when the agent is disconnected, retrying after a failure, or failed. Problem details remain in a tooltip; the chat title stays as the pane's accessible name, and changes counts are exposed only to VoiceOver.
Written for commit 98c4283. Summary will update on new commits.
Note
Low Risk
UI and string-catalog changes only; connection logic is unchanged. Accessibility relies on the shell aria-label instead of visible header title text.
Overview
The agent pane header no longer shows the chat title or routine connection/working labels during normal operation. Problem-only status appears for disconnected, reconnecting (after errors), and failed connections: a muted icon plus short label, with fuller detail in a tooltip. The status area is laid out so it does not push or resize the right-side header tools, and the session title remains the pane’s accessible name via
aria-labelon the shell.Localization is updated across all agent-pane locale bundles: retired keys such as
header.connecting,header.working, andheader.mockare removed in favor ofheader.disconnectedandheader.failed, withheader.reconnectingkept for retry states. Generated web assets and transcript header tests are aligned with the new behavior.Reviewed by Cursor Bugbot for commit 98c4283. Bugbot is set up for automated code reviews on this repo. Configure here.