Skip to content

Agent pane: show header status only for problems - #18188

Merged
lawrencecchen merged 4 commits into
feat-cmux-nextfrom
feat-hq5c-header-title
Oct 7, 2026
Merged

lawrencecchen merged 4 commits into
feat-cmux-nextfrom
feat-hq5c-header-title

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Removes the repeated title and normal connection/turn status from the agent pane header. Disconnected, retrying after a failure, and failed states show a muted icon label with details in a tooltip. The status slot cannot resize the right-side tools, and the pane keeps the chat title as its accessible name.

The gallery directory is absent on this base. Includes regenerated agent-pane HTML, JavaScript, and all 21 locale bundles. Related: #18152 removes the title only; this follows the lead’s broader problem-only status decision on the assigned branch.

Changelog

Fixed: Removed redundant agent chat header text while keeping connection problems and the pane’s accessible name.

Validation

  • Red commit 3109b8f403bf: cd webviews && bun test src/agent-session/acpmux/transcript.test.tsx --test-name-pattern 'agent pane header' — 9 expected failures.
  • Same focused command after the fix: 9 passed.
  • Transcript, model, header-tools, harness-switch, and i18n suites: 117 passed in jsdom/pure unit tests.
  • Webviews typecheck, lint, and fmt check passed.
  • scripts/cmux-next/check-l10n.sh: 94 tables, 21 languages, 0 errors. Agent-pane catalog/generated-key audit passed for all 21 locales; retired status keys removed. localize-changes has no outstanding changed translation rows, but its strict global validator fails on the existing translation backlog.
  • Agent-pane web bundle regenerated and checked.
  • Initial verify-local.py found existing localization, localization-default mismatch, and workspace-package-group failures before the fix.
  • No Playwright, browser test runner, cargo, zig, xcodebuild, or swift test was run. Visual layout and VoiceOver are not dogfood-verified.

The selected design was provided by the lead; no alternate variants or new settings/actions were added.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Removes the repeated title, normal connection status, and changes counts from the agent pane header, showing status only when the agent is disconnected, retrying after a failure, or failed. Problem details remain in a tooltip; the chat title stays as the pane's accessible name, and changes counts are exposed only to VoiceOver.

  • Keeps the status and changes slots from resizing the header's right-side tools.
  • Updates tests, generated web assets, and all 21 locale bundles.

Written for commit 98c4283. Summary will update on new commits.

Review in cubic Turn on auto-fix


Note

Low Risk
UI and string-catalog changes only; connection logic is unchanged. Accessibility relies on the shell aria-label instead of visible header title text.

Overview
The agent pane header no longer shows the chat title or routine connection/working labels during normal operation. Problem-only status appears for disconnected, reconnecting (after errors), and failed connections: a muted icon plus short label, with fuller detail in a tooltip. The status area is laid out so it does not push or resize the right-side header tools, and the session title remains the pane’s accessible name via aria-label on the shell.

Localization is updated across all agent-pane locale bundles: retired keys such as header.connecting, header.working, and header.mock are removed in favor of header.disconnected and header.failed, with header.reconnecting kept for retry states. Generated web assets and transcript header tests are aligned with the new behavior.

Reviewed by Cursor Bugbot for commit 98c4283. Bugbot is set up for automated code reviews on this repo. Configure here.

lawrencecchen and others added 2 commits October 6, 2026 19:46
Co-Authored-By: Codex <noreply@openai.com>
Preserve the pane name for accessibility and keep status labels out of header sizing. Retire normal status strings and regenerate the shipped web bundle.

Co-Authored-By: Codex <noreply@openai.com>
@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 449d612d-760a-4afd-9aad-945a6973fce5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Unclear: web / react-apps-check failed: no known signature; failed step: Test webviews.

CI failed on 98c4283caa (run 37568257687 attempt 1): 1 unknown.
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped.

Job Verdict Why
web / react-apps-check unknown no known signature; failed step: Test webviews

Not re-run automatically: web / react-apps-check is not a machine failure.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

lawrencecchen and others added 2 commits October 6, 2026 20:43
Co-Authored-By: Codex <noreply@openai.com>
Keep the chat pane accessible name independent of the harness and expose Changes counts only to VoiceOver.

Co-Authored-By: Codex <noreply@openai.com>
@blacksmith-sh

blacksmith-sh Bot commented Oct 7, 2026

Copy link
Copy Markdown

Found 2 test failures on Blacksmith runners:

Failures

Test View Logs
test_every_source_and_test_directory_is_a_target (main.GraphCoversThePackage.test_e
very_source_and_test_directory_is_a_target) (directory='CmuxNextRemoteBrowser')/
test_every_source_and_test_directory_is_a_target (main.GraphCoversThePackage.test_e
very_source_and_test_directory_is_a_target) (directory='CmuxNextRemoteBrowser')
View Logs
test_every_source_and_test_directory_is_a_target (main.GraphCoversThePackage.test_e
very_source_and_test_directory_is_a_target) (directory='CmuxNextRemoteBrowserTests')/
test_every_source_and_test_directory_is_a_target (main.GraphCoversThePackage.test_e
very_source_and_test_directory_is_a_target) (directory='CmuxNextRemoteBrowserTests')
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@lawrencecchen
lawrencecchen merged commit c3b75c3 into feat-cmux-next Oct 7, 2026
79 of 94 checks passed
@lawrencecchen
lawrencecchen deleted the feat-hq5c-header-title branch October 7, 2026 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant