Repository navigation
gallery: agent-pane.docked-chat at the chat dock's widths - #18198
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Passes: CI passes on CI passes on Written by |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37567938071 at f43f800 failed: cmux-next checks (god files, concurrency, crash safety, l10n). |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37567471217 at 2a1b504 failed: cmux-next checks (god files, concurrency, crash safety, l10n), cmux-next generated files. |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37568316271 at 169c1da failed: cmux-next checks (god files, concurrency, crash safety, l10n). |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37568445230 at 3c11c5a failed: cmux-next checks (god files, concurrency, crash safety, l10n). |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37568512187 at e8aa5c1 failed: cmux-next checks (god files, concurrency, crash safety, l10n). |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37569422881 at 552e7cb failed: cmux-next checks (god files, concurrency, crash safety, l10n). |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37569270312 at f60b3d7 failed: cmux-next checks (god files, concurrency, crash safety, l10n), cmux-next generated files. |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37569941713 at 46215de failed: cmux-next checks (god files, concurrency, crash safety, l10n). |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37569551101 at 5976099 failed: cmux-next checks (god files, concurrency, crash safety, l10n), cmux-next generated files. |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37570246034 at e8a5696 failed: cmux-next checks (god files, concurrency, crash safety, l10n). |
Summary
Adds the gallery entry
agent-pane.docked-chat: the whole agent pane at the left chat dock's widths. The chat dock (a dock column with theagent_chatrole, #18169 and #18170) takes 25-40% of the content area, so the entry's widths are that share of a 1200 px window (300, 400 and 480 px) rather than the pane presets.Variants (static states only; post-click states wait for the play-step runner):
new-chat: an empty prompt and the location row at dock width.after-turn: a finished turn with tool rows.working: a running turn, with Stop in place of Send.long-title: a long chat title in the header.It covers
page:cmux.agentandApp.tsx#AcpmuxApp, whichagent-pane.transcriptalready covers. No exported component is unique to the dock, so the coverage allowlist doesn't change.Testing
Not run locally: this lane runs no bun commands on the dev machine. CI's webviews jobs run
test/gallery-coverage.test.tsand the typecheck on this PR. The fixtures use only the existing builders ingallery/fixtures/acpmux.ts, with the same fields asagent-pane.composerandagent-pane.transcript.User-facing strings: none (gallery fixtures,
l10n-allow-file).Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Adds the gallery entry
agent-pane.docked-chat, showing the whole agent pane at the left chat dock's widths (300, 400, and 480 px) instead of the pane presets.Variants cover an empty new chat, a finished turn with tool rows, a running turn with Stop in place of Send, and a long title in the header. Reuses the existing
acpmuxfixtures andagent-pane.transcript's coverage; no exported component changes.Written for commit 4945500. Summary will update on new commits.
Note
Low Risk
Gallery-only fixture file with no shipped UI or runtime behavior changes.
Overview
Adds a new webviews gallery entry
agent-pane.docked-chatso the agent pane can be previewed at left chat dock widths (300 / 400 / 480 px for narrow–wide), instead of the usual pane presets.The entry reuses existing
acpmuxfixture builders and declares the same coverage asagent-pane.transcript(page:cmux.agent,AcpmuxApp). Four static variants document dock layout: new chat, after-turn (tools + transcript wrapping), working (Stop vs Send), and long-title header truncation.Reviewed by Cursor Bugbot for commit 4945500. Bugbot is set up for automated code reviews on this repo. Configure here.