cmux VM: staging on vm-staging.cmux.dev from feat-cmux-next, cross-tenant smoke, jsonb param fix by lawrencecchen · Pull Request #18282 · manaflow-ai/cmux

lawrencecchen · 2026-10-07T06:53:07Z

Deploys the cmux VM staging Worker from feat-cmux-next and proves tenant isolation live.

.github/workflows/cmux-vm.yml: staging deploy and smoke run on push to feat-cmux-next (and main), plus a deploy-staging dispatch action that runs check first.
wrangler.jsonc: staging is the Workers custom domain vm-staging.cmux.dev (workers.dev off). Production gets the route vm.cmux.dev, which attaches on its first deploy. The OpenAPI servers use the new hosts (CMUX-VM-API amendment 2).
scripts/smoke.ts: with CMUX_VM_SMOKE_API_KEY_B, a second tenant must get 404 on GET, exec, pause, stop, fork and delete of the first tenant's VM, and must not see it in its list.
Bug fix: every create failed with 503 on a real Postgres. postgres.js serializes a jsonb-typed parameter with JSON.stringify, and the stores passed JSON strings, so labels were stored as a jsonb string and broke resources_labels_check (SQLSTATE 23514). The JSON parameters now cast $n::text::jsonb. PGlite in the tests does not show this behavior.
Failed store queries now log the operation and SQLSTATE. Failed provider calls log the operation and HTTP status. The logs never include ids, parameters, bodies or messages.

Spec note: decisions.md line 1008 says staging Workers have no Freestyle secret. The chief decided (2026-10-07) to give staging the cmux-next dev Freestyle key, on the shared account, with deletes only by exact id. The chief will amend decisions.md.

Evidence: run https://github.com/manaflow-ai/cmux/actions/runs/37583690978 at 7dabdcf. It contains feat-cmux-next 4d8998d. check, deploy-staging and smoke-staging all passed on https://vm-staging.cmux.dev. The smoke VM was deleted by its exact id.

Not done: the SDK DEFAULT_BASE_URL and the Rust client/CLI default still name vm.cmux.com. Those files are generated, so the S4 owner regenerates them.

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

Summary by cubic

Deploys the cmux VM staging Worker from feat-cmux-next to vm-staging.cmux.dev and proves tenant isolation live with a cross-tenant smoke run. Also fixes a jsonb parameter bug that failed every create with 503 on real Postgres.

Staging deploy

CI deploys and smokes staging on push to feat-cmux-next or main, plus a deploy-staging dispatch action that runs check first.
Staging moves from workers.dev to the custom domain vm-staging.cmux.dev; production attaches vm.cmux.dev on its first deploy.
A second smoke tenant must get 404 for every read and mutation on the first tenant's VM and must not see it in its list.
Upstream resources are now named cmux-vm-<environment> <tenant> <cmux id> so resources on the shared provider account are attributable to this service.

Bug fix

postgres.js serializes jsonb-typed parameters with JSON.stringify, so labels were stored as a jsonb string and every create failed resources_labels_check (SQLSTATE 23514). JSON parameters now cast $n::text::jsonb.
Failed store queries log the operation and SQLSTATE; failed provider calls log the operation and HTTP status. Logs never include ids, parameters, bodies, or messages.

^{Written for commit bdb097c. Summary will update on new commits.}

Note

Medium Risk
Changes staging deploy triggers, custom domains, and a data-layer jsonb binding fix that unblocks creates on real Postgres; cross-tenant smoke increases confidence in isolation but touches CI secrets and live staging.

Overview
Staging deploy and live tenant isolation. CI now deploys and smokes the cmux VM staging Worker on push to feat-cmux-next or main, adds a manual deploy-staging workflow dispatch (runs check first), and wires staging to the custom domain vm-staging.cmux.dev (workers_dev off; production route vm.cmux.dev is declared for first prod deploy).

Cross-tenant smoke. When CMUX_VM_SMOKE_API_KEY_B is set, scripts/smoke.ts asserts a second tenant gets 404 on every read/mutation against the first tenant's VM and never sees it in list.

Postgres jsonb fix. JSON bind parameters now cast as $n::text::jsonb across stores so real Postgres/Hyperdrive does not double-encode labels and fail resources_labels_check (staging was 503 on every create).

Upstream naming and ops logging. Provider display names use cmux-vm-<environment> <tenant> <id> via naming.ts. Failed DB queries log operation + SQLSTATE; failed upstream calls log operation + HTTP status, without ids or secrets.

^{Reviewed by Cursor Bugbot for commit bdb097c. Bugbot is set up for automated code reviews on this repo. Configure here.}

…enant smoke Staging deploys and smokes on push to feat-cmux-next (and main), plus a deploy-staging dispatch action that runs check first. Staging answers on workers.dev until its hostname is chosen. smoke.ts takes an optional second tenant key and requires 404 for every call that tenant makes on the first tenant's VM, and no leak in its list.

A create that failed answered 503 with nothing in the Worker logs. Failed queries now log their operation and SQLSTATE, failed provider calls their operation and HTTP status; never ids, parameters, bodies or messages.

…m-stgdeploy

postgres.js serializes a parameter the server types as jsonb with JSON.stringify. The stores pass JSON strings, so labels were stored as a jsonb string and every create on staging failed resources_labels_check (SQLSTATE 23514, now visible in the Worker log). Casting $n::text::jsonb makes the parameter text, which the driver passes as is.

Workers custom domains in the cmux.dev zone (CMUX-VM-API amendment 2). Staging leaves workers.dev; production attaches its domain on its first deploy. The OpenAPI servers name the new hosts.

coderabbitai · 2026-10-07T06:53:17Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: ddfe0486-4062-43b0-8407-b7ed5aa31571

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

The provider account is shared, so resources this service creates are now named cmux-vm-<environment> <tenant> <cmux id> (VMs, snapshots, fork snapshots, networks, tunnels). The environment comes from ENVIRONMENT at the composition root and is required by every upstream client.

…m-stgdeploy

github-actions · 2026-10-07T07:22:35Z

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37586437879 at a16b9e0 failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at 86c2c3b. This pull request is one of 1 merged since: #18282.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

github-actions · 2026-10-07T07:23:40Z

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37586751376 at 5107871 failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at 86c2c3b. This pull request is one of 1 merged since: #18282.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

lawrencecchen · 2026-10-07T07:25:17Z

Landed on feat-cmux-next by safe-push as a merge: bdb097c (this PR plus the environment name prefix), then e3c0c61 (custom domains attached through the Workers domains API, because wrangler routes needed a zone permission the token lacks). Push-triggered staging deploy and smoke on e3c0c61: https://github.com/manaflow-ai/cmux/actions/runs/37586997717 (all passed on https://vm-staging.cmux.dev, including the tenant B 404 checks).

github-actions · 2026-10-07T07:25:20Z

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37586913855 at e4da892 failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at 86c2c3b. This pull request is one of 1 merged since: #18282.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

github-actions · 2026-10-07T07:25:47Z

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37586965300 at 8b1c329 failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at 86c2c3b. This pull request is one of 1 merged since: #18282.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

github-actions · 2026-10-07T07:27:15Z

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37587042315 at 6a753c9 failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at 86c2c3b. This pull request is one of 3 merged since: #18282, #18152, #18229.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

github-actions · 2026-10-07T07:35:48Z

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37587935376 at a53b04b failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at 86c2c3b. This pull request is one of 3 merged since: #18282, #18152, #18229.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

github-actions · 2026-10-07T07:37:54Z

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37588003146 at b472aa1 failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at 86c2c3b. This pull request is one of 3 merged since: #18282, #18152, #18229.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

github-actions · 2026-10-07T07:39:10Z

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37587147561 at 9ec0d03 failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at fa75842. This pull request is one of 4 merged since: #18282, #18147, #18152, #18229.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

github-actions · 2026-10-07T07:40:49Z

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37588244794 at 8eee20c failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at 86c2c3b. This pull request is one of 3 merged since: #18282, #18152, #18229.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

github-actions · 2026-10-07T08:27:58Z

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37586861355 at 8d69556 failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at 29371b1. This pull request is one of 2 merged since: #18282, #18147.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

lawrencecchen added 5 commits October 6, 2026 23:15

Merge remote-tracking branch 'origin/feat-cmux-next' into feat-cmux-v…

473edfc

…m-stgdeploy

cmux VM: staging on vm-staging.cmux.dev, production route vm.cmux.dev

7dabdcf

Workers custom domains in the cmux.dev zone (CMUX-VM-API amendment 2). Staging leaves workers.dev; production attaches its domain on its first deploy. The OpenAPI servers name the new hosts.

lawrencecchen added 2 commits October 6, 2026 23:54

Merge origin/feat-cmux-next into feat-cmux-vm-stgdeploy

cad3523

lawrencecchen deployed to cmux-vm-preview October 7, 2026 06:57 — with GitHub Actions Active

Merge remote-tracking branch 'origin/feat-cmux-next' into feat-cmux-v…

bdb097c

…m-stgdeploy

lawrencecchen deployed to cmux-vm-preview October 7, 2026 07:12 — with GitHub Actions Active

lawrencecchen merged commit bdb097c into feat-cmux-next Oct 7, 2026
68 of 69 checks passed

lawrencecchen deleted the feat-cmux-vm-stgdeploy branch October 7, 2026 07:14

lawrencecchen had a problem deploying to cmux-vm-staging October 7, 2026 07:15 — with GitHub Actions Failure

This was referenced Oct 7, 2026

fix(cmux-next): remove redundant agent pane header label #18152

Merged

next: password import conflict count and Firefox consent text #18229

Merged

github-actions Bot mentioned this pull request Oct 7, 2026

fix(cmux-next): make inherited UI tests deterministic #18147

Merged

teamleaderleo mentioned this pull request Oct 7, 2026

ci(cmux-next): web nits and CI-only changes skip the Mac tiers; a routing replay guards the router #18310

Merged

Conversation

lawrencecchen commented Oct 7, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by cubic

Uh oh!

coderabbitai Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Uh oh!

github-actions Bot commented Oct 7, 2026

Uh oh!

github-actions Bot commented Oct 7, 2026

Uh oh!

lawrencecchen commented Oct 7, 2026

Uh oh!

github-actions Bot commented Oct 7, 2026

Uh oh!

github-actions Bot commented Oct 7, 2026

Uh oh!

github-actions Bot commented Oct 7, 2026

Uh oh!

github-actions Bot commented Oct 7, 2026

Uh oh!

github-actions Bot commented Oct 7, 2026

Uh oh!

github-actions Bot commented Oct 7, 2026

Uh oh!

github-actions Bot commented Oct 7, 2026

Uh oh!

github-actions Bot commented Oct 7, 2026

Uh oh!

This branch had an error being deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

lawrencecchen commented Oct 7, 2026 •

edited by cursor Bot

Loading

coderabbitai Bot commented Oct 7, 2026 •

edited

Loading