Repository navigation
test(webviews): list base files the ui-rules and gallery-coverage ratchets miss - #18245
Conversation
…chets miss feat-cmux-next is red on both: optchat-inspector (App.tsx 2, Term.tsx 1), dev-host/host.ts, gallery/frame/liveErrors.ts and acpmux EditedFilesCard.tsx landed with raw roles, key handlers or portals outside ui-rules.pending.json, and OrderedChoicesEditor has no gallery entry or allowlist line. Pending entries hold today's counts, which may only go down. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Unclear: CI failed on
Not re-run automatically: Written by |
Summary
web / react-apps-checkfails two ratchet tests on feat-cmux-next itself (seen on #18184 at bb95cea, base e41c1c1). Neither involves #18184's files.ui-rules.pending.jsonentry:optchat-inspector/App.tsx(2 raw tab roles)optchat-inspector/Term.tsx(tooltip role)dev-host/host.ts(keydown listener)gallery/frame/liveErrors.ts(portal)agent-session/acpmux/conversation/EditedFilesCard.tsx(alertdialog role)pages/settings/editors/OrderedChoicesEditor.tsx#OrderedChoicesEditorhas no entry and no allowlist line.This lists them with today's counts, the ratchet's own mechanism: a count may only go down, and migrating a file deletes its line. Existing entries keep their order. The owners still migrate these files to
src/uiand add the gallery entry; this only stops the base red from failing every web PR.Testing
role="tablist"inoptchat-inspector/App.tsx), and none of those files is inui-rules.pending.jsonor the allowlist there. cmux-next: move Changes into the Sources popover #18184's react-apps-check log shows exactly these 6 ui-rules lines and the one gallery-coverage miss.web / react-apps-checkruns both tests on Blacksmith. Web tests aren't run on dev machines.SummaryButton.test.tsxlost the base file'srequestAnimationFrameandcancelAnimationFramestubs. Reported to its lane.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Lists base
webviewsfiles the ui-rules and gallery-coverage ratchets currently miss, soweb / react-apps-checkstops failing onfeat-cmux-nextitself.ui-rules.pending.jsonentries and 1 gallery-coverage allowlist line with today's violation counts.Written for commit a70ec82. Summary will update on new commits.
Note
Low Risk
Test-only JSON ratchet updates with no runtime or product behavior changes.
Overview
Updates webviews ratchet baselines so
web / react-apps-checkstops failing on pre-existing violations on the base branch.Adds
OrderedChoicesEditortogallery-coverage.allowlist.jsonso the gallery-coverage test accepts a component that has no gallery entry yet.Adds six files to
ui-rules.pending.jsonwith current violation counts (EditedFilesCard,dev-host/host.ts,gallery/frame/liveErrors.ts,optchat-inspector/App.tsx,optchat-inspector/Term.tsx). Counts can only decrease per the ratchet; this does not fix the underlying a11y/UI-rule issues—only records them so new PRs are not blocked.Reviewed by Cursor Bugbot for commit a70ec82. Bugbot is set up for automated code reviews on this repo. Configure here.