Skip to content

test(webviews): list base files the ui-rules and gallery-coverage ratchets miss - #18245

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
ci/webviews-base-ui-rules
Oct 7, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
ci/webviews-base-ui-rules

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

web / react-apps-check fails two ratchet tests on feat-cmux-next itself (seen on #18184 at bb95cea, base e41c1c1). Neither involves #18184's files.

  • ui rules: 6 violations in files that landed without a ui-rules.pending.json entry:
    • optchat-inspector/App.tsx (2 raw tab roles)
    • optchat-inspector/Term.tsx (tooltip role)
    • dev-host/host.ts (keydown listener)
    • gallery/frame/liveErrors.ts (portal)
    • agent-session/acpmux/conversation/EditedFilesCard.tsx (alertdialog role)
  • gallery coverage: pages/settings/editors/OrderedChoicesEditor.tsx#OrderedChoicesEditor has no entry and no allowlist line.

This lists them with today's counts, the ratchet's own mechanism: a count may only go down, and migrating a file deletes its line. Existing entries keep their order. The owners still migrate these files to src/ui and add the gallery entry; this only stops the base red from failing every web PR.

Testing

  • The red is on feat-cmux-next's own files. Each violating line is on the base tip (for example role="tablist" in optchat-inspector/App.tsx), and none of those files is in ui-rules.pending.json or the allowlist there. cmux-next: move Changes into the Sources popover #18184's react-apps-check log shows exactly these 6 ui-rules lines and the one gallery-coverage miss.
  • This PR's web / react-apps-check runs both tests on Blacksmith. Web tests aren't run on dev machines.
  • cmux-next: move Changes into the Sources popover #18184's other 53 failures are its own: its SummaryButton.test.tsx lost the base file's requestAnimationFrame and cancelAnimationFrame stubs. Reported to its lane.

Changelog

none

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Lists base webviews files the ui-rules and gallery-coverage ratchets currently miss, so web / react-apps-check stops failing on feat-cmux-next itself.

  • Adds 5 ui-rules.pending.json entries and 1 gallery-coverage allowlist line with today's violation counts.
  • The ratchet only allows counts to go down; migrating a file removes its line, so existing entries keep their order.

Written for commit a70ec82. Summary will update on new commits.

Review in cubic Turn on auto-fix


Note

Low Risk
Test-only JSON ratchet updates with no runtime or product behavior changes.

Overview
Updates webviews ratchet baselines so web / react-apps-check stops failing on pre-existing violations on the base branch.

Adds OrderedChoicesEditor to gallery-coverage.allowlist.json so the gallery-coverage test accepts a component that has no gallery entry yet.

Adds six files to ui-rules.pending.json with current violation counts (EditedFilesCard, dev-host/host.ts, gallery/frame/liveErrors.ts, optchat-inspector/App.tsx, optchat-inspector/Term.tsx). Counts can only decrease per the ratchet; this does not fix the underlying a11y/UI-rule issues—only records them so new PRs are not blocked.

Reviewed by Cursor Bugbot for commit a70ec82. Bugbot is set up for automated code reviews on this repo. Configure here.

…chets miss

feat-cmux-next is red on both: optchat-inspector (App.tsx 2, Term.tsx 1),
dev-host/host.ts, gallery/frame/liveErrors.ts and acpmux EditedFilesCard.tsx
landed with raw roles, key handlers or portals outside ui-rules.pending.json,
and OrderedChoicesEditor has no gallery entry or allowlist line. Pending
entries hold today's counts, which may only go down.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 5cbe7f67-ecc6-4e5c-9627-2d46a0ab1e27

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Unclear: web / react-apps-check failed: no known signature; failed step: Test webviews.

CI failed on a70ec82544 (run 37576538560 attempt 1): 1 unknown.

Job Verdict Why
web / react-apps-check unknown no known signature; failed step: Test webviews

Not re-run automatically: web / react-apps-check is not a machine failure.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@teamleaderleo
teamleaderleo merged commit b03d18e into feat-cmux-next Oct 7, 2026
48 of 50 checks passed
@teamleaderleo
teamleaderleo deleted the ci/webviews-base-ui-rules branch October 7, 2026 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant