Repository navigation
Add settings and passwords gallery entries - #18203
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37570246034 at e8a5696 failed: cmux-next checks (god files, concurrency, crash safety, l10n). |
Settings and Passwords now have full-page gallery entries backed by their existing mock providers through cmuxPage. Settings has 95 variants across all 11 sections, customized control groups, pickers, profile/account forms, errors and long lists. Passwords has 27 variants for its three lists, entry editing, loading, empty, authentication errors and native-operation outcomes.
Coverage increases from 46/283 to 88/283 components and from 3/13 to 5/13 pages. Other lanes' allowlist entries remain unchanged.
This branch has no React password import, conflict-review or vault-lock screen. The locked fixture shows the real authentication-failure notice. Native reveal, delete and export sheets are represented by their page outcomes; the gallery does not recreate those sheets.
Testing
bun run gallery:build.Changelog
none
Proof
Internal gallery fixtures only. The interaction checks use jsdom and the real React pages; visual capture was explicitly excluded from this task.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Adds full-page gallery entries for the Settings (95 variants across all 11 sections) and Passwords (27 variants) pages, driven by their existing mock providers through cmuxPage. Gallery coverage rises from 46/283 to 88/283 components and from 3/13 to 5/13 pages; other lanes' allowlist entries are unchanged.
stepsdrive the real controls through DOM events and fail the stage if a form never appears.Written for commit 51a3bf1. Summary will update on new commits.