Skip to content

Add settings and passwords gallery entries - #18203

Merged
lawrencecchen merged 1 commit into
feat-cmux-nextfrom
feat-hq5c-gallery-settings
Oct 7, 2026
Merged

lawrencecchen merged 1 commit into
feat-cmux-nextfrom
feat-hq5c-gallery-settings

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Settings and Passwords now have full-page gallery entries backed by their existing mock providers through cmuxPage. Settings has 95 variants across all 11 sections, customized control groups, pickers, profile/account forms, errors and long lists. Passwords has 27 variants for its three lists, entry editing, loading, empty, authentication errors and native-operation outcomes.

Coverage increases from 46/283 to 88/283 components and from 3/13 to 5/13 pages. Other lanes' allowlist entries remain unchanged.

This branch has no React password import, conflict-review or vault-lock screen. The locked fixture shows the real authentication-failure notice. Native reveal, delete and export sheets are represented by their page outcomes; the gallery does not recreate those sheets.

Testing

  • Passed webviews typecheck, lint and formatting check with pipefail.
  • Passed gallery coverage, environment, theme, settings/passwords fixture interaction and pane-English tests: 141 tests.
  • Built the static gallery once with bun run gallery:build.
  • Localization audit found zero new or changed message keys. Repository-wide localization validation remains red on existing catalog parity errors; the general preflight also reports existing localization-default and workspace-package-grouping failures.
  • Browser and visual verification were not run, as requested. No Playwright, Chrome, cargo, zig, xcodebuild or swift test ran.

Changelog

none

Proof

Internal gallery fixtures only. The interaction checks use jsdom and the real React pages; visual capture was explicitly excluded from this task.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Adds full-page gallery entries for the Settings (95 variants across all 11 sections) and Passwords (27 variants) pages, driven by their existing mock providers through cmuxPage. Gallery coverage rises from 46/283 to 88/283 components and from 3/13 to 5/13 pages; other lanes' allowlist entries are unchanged.

  • Settings fixtures cover every section with customized control groups, pickers, profile/account forms, errors, and long lists; steps drive the real controls through DOM events and fail the stage if a form never appears.
  • Passwords fixtures cover the three lists, entry editing, loading, empty, authentication errors, and native-operation outcomes. There is no React import/conflict-review or vault-lock screen; the locked fixture shows the real authentication-failure notice, and reveal/delete/export sheets remain native.
  • 141 interaction, coverage, environment, theme, and pane-language tests passed; the static gallery builds. No browser or visual verification was run. L10n adds zero new keys; existing repo-wide validation failures are unchanged.

Written for commit 51a3bf1. Summary will update on new commits.

Review in cubic Turn on auto-fix

Co-Authored-By: Codex <noreply@openai.com>
@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lawrencecchen
lawrencecchen merged commit 513ca3c into feat-cmux-next Oct 7, 2026
45 checks passed
@lawrencecchen
lawrencecchen deleted the feat-hq5c-gallery-settings branch October 7, 2026 04:10
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37570246034 at e8a5696 failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at 86019f6. This pull request is one of 5 merged since: #18105, #18203, #18198, #18165, #18205.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant