Skip to content

fix: let the composer attachment row follow the macOS scrollers - #18296

Merged
lawrencecchen merged 2 commits into
feat-cmux-nextfrom
fix/composer-attachments-scrollbar
Oct 7, 2026
Merged

lawrencecchen merged 2 commits into
feat-cmux-nextfrom
fix/composer-attachments-scrollbar

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The composer's attachment row (composerAttachments.css) hid its scroller with scrollbar-width: none. check-scrollbars.sh rejects that (SCROLLBARS-FOLLOW-MACOS), so "Scrollbars follow macOS" in the cmux-next checks job is red on every PR based on feat-cmux-next.

This drops the rule. The row keeps overflow-x: auto, so with the default overlay scrollers it looks the same at rest. A scroller appears only while the row scrolls, or always when the user picked "Always" in System Settings, which is what the spec asks for.

Verification

  • Red on base 8776bb4: bash scripts/cmux-next/check-scrollbars.sh . prints composerAttachments.css:23: scrollbar-width makes a custom scrollbar and exits 1.
  • Green on this head: the same command prints check-scrollbars: ok and exits 0.
  • The committed agent-pane bundle (CmuxNextAgentPane/Resources/agent-pane/index.html) inlines this CSS verbatim, so it drops the same line; build-agent-pane-web.sh --check was red on 30e4a79 ("index.html is stale") and is checked again on 67951bb.
  • Web tests were not run locally (CSS-only change); hosted CI covers them.

Changelog

none

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Removes the hidden scrollbar on the composer attachment row so the Scrollbars follow macOS check passes. With default overlay scrollers the row looks the same at rest; a scroller appears only while scrolling, or always when the user chose "Always" in System Settings. The compiled agent-pane bundle drops the same line so the build check stays current.

Written for commit 67951bb. Summary will update on new commits.

Review in cubic Turn on auto-fix


Note

Low Risk
CSS-only tweak to attachment-row scrollbar visibility with no auth, data, or API impact.

Overview
Removes scrollbar-width: none from the composer attachment row styles so horizontal scrolling follows macOS overlay scrollbar behavior instead of hiding the scroller.

The change is applied in composerAttachments.css and the mirrored styles in the macOS agent-pane bundle. overflow-x: auto is unchanged, so the row should look the same at rest with default overlay scrollbars; a scroller shows while scrolling or when the user has “Always” scrollbars in System Settings. This aligns the UI with check-scrollbars.sh (SCROLLBARS-FOLLOW-MACOS) so the cmux-next scrollbars check can pass.

Reviewed by Cursor Bugbot for commit 67951bb. Bugbot is set up for automated code reviews on this repo. Configure here.

The attachment row hid its scroller with scrollbar-width: none, which
check-scrollbars.sh rejects (SCROLLBARS-FOLLOW-MACOS) and which turned the
Scrollbars follow macOS check red on feat-cmux-next. With the default overlay
scrollers the row looks the same at rest; a scroller shows only while it
scrolls, or always when the user chose "Always".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: f11ce10e-e055-45ab-bf7c-8b344bd90a6c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Unclear: web / react-apps-check failed: no known signature; failed step: Test webviews.

CI failed on 67951bb2f0 (run 37588214371 attempt 1): 1 unknown.
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped.

Job Verdict Why
web / react-apps-check unknown no known signature; failed step: Test webviews

Not re-run automatically: web / react-apps-check is not a machine failure.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

build-agent-pane-web.sh concatenates composerAttachments.css into the
committed index.html verbatim, so the bundle drops the same line and
build-agent-pane-web.sh --check stays current.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@lawrencecchen

Copy link
Copy Markdown
Contributor

Coordinator merge: removes the two scrollbar-width: none lines that broke check-scrollbars (SCROLLBARS-FOLLOW-MACOS) on feat-cmux-next since dd97e43, which cancels the hourly Release compile and blocks nightly-next. The red web/react-apps-check is a base React Compiler report in other acpmux files, unrelated to this two-line CSS deletion.

@lawrencecchen
lawrencecchen merged commit 110780c into feat-cmux-next Oct 7, 2026
73 of 82 checks passed
@lawrencecchen
lawrencecchen deleted the fix/composer-attachments-scrollbar branch October 7, 2026 07:38
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Gallery

No state changed

Diff page and renders (the run's gallery-pr artifact)

196 unchanged · base 8776bb4 · head 67951bb

teamleaderleo added a commit that referenced this pull request Oct 7, 2026
…ting replay guards the router (#18310)

* test(cmux-next): a web nit routes to no Mac tier

A one-line CSS change and its regenerated agent-pane bundle (#18296) ran the
Release compile, the Debug scheme compile and swift test on minis. ci-web
already checks the sources and proves the committed bundle matches them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* ci(cmux-next): web nits take the fast tier and skip every Mac job

When a pull request changes only webviews sources, the webviews app, the
agent-pane bundle or docs, and no Swift test reads those files, the router
selects no Mac tier. ci-web checks the sources and the bundle's freshness, the
bundle is a .copy resource, and gh-merge-green already passes skipped checks.
A dev-build PR keeps its scheme compile.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(cmux-next): CI-only changes skip the Mac tiers; pinned inputs keep theirs

A workflow, CI script, router or gh-merge-green change needs no Mac tier, but
scripts/ci/xcode-pins.txt (a *.txt) and plans/cmux-next/*.md (docs by name)
feed Mac tiers and must keep them, which the web fast tier's early return missed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(cmux-next): a routing replay fails on any unexplained tier change

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* ci(cmux-next): CI-only changes skip the Mac tiers; a routing replay guards the router

Workflows, scripts/ci, the router, gh-merge-green and their tests route to no
Mac tier, alone or with web files. A file a Mac tier reads keeps its tier
whatever its name (the Xcode pins, the cmux-tui Rust action, daemon and tree
inputs, generated-file inputs, files a Swift test reads), which also closes the
web fast tier's gap where scripts/ci/xcode-pins.txt and plans/cmux-next/*.md
matched the docs patterns. When the router changes, the checks job replays the
last 30 merged PRs through the base router and the new one and fails on any
unexplained tier change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants