Repository navigation
fix: let the composer attachment row follow the macOS scrollers - #18296
Conversation
The attachment row hid its scroller with scrollbar-width: none, which check-scrollbars.sh rejects (SCROLLBARS-FOLLOW-MACOS) and which turned the Scrollbars follow macOS check red on feat-cmux-next. With the default overlay scrollers the row looks the same at rest; a scroller shows only while it scrolls, or always when the user chose "Always". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Unclear: CI failed on
Not re-run automatically: Written by |
build-agent-pane-web.sh concatenates composerAttachments.css into the committed index.html verbatim, so the bundle drops the same line and build-agent-pane-web.sh --check stays current. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Coordinator merge: removes the two scrollbar-width: none lines that broke check-scrollbars (SCROLLBARS-FOLLOW-MACOS) on feat-cmux-next since dd97e43, which cancels the hourly Release compile and blocks nightly-next. The red web/react-apps-check is a base React Compiler report in other acpmux files, unrelated to this two-line CSS deletion. |
GalleryNo state changed Diff page and renders (the run's |
…ting replay guards the router (#18310) * test(cmux-next): a web nit routes to no Mac tier A one-line CSS change and its regenerated agent-pane bundle (#18296) ran the Release compile, the Debug scheme compile and swift test on minis. ci-web already checks the sources and proves the committed bundle matches them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * ci(cmux-next): web nits take the fast tier and skip every Mac job When a pull request changes only webviews sources, the webviews app, the agent-pane bundle or docs, and no Swift test reads those files, the router selects no Mac tier. ci-web checks the sources and the bundle's freshness, the bundle is a .copy resource, and gh-merge-green already passes skipped checks. A dev-build PR keeps its scheme compile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(cmux-next): CI-only changes skip the Mac tiers; pinned inputs keep theirs A workflow, CI script, router or gh-merge-green change needs no Mac tier, but scripts/ci/xcode-pins.txt (a *.txt) and plans/cmux-next/*.md (docs by name) feed Mac tiers and must keep them, which the web fast tier's early return missed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(cmux-next): a routing replay fails on any unexplained tier change Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * ci(cmux-next): CI-only changes skip the Mac tiers; a routing replay guards the router Workflows, scripts/ci, the router, gh-merge-green and their tests route to no Mac tier, alone or with web files. A file a Mac tier reads keeps its tier whatever its name (the Xcode pins, the cmux-tui Rust action, daemon and tree inputs, generated-file inputs, files a Swift test reads), which also closes the web fast tier's gap where scripts/ci/xcode-pins.txt and plans/cmux-next/*.md matched the docs patterns. When the router changes, the checks job replays the last 30 merged PRs through the base router and the new one and fails on any unexplained tier change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Summary
The composer's attachment row (
composerAttachments.css) hid its scroller withscrollbar-width: none.check-scrollbars.shrejects that (SCROLLBARS-FOLLOW-MACOS), so "Scrollbars follow macOS" in the cmux-next checks job is red on every PR based onfeat-cmux-next.This drops the rule. The row keeps
overflow-x: auto, so with the default overlay scrollers it looks the same at rest. A scroller appears only while the row scrolls, or always when the user picked "Always" in System Settings, which is what the spec asks for.Verification
bash scripts/cmux-next/check-scrollbars.sh .printscomposerAttachments.css:23: scrollbar-width makes a custom scrollbarand exits 1.check-scrollbars: okand exits 0.CmuxNextAgentPane/Resources/agent-pane/index.html) inlines this CSS verbatim, so it drops the same line;build-agent-pane-web.sh --checkwas red on 30e4a79 ("index.html is stale") and is checked again on 67951bb.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Removes the hidden scrollbar on the composer attachment row so the
Scrollbars follow macOScheck passes. With default overlay scrollers the row looks the same at rest; a scroller appears only while scrolling, or always when the user chose "Always" in System Settings. The compiled agent-pane bundle drops the same line so the build check stays current.Written for commit 67951bb. Summary will update on new commits.
Note
Low Risk
CSS-only tweak to attachment-row scrollbar visibility with no auth, data, or API impact.
Overview
Removes
scrollbar-width: nonefrom the composer attachment row styles so horizontal scrolling follows macOS overlay scrollbar behavior instead of hiding the scroller.The change is applied in
composerAttachments.cssand the mirrored styles in the macOS agent-pane bundle.overflow-x: autois unchanged, so the row should look the same at rest with default overlay scrollbars; a scroller shows while scrolling or when the user has “Always” scrollbars in System Settings. This aligns the UI withcheck-scrollbars.sh(SCROLLBARS-FOLLOW-MACOS) so the cmux-next scrollbars check can pass.Reviewed by Cursor Bugbot for commit 67951bb. Bugbot is set up for automated code reviews on this repo. Configure here.