Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #9264

Merged
merged 6 commits into from
Aug 9, 2024
Merged

Version Packages #9264

merged 6 commits into from
Aug 9, 2024

Conversation

dcousens
Copy link
Member

@dcousens dcousens commented Aug 6, 2024

The following packages have been updated

@keystone-6/[email protected]
@keystone-6/[email protected]

New Features

Bug Fixes

💙 Acknowledgements

Lastly, thanks to @dcousens (#9264,#9264,#9264,#9269,#9263,#9258,#9249,#9247,#9232,#9219,#9218,#9213,#9144), @direisc (#9170), @gautamsi (#9231,#9179), @ggpwnkthx (#9130), @iamandrewluca (#9102,#9125), @kennedybaird (#9272,#9252), @renovate (#9221,#9242,#9222,#9223,#9215,#9211,#9206,#9207,#9205,#9157,#9197,#9196,#9193,#9194,#9187,#9188,#9185,#9184,#9175,#9168,#9167,#9163,#9159,#9161,#9160,#9162,#9158,#9151,#9150,#9148,#9145,#9143,#9140,#9137,#9135,#9134,#9133), @simonswiss (#9267,#9251,#9257,#9255,#9202,#9228,#9227,#9220,#9198) for changes not shown above, but none-the-less appreciated.

👀 Review

See 2024-04-30...2024-08-09 to compare with our previous release.

This comment was marked as resolved.

@kennedybaird
Copy link
Contributor

kennedybaird commented Aug 9, 2024

@dcousens - before you merge this

The explicit @prisma/client and prisma deps in each example makes it so that codesandbox doesn't work if there are minor changes to the generator with patches on prisma versions.

We don't need explicit deps because they come with keystone.

However, with doing that, we likely also need to delete then gitignore the schemas - this way they're always up to date on the machine that runs the command, and relative to the prisma version from keystone - and update the start commands to not use postinstall.

@dcousens
Copy link
Member Author

dcousens commented Aug 9, 2024

@kennedybaird I think you refer to the changes from #9269, maybe we fix that in a different pull request?

I have rebased this pull request to show the actual diff

@dcousens
Copy link
Member Author

dcousens commented Aug 9, 2024

@gautamsi sorry for the delays on this 💙

@dcousens dcousens merged commit 5e22d81 into main Aug 9, 2024
42 of 43 checks passed
@dcousens dcousens deleted the version-packages branch August 9, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants