Fix Astro and Remix examples not building #9247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcousens
commented
Aug 1, 2024
|
|
||
| // https://astro.build/config | ||
| export default defineConfig({ | ||
| output: 'server', | ||
| adapter: node({ | ||
| mode: 'standalone', | ||
| }), |
There was a problem hiding this comment.
An adapter is required for output: 'server', I suspect this was missing initially when added in #8471, or maybe the defaults changed?
dcousens
commented
Aug 1, 2024
| @@ -18,7 +19,7 @@ export default config({ | |||
|
|
|||
| // WARNING: this is only needed for our monorepo examples, dont do this | |||
| // we use using myprisma, not .myprisma, because vite | |||
| prismaClientPath: 'node_modules/myprisma/client', | |||
There was a problem hiding this comment.
It appears that the nested nature of /client is not compatible modern node module resolution, we should probably apply this change to our fixPrismaPath utility
dcousens
commented
Aug 1, 2024
| @@ -9,7 +9,7 @@ datasource sqlite { | |||
|
|
|||
| generator client { | |||
| provider = "prisma-client-js" | |||
| output = "node_modules/.myprisma/client" | |||
| output = "node_modules/myprisma" | |||
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ac3c48d:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the
examples/framework-astroandexamples/framework-remixexamples which both had been suffering fromvitebuild issues outside of our normalkeystone postinstallchecks.