Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hooks documentation to prefer new syntax #9231

Merged
merged 5 commits into from
Jul 25, 2024

Conversation

gautamsi
Copy link
Member

@gautamsi gautamsi commented Jul 25, 2024

for #9204

@dcousens I am not very good at writing documentation, perhaps you can improve this if needed.

@gautamsi gautamsi mentioned this pull request Jul 25, 2024
5 tasks
Copy link

codesandbox-ci bot commented Jul 25, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c174d1f:

Sandbox Source
@keystone-6/sandbox Configuration

@dcousens dcousens changed the title Update hooks documentation for #9204 Update hooks documentation to prefer new syntax Jul 25, 2024
@dcousens dcousens self-assigned this Jul 25, 2024
Copy link
Member

@dcousens dcousens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gautamsi, kick-starting these initiatives is really helpful and appreciated. 💚
I updated some of the copy for my own preference, and added a small fix ca289be.

Looks good to me!

@dcousens dcousens merged commit 46d584a into keystonejs:main Jul 25, 2024
1 check passed
@gautamsi gautamsi deleted the updated-hooks-documenation branch July 25, 2024 05:04
@gautamsi gautamsi restored the updated-hooks-documenation branch July 25, 2024 05:06
gautamsi added a commit to gautamsi/keystone that referenced this pull request Jul 25, 2024
@gautamsi gautamsi deleted the updated-hooks-documenation branch July 25, 2024 13:37
@dcousens dcousens mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants