Remove io-ts, use zod #9263
Merged
Remove io-ts, use zod #9263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kennedybaird thanks for your initiative on #9261, I will add you as credit for this pull request 💛 |
This comment was marked as resolved.
This comment was marked as resolved.
|
Great work, I was going to suggest moving to zod! |
dcousens
commented
Aug 6, 2024
| label: string | undefined | ||
| data: Record<string, any> | undefined | ||
| label?: string | ||
| data?: Record<string, any> |
There was a problem hiding this comment.
This is required as a result of zod assuming that | undefined is equivalent to ?:, which it isn't.
Reference colinhacks/zod#2464 and colinhacks/zod#2598
dcousens
added a commit
that referenced
this pull request
Aug 6, 2024
dcousens
added a commit
that referenced
this pull request
Aug 6, 2024
dcousens
added a commit
that referenced
this pull request
Aug 7, 2024
dcousens
added a commit
that referenced
this pull request
Aug 9, 2024
dcousens
added a commit
that referenced
this pull request
Aug 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #9261
This pull request replaces the use of
io-tswithzod, something I am planning to use internally elsewhere in the project.