Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert packages to use nominal package versions #9269

Merged
merged 7 commits into from
Aug 7, 2024
Merged

Revert packages to use nominal package versions #9269

merged 7 commits into from
Aug 7, 2024

Conversation

dcousens
Copy link
Member

@dcousens dcousens commented Aug 7, 2024

Alternative to #9266
Reverting #9112 and other pull requests, and seeking an alternative strategy for working with workspace package versioning.

@@ -5,6 +5,9 @@
"baseBranch": "main",
"linked": [],
"access": "public",
"privatePackages": {
"version": false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stops examples/ from generating CHANGELOG.md and version bumps

"private": true,
"author": "Dinesh Pandiyan <[email protected]>",
Copy link
Member Author

@dcousens dcousens Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flexdinesh 💛 but we don't add this field for any of the other examples, that is what git is for

@dcousens
Copy link
Member Author

dcousens commented Aug 7, 2024

@kennedybaird if you can follow up this work with a pull request that resolves the fixPrismaPath and bump the CodeSandbox configurations to use Node 20, that would be really appreciated.

I think this configuration works well with pnpm changeset version, which is what we are using for release; and keeps the maintenance about the same.

Copy link

codesandbox-ci bot commented Aug 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a082e0a:

Sandbox Source
@keystone-6/sandbox Configuration

@dcousens dcousens merged commit 27845c8 into main Aug 7, 2024
41 of 43 checks passed
@dcousens dcousens deleted the no-catalog branch August 7, 2024 10:19
@dcousens dcousens mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant