-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: example links fixing + table of contents fixes #9272
Conversation
@simonswiss - you may want to have a quick review as 1cbe903 touched on your recent work |
@kennedybaird @simonswiss for examples, maybe there is an opportunity to have the README in each folder feed into Keystatic? |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1cbe903:
|
@dcousens - can you clarify why? So that each example readme can be viewed without leaving docs? It seems like an unnecessary double up. Or are you wanting some automated mirroring of the examples folder, so that we're not maintaining the docs side as well? With prefixes in the folder names, and |
@kennedybaird the latter, I'm hoping we can effectively move the guides into markdown, into each The matter of maintaining |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Thanks for this work, @kennedybaird 🙏 Agreed that manually playing "catch up / keep up" for the Keystatic examples list is not ideal. As a first step I tried to re-create the existing setup (which was hardcoding the examples links in the template), but this is indeed probably not the final solution. Probably outside the scope of this PR though — and I'll approve that as this fixes a whole lot of broken links. |
Do you want me to have a look at a keystatic approach @simonswiss? |
removed loose
"
on deployment example linksfixed the github example links
removed some invalid examples / duplicates
moved
extractHeadings
to a newheadings.ts
utils file to fix the table of contents for blog and docsAfter looking through all the examples - there are a lot more than are documented. I didn't want to go through adding more and having the examples page get a lot more ungainly, but I did wonder about creating more sections?
Currently we have 3:
I think either having sub-sections in standalone, or just adding new sections could be beneficial:
I do at least like the idea of adding a
fields-
prefix to all the field examples, so viewing the examples dir is easier.Happy to copy the above to a discussion and suggest some prefixes or organisation as well