Updates for GraphQL schema ordering and TypeScript type generation #9258
Conversation
dcousens
changed the title
dcousens
changed the title
| user(where: UserWhereUniqueInput!): User | ||
| users(where: UserWhereInput! = {}, orderBy: [UserOrderByInput!]! = [], take: Int, skip: Int! = 0, cursor: UserWhereUniqueInput): [User!] |
There was a problem hiding this comment.
This will be a noisy update for developers, but, this has been an inconsistency in our code for many moons, and is annoying to uphold.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9594b52:
|
|
|
||
| const name = type.name | ||
| if (type instanceof GraphQLScalarType) { | ||
| if (scalars[name] === undefined) return 'any' | ||
| return `Scalars['${stringify(name)}']` // TODO: inline? |
There was a problem hiding this comment.
I don't see why we needed to refer to this Scalars object continually for our resolved types; this isn't helpful to developers.
| @@ -84,7 +74,7 @@ export type TodoUpdateArgs = { | |||
| } | |||
|
|
|||
| export type TodoCreateInput = { | |||
| readonly title?: Scalars['String'] | null | |||
| readonly title?: string | null | |||
There was a problem hiding this comment.
This is easier on the eyes from a developer documentation point of view
There was a problem hiding this comment.
I have been annoyed by this scalar in generating types to be used with separate frontend app.
dcousens
force-pushed
the
diff-graphql-prisma-types
branch
2 times, most recently
from
6c65ac8
to
097c846
Compare
dcousens
force-pushed
the
diff-graphql-prisma-types
branch
from
097c846
to
9594b52
Compare
This pull request changes some of the ordering in our GraphQL types, and begins to introduces a differentiation between GraphQL types and resolved (or Prisma) types in our generated Typescript types.
This change is important as it begins to address a state where these types do not always match. The reason for that will be evident in #2480, but additionally, it refactors the Typescript type generation to start accounting for separate Typescript types for a
sudo()context.Primarily for now though, this pull request inlines parts of the
printGeneratedTypesand orders the outputs more consistently.