Skip to content

FIX calendar picker if weeknumbers hidden and time format 24h#42184

Closed
cyrez wants to merge 690 commits intojoomla:4.4-devfrom
cyrez:patch-55
Closed

FIX calendar picker if weeknumbers hidden and time format 24h#42184
cyrez wants to merge 690 commits intojoomla:4.4-devfrom
cyrez:patch-55

Conversation

@cyrez
Copy link
Contributor

@cyrez cyrez commented Oct 20, 2023

Pull Request for Issue introduced (by me 🥇 ) in PR #40761.

Affected Joomla versions: 4.4.0 and 5.0.0

Summary of Changes

Quick FIX
Check if weeknumbers is true or false to listen to correct number of childNodes.
Calendar form field with 12h (AM/PM) time format is not affected by the issue, as well as calendar picker with week numbers (so Joomla core not affected).

Testing Instructions

Set 2 form fields of type calendar like this (with and without week numbers):

Note: default timeformat is 24 and dedault weeknumbers is true.

<field
	name="no_week_numbers"
	type="calendar"
	label="Test"
	description="Test without weeknumbers and time 24h"
	showtime="true"
	weeknumbers="false"
/>

<field
	name="week_numbers"
	type="calendar"
	label="Test"
	description="Test with weeknumbers and time 24h"
	showtime="true"
/>

Actual result BEFORE applying this Pull Request

You can't change Time (hour and/or minutes) with the no_week_numbers calendar picker.
It's working with the other form field.

Expected result AFTER applying this Pull Request

It's working in both cases.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Fedik and others added 30 commits September 12, 2023 10:13
* task param removal

* param removal

* task param removal

* task param removal

* remove task param

* remove task param
* [5.0] TinyMCE plugins

* Update build/media_source/plg_editors_tinymce/js/plugins/dragdrop/plugin.es6.js

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

---------

Co-authored-by: George Wilson <georgejameswilson@googlemail.com>
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
* [5.0Beta1] Task titles

Simple PR to change the title of the three newly created tasks to real words (if possible).

As these are not translated strings it makes it easier for machine translators when real words are used

* thanks Richard

* updates from beta1

---------

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
…1443)

* Use own icon for dashboard due to fontawesome changes

* Remove extra lines

* Update administrator/modules/mod_menu/tmpl/default_submenu.php

Co-authored-by: Quy <quy@nomonkeybiz.com>

* Update administrator/modules/mod_menu/tmpl/default_submenu.php

Co-authored-by: Quy <quy@nomonkeybiz.com>

* Update administrator/modules/mod_submenu/tmpl/default.php

Co-authored-by: jsanders <j53.sanders@gmail.com>

* Update administrator/modules/mod_menu/tmpl/default_submenu.php

Co-authored-by: jsanders <j53.sanders@gmail.com>

* Update administrator/modules/mod_menu/tmpl/default_submenu.php

Co-authored-by: jsanders <j53.sanders@gmail.com>

* unitless height

* Update administrator/modules/mod_menu/tmpl/default_submenu.php

Co-authored-by: Quy <quy@nomonkeybiz.com>

* Update administrator/modules/mod_menu/tmpl/default_submenu.php

Co-authored-by: Quy <quy@nomonkeybiz.com>

* Update administrator/modules/mod_submenu/tmpl/default.php

Co-authored-by: Quy <quy@nomonkeybiz.com>

---------

Co-authored-by: George Wilson <georgejameswilson@googlemail.com>
Co-authored-by: Quy <quy@nomonkeybiz.com>
Co-authored-by: jsanders <j53.sanders@gmail.com>
Co-authored-by: Harald Leithner <leithner@itronic.at>
Co-authored-by: Denitz <pandenitz@mail.ru>
* New Dialog modal for User field

* New Dialog modal for User field
* Enable the system plugin on upgrade

* more strict
Co-authored-by: Denitz <pandenitz@mail.ru>
Co-authored-by: Denitz <pandenitz@mail.ru>
Co-authored-by: Denitz <pandenitz@mail.ru>
* [5.0] CLI install fix public folder language string

help command

* refactor label to desc
Co-authored-by: Denitz <pandenitz@mail.ru>
Co-authored-by: Harald Leithner <leithner@itronic.at>
Co-authored-by: Denitz <pandenitz@mail.ru>
Co-authored-by: Denitz <pandenitz@mail.ru>
Co-authored-by: Denitz <pandenitz@mail.ru>
Co-authored-by: Denitz <pandenitz@mail.ru>
Co-authored-by: Denitz <pandenitz@mail.ru>
Co-authored-by: Denitz <pandenitz@mail.ru>
Co-authored-by: Denitz <pandenitz@mail.ru>
bembelimen and others added 19 commits October 9, 2023 20:28
Signed-off-by: Harald Leithner <leithner@itronic.at>
* Add zstandard and github layout

Make zstandard a default compression method and demote bzip2
Also make github layout more user friendly

* cs
Simple pr to update the file referenced in a todo

codereview
Signed-off-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
* MailTemplate: Prevent notice in replaceTags

* Update libraries/src/Mail/MailTemplate.php

Co-authored-by: Quy <quy@nomonkeybiz.com>

* Update MailTemplate.php

---------

Co-authored-by: Quy <quy@nomonkeybiz.com>
Co-authored-by: Quy <quy@nomonkeybiz.com>
---------

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Co-authored-by: Harald Leithner <leithner@itronic.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comments