FIX calendar picker if weeknumbers hidden and time format 24h#42184
Closed
cyrez wants to merge 690 commits intojoomla:4.4-devfrom
Closed
FIX calendar picker if weeknumbers hidden and time format 24h#42184cyrez wants to merge 690 commits intojoomla:4.4-devfrom
cyrez wants to merge 690 commits intojoomla:4.4-devfrom
Conversation
[5.0] Upmerge
[5.0] Fix TinyMCE builder field
* task param removal * param removal * task param removal * task param removal * remove task param * remove task param
* [5.0] TinyMCE plugins * Update build/media_source/plg_editors_tinymce/js/plugins/dragdrop/plugin.es6.js Co-authored-by: Richard Fath <richard67@users.noreply.github.com> --------- Co-authored-by: George Wilson <georgejameswilson@googlemail.com> Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
* [5.0Beta1] Task titles Simple PR to change the title of the three newly created tasks to real words (if possible). As these are not translated strings it makes it easier for machine translators when real words are used * thanks Richard * updates from beta1 --------- Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
…1443) * Use own icon for dashboard due to fontawesome changes * Remove extra lines * Update administrator/modules/mod_menu/tmpl/default_submenu.php Co-authored-by: Quy <quy@nomonkeybiz.com> * Update administrator/modules/mod_menu/tmpl/default_submenu.php Co-authored-by: Quy <quy@nomonkeybiz.com> * Update administrator/modules/mod_submenu/tmpl/default.php Co-authored-by: jsanders <j53.sanders@gmail.com> * Update administrator/modules/mod_menu/tmpl/default_submenu.php Co-authored-by: jsanders <j53.sanders@gmail.com> * Update administrator/modules/mod_menu/tmpl/default_submenu.php Co-authored-by: jsanders <j53.sanders@gmail.com> * unitless height * Update administrator/modules/mod_menu/tmpl/default_submenu.php Co-authored-by: Quy <quy@nomonkeybiz.com> * Update administrator/modules/mod_menu/tmpl/default_submenu.php Co-authored-by: Quy <quy@nomonkeybiz.com> * Update administrator/modules/mod_submenu/tmpl/default.php Co-authored-by: Quy <quy@nomonkeybiz.com> --------- Co-authored-by: George Wilson <georgejameswilson@googlemail.com> Co-authored-by: Quy <quy@nomonkeybiz.com> Co-authored-by: jsanders <j53.sanders@gmail.com> Co-authored-by: Harald Leithner <leithner@itronic.at>
Co-authored-by: Denitz <pandenitz@mail.ru>
* New Dialog modal for User field * New Dialog modal for User field
* Enable the system plugin on upgrade * more strict
Co-authored-by: Denitz <pandenitz@mail.ru>
Co-authored-by: Denitz <pandenitz@mail.ru>
Co-authored-by: Denitz <pandenitz@mail.ru>
…la#41665) Co-authored-by: Denitz <pandenitz@mail.ru>
* [5.0] CLI install fix public folder language string help command * refactor label to desc
Co-authored-by: Denitz <pandenitz@mail.ru>
Co-authored-by: Harald Leithner <leithner@itronic.at>
Co-authored-by: Denitz <pandenitz@mail.ru>
Co-authored-by: Denitz <pandenitz@mail.ru>
Co-authored-by: Denitz <pandenitz@mail.ru>
Co-authored-by: Denitz <pandenitz@mail.ru>
Co-authored-by: Denitz <pandenitz@mail.ru>
Co-authored-by: Denitz <pandenitz@mail.ru>
Co-authored-by: Denitz <pandenitz@mail.ru>
Co-authored-by: Denitz <pandenitz@mail.ru>
[5.0] Upmerge 4.4
Signed-off-by: Harald Leithner <leithner@itronic.at>
* Add zstandard and github layout Make zstandard a default compression method and demote bzip2 Also make github layout more user friendly * cs
Simple pr to update the file referenced in a todo codereview
Signed-off-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
* MailTemplate: Prevent notice in replaceTags * Update libraries/src/Mail/MailTemplate.php Co-authored-by: Quy <quy@nomonkeybiz.com> * Update MailTemplate.php --------- Co-authored-by: Quy <quy@nomonkeybiz.com>
Co-authored-by: Quy <quy@nomonkeybiz.com>
--------- Co-authored-by: Richard Fath <richard67@users.noreply.github.com> Co-authored-by: Harald Leithner <leithner@itronic.at>
…42168) Co-authored-by: Quy <quy@nomonkeybiz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue introduced (by me 🥇 ) in PR #40761.
Affected Joomla versions: 4.4.0 and 5.0.0
Summary of Changes
Quick FIX
Check if weeknumbers is true or false to listen to correct number of childNodes.
Calendar form field with 12h (AM/PM) time format is not affected by the issue, as well as calendar picker with week numbers (so Joomla core not affected).
Testing Instructions
Set 2 form fields of type calendar like this (with and without week numbers):
Note: default timeformat is 24 and dedault weeknumbers is true.
Actual result BEFORE applying this Pull Request
You can't change Time (hour and/or minutes) with the
no_week_numberscalendar picker.It's working with the other form field.
Expected result AFTER applying this Pull Request
It's working in both cases.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed