Skip to content

Comments

[5.0] CLI install fix public folder language string#41623

Merged
HLeithner merged 3 commits intojoomla:5.0-devfrom
heelc29:5.0/cli-install/public-folder-lang
Sep 12, 2023
Merged

[5.0] CLI install fix public folder language string#41623
HLeithner merged 3 commits intojoomla:5.0-devfrom
heelc29:5.0/cli-install/public-folder-lang

Conversation

@heelc29
Copy link
Contributor

@heelc29 heelc29 commented Sep 6, 2023

Summary of Changes

  • remove description form public_folder; language string not defined
  • fix language string for public_folder in help command

Testing Instructions

execute php installation/joomla.php install -h

Actual result BEFORE applying this Pull Request

untranslated string
image

Expected result AFTER applying this Pull Request

translated
image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@HLeithner
Copy link
Member

I think all of them should be DESC to be consistent with the other language strings in this file

@tecpromotion
Copy link
Contributor

I have tested this item ✅ successfully on 28bc032


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41623.

@tecpromotion
Copy link
Contributor

I think all of them should be DESC to be consistent with the other language strings in this file

You mean

INSTL_DATABASE_ENCRYPTION_CA_LABEL_SHORT
INSTL_DATABASE_ENCRYPTION_CERT_LABEL_SHORT
INSTL_DATABASE_ENCRYPTION_CIPHER_LABEL_SHORT
INSTL_DATABASE_ENCRYPTION_KEY_LABEL_SHORT
INSTL_DATABASE_ENCRYPTION_MODE_LABEL_SHORT
INSTL_DATABASE_ENCRYPTION_VERIFY_SERVER_CERT_LABEL_SHORT

@HLeithner
Copy link
Member

yeah ok then I only saw them where I added the new strings and was already confused whats a DESC and a DESC_SHORT is but no LABEL exists...

so happy with anything we have

@tecpromotion
Copy link
Contributor

Uniform processing of the strings makes the most sense from a translation point of view, of course.

@tecpromotion
Copy link
Contributor

I have tested this item ✅ successfully on bdf2201

thanks @heelc29


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41623.

@ceford
Copy link
Contributor

ceford commented Sep 8, 2023

I have tested this item ✅ successfully on bdf2201


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41623.

@alikon
Copy link
Contributor

alikon commented Sep 8, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41623.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 8, 2023
@HLeithner HLeithner merged commit 400d4c1 into joomla:5.0-dev Sep 12, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 12, 2023
@heelc29 heelc29 deleted the 5.0/cli-install/public-folder-lang branch September 12, 2023 16:12
@tecpromotion
Copy link
Contributor

Thanks @heelc29 and @HLeithner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants