You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi Fedik,
IMO J5 either uses BS modals or it uses dialogs, having a mix makes things more complex. I have seen this with name spacing and service providers which where introduced in 4.0 but needed up until 4.3 to be completed (and not sure if it is already complete?)
And I probably missed it, but what is the reason for switching from BS Modals to JS Dialogs? Is there any discussion on this that I (we as developers) can read up on?
It is not possible to change all at once, physically.
but what is the reason for switching from BS Modals to JS Dialogs
With BS you always should have pre-rendered HTML on the page.
With Dialog you can construct it on the way, load content with AJAX, much more flexible.
Something like it was in J 1.5-2.5 with SqueezeBox.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Use Joomla dialog and
postMessagefor user field, instead of BS modal.It may not hit 5.0, but in future will need to update anyway.
Testing Instructions
Apply patch, run
npm installCreate User field, or use existing. try select the field value.
Actual result BEFORE applying this Pull Request
Works with BS modal
Expected result AFTER applying this Pull Request
Works with joomla dialog
Link to documentations
Please select:
References: