Skip to content

Comments

[5.0] Modal Dialog for User field#41680

Merged
HLeithner merged 2 commits intojoomla:5.0-devfrom
Fedik:popup-user
Sep 12, 2023
Merged

[5.0] Modal Dialog for User field#41680
HLeithner merged 2 commits intojoomla:5.0-devfrom
Fedik:popup-user

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Sep 8, 2023

Summary of Changes

Use Joomla dialog and postMessage for user field, instead of BS modal.

It may not hit 5.0, but in future will need to update anyway.

Testing Instructions

Apply patch, run npm install
Create User field, or use existing. try select the field value.

<field type="user" name="user_test" label="User"/>

Actual result BEFORE applying this Pull Request

Works with BS modal

Expected result AFTER applying this Pull Request

Works with joomla dialog

Link to documentations

Please select:

References:

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev labels Sep 8, 2023
@Fedik Fedik added the Feature label Sep 8, 2023
@Fedik Fedik changed the title [5.0] New Dialog modal for User field [5.0] Modal Dialog for User field Sep 9, 2023
@Ruud68
Copy link
Contributor

Ruud68 commented Sep 11, 2023

Hi Fedik,
IMO J5 either uses BS modals or it uses dialogs, having a mix makes things more complex. I have seen this with name spacing and service providers which where introduced in 4.0 but needed up until 4.3 to be completed (and not sure if it is already complete?)

And I probably missed it, but what is the reason for switching from BS Modals to JS Dialogs? Is there any discussion on this that I (we as developers) can read up on?

Thanks,
Regards, Ruud


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41680.

@Fedik
Copy link
Member Author

Fedik commented Sep 11, 2023

IMO J5 either uses BS modals or it uses dialogs,

It is not possible to change all at once, physically.

but what is the reason for switching from BS Modals to JS Dialogs

With BS you always should have pre-rendered HTML on the page.
With Dialog you can construct it on the way, load content with AJAX, much more flexible.
Something like it was in J 1.5-2.5 with SqueezeBox.

Is there any discussion on this

You can look linked issues in description of:

Also discussion:

@HLeithner HLeithner merged commit f7a515b into joomla:5.0-dev Sep 12, 2023
@HLeithner
Copy link
Member

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants