Skip to content

Comments

[5.0] Use own icon for dashboard due to fontawesome changes#41443

Merged
HLeithner merged 11 commits intojoomla:5.0-devfrom
chmst:atum-icon-dashboard
Sep 12, 2023
Merged

[5.0] Use own icon for dashboard due to fontawesome changes#41443
HLeithner merged 11 commits intojoomla:5.0-devfrom
chmst:atum-icon-dashboard

Conversation

@chmst
Copy link
Contributor

@chmst chmst commented Aug 25, 2023

Pull Request for Issue #40748 .

Summary of Changes

An own dashboard icon was made by @angieradtke. Thank you!
I added a new folder into the atum image folder and changed the rendering for the atum submenu

Testing Instructions

Attention: needs npm or the package for test.

Actual result BEFORE applying this Pull Request

see #40748

Expected result AFTER applying this Pull Request

The dashboard looks as before in J4.x
grafik

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev labels Aug 25, 2023
@chmst chmst changed the title [5.0] Use own icon for dashboard due to fontaesome changes [5.0] Use own icon for dashboard due to fontawesome changes Aug 25, 2023
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on a56ad7c

does what it says - no idea if this is the best way


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41443.

chmst and others added 4 commits August 25, 2023 15:57
Co-authored-by: jsanders <j53.sanders@gmail.com>
Co-authored-by: jsanders <j53.sanders@gmail.com>
Co-authored-by: jsanders <j53.sanders@gmail.com>
@ChristineWk
Copy link

I have tested this item ✅ successfully on 3f7276a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41443.

@ChristineWk
Copy link

pr-41443

pr-41443-2

@Quy
Copy link
Contributor

Quy commented Aug 30, 2023

This feels not right to do it for just one icon. I understand it affects documentation, however, I am ok with the new icon as it is not completely different from the old one.

@chmst
Copy link
Contributor Author

chmst commented Aug 31, 2023

Agree @Quy. I made an extra folder in images, so we can expand. Especially as the new fontawesome icons look worse than before. And would be happy to do that for all atum icons if a desinger helps with svg.

@HLeithner
Copy link
Member

@angieradtke is the icon created by you? it looks extremely similar to the fontawesome 5 icon which could lead us into copyright troubles but I'm not lawyer so I have to ask...

@angieradtke
Copy link
Contributor

@HLeithner I painted this icon with illustrator and then edited the source code in php storm. This is an icon with 4 squares that have a border radius. I can't judge how big the intellectual property of these four squares is, especially since font-awesome has modified this icon and uses the customized icon to display a grid. As far as I know font awesome is Open Font under SIL

@HLeithner
Copy link
Member

@HLeithner I painted this icon with illustrator and then edited the source code in php storm. This is an icon with 4 squares that have a border radius. I can't judge how big the intellectual property of these four squares is, especially since font-awesome has modified this icon and uses the customized icon to display a grid. As far as I know font awesome is Open Font under SIL

perfect thanks then I can merge this.

Co-authored-by: Quy <quy@nomonkeybiz.com>
@ceford
Copy link
Contributor

ceford commented Sep 12, 2023

I have tested this item ✅ successfully on f271ec1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41443.

@HLeithner HLeithner merged commit 4298f9f into joomla:5.0-dev Sep 12, 2023
@chmst chmst deleted the atum-icon-dashboard branch September 9, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backend Template NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.