[5.0] Use own icon for dashboard due to fontawesome changes#41443
[5.0] Use own icon for dashboard due to fontawesome changes#41443HLeithner merged 11 commits intojoomla:5.0-devfrom
Conversation
|
I have tested this item ✅ successfully on a56ad7c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41443. |
Co-authored-by: Quy <quy@nomonkeybiz.com>
Co-authored-by: Quy <quy@nomonkeybiz.com>
Co-authored-by: jsanders <j53.sanders@gmail.com>
Co-authored-by: jsanders <j53.sanders@gmail.com>
Co-authored-by: jsanders <j53.sanders@gmail.com>
|
I have tested this item ✅ successfully on 3f7276a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41443. |
|
This feels not right to do it for just one icon. I understand it affects documentation, however, I am ok with the new icon as it is not completely different from the old one. |
Co-authored-by: Quy <quy@nomonkeybiz.com>
|
Agree @Quy. I made an extra folder in images, so we can expand. Especially as the new fontawesome icons look worse than before. And would be happy to do that for all atum icons if a desinger helps with svg. |
|
@angieradtke is the icon created by you? it looks extremely similar to the fontawesome 5 icon which could lead us into copyright troubles but I'm not lawyer so I have to ask... |
Co-authored-by: Quy <quy@nomonkeybiz.com>
|
@HLeithner I painted this icon with illustrator and then edited the source code in php storm. This is an icon with 4 squares that have a border radius. I can't judge how big the intellectual property of these four squares is, especially since font-awesome has modified this icon and uses the customized icon to display a grid. As far as I know font awesome is Open Font under SIL |
perfect thanks then I can merge this. |
Co-authored-by: Quy <quy@nomonkeybiz.com>
|
I have tested this item ✅ successfully on f271ec1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41443. |


Pull Request for Issue #40748 .
Summary of Changes
An own dashboard icon was made by @angieradtke. Thank you!
I added a new folder into the atum image folder and changed the rendering for the atum submenu
Testing Instructions
Attention: needs npm or the package for test.
Actual result BEFORE applying this Pull Request
see #40748
Expected result AFTER applying this Pull Request
The dashboard looks as before in J4.x

Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed