Skip to content

Conversation

@dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Oct 11, 2023

Pull Request for Issue #42101 .

Problem

  • SVG images inserted using the list view have zero width/height

Summary of Changes

  • The list view doesn't have the same data as the thumbnail view. SVG files need to be rendered to get the naturalHeight/naturalWidth
  • The selected item styling for the List view now applies the background colour to the whole row:
Screenshot 2023-10-11 at 21 59 09

Testing Instructions

  • Try to insert an svg into the intro image FROM THE LIST VIEW
  • Observe that the width and height parts at the end of the URL are not 0

Actual result BEFORE applying this Pull Request

Selecting an SVG image either from Grid view or List view DOESN'T yield the same URL

Expected result AFTER applying this Pull Request

Selecting an SVG image either from Grid view or List view should yield the same URL

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@laoneo

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev labels Oct 11, 2023
@dgrammatiko dgrammatiko force-pushed the 5.0-dev_table_view_parity branch 3 times, most recently from 978f1e7 to 4fcf35b Compare October 11, 2023 18:50
Signed-off-by: Dimitris Grammatikogiannis <[email protected]>
@dgrammatiko dgrammatiko force-pushed the 5.0-dev_table_view_parity branch from 4fcf35b to 8a75743 Compare October 11, 2023 18:59
@dgrammatiko dgrammatiko changed the title [5.0][WIP] Media manager list view parity [5.0] Media manager list view parity Oct 11, 2023
@HLeithner HLeithner added this to the Joomla! 5.0.1 milestone Oct 12, 2023
@ceford
Copy link
Contributor

ceford commented Oct 13, 2023

I have tested this item ✅ successfully on 8a75743


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42119.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 8a75743

👌


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42119.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 5.0.1 milestone Oct 13, 2023
@alikon
Copy link
Contributor

alikon commented Oct 13, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42119.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 13, 2023
@HLeithner HLeithner added this to the Joomla! 5.0.1 milestone Oct 13, 2023
@HLeithner HLeithner merged commit 535f5ca into joomla:5.0-dev Oct 17, 2023
@HLeithner
Copy link
Member

thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 17, 2023
@dgrammatiko dgrammatiko deleted the 5.0-dev_table_view_parity branch November 6, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants