[5.0Beta1] Task titles

[brianteeman]

Simple PR to change the title of the three newly created tasks to real words (if possible).

As these are not translated strings it makes it easier for machine translators when real words are used

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[HLeithner]

That will not migration beta1 installations right?

[richard67]

@brianteeman Shouldn't these be changed, too, if we go that way?

• https://github.com/joomla/joomla-cms/blob/5.0-dev/administrator/components/com_admin/script.php#L2458
• https://github.com/joomla/joomla-cms/blob/5.0-dev/administrator/components/com_admin/script.php#L2527

The 3 tasks which you have found are created with the deletion of the old, obsolete system plugin.

The 2 mentioned by me are created when the old system plugin continues to exist and only some of their parameters are moved to the new task, that's why those 2 are in the postflight.

@HLeithner Should we migrate the Beta 1 task titles with Beta 2? I'm not sure if it's worth the effort, as the titles are used only for title display and nothing else, i.e. not in any code for identifying a task. At least I don't remember having seen anything like that.

On the long run I think task titles should be translatable. No idea why that's not the case.

[alikon]

as long as this don't cost to us any extra effort from moving beta to beta, or whatever
fine for me

[richard67]

I have tested this item ✅ successfully on 9f44be7

I don't think it needs an update SQL script to update the titles from beta 1 to beta 2.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41603.}

[alikon]

I have tested this item ✅ successfully on 9f44be7

cr

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41603.}

[alikon]

rtc

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41603.}

[HLeithner]

yes we should update from beta1 to beta2 the titles.

[richard67]

yes we should update from beta1 to beta2 the titles.

@brianteeman Could you do that with a new update SQL script for each db type? Here my suggestion for MySQL. For PostgreSQL it just needs to change the names quotes.

UPDATE `#__scheduler_tasks` SET `title` = 'Delete Action Logs' WHERE `type` = 'delete.actionlogs' AND `title` = 'DeleteActionLogs';
UPDATE `#__scheduler_tasks` SET `title` = 'Privacy Consent' WHERE `type` = 'privacy.consent' AND `title` = 'PrivacyConsent';
UPDATE `#__scheduler_tasks` SET `title` = 'Rotate Logs' WHERE `type` = 'rotation.logs' AND `title` = 'RotateLogs';
UPDATE `#__scheduler_tasks` SET `title` = 'Session GC' WHERE `type` = 'session.gc' AND `title` = 'SessionGC';
UPDATE `#__scheduler_tasks` SET `title` = 'Update Notification' WHERE `type` = 'update.notification' AND `title` = 'UpdateNotification';

The type should be in the where condition to not accidentally update an unrelated task with that title, and the title is in the where condition in order not to update the title for that type when the user has already changed it to something else.

[brianteeman]

will do that in the morning

[brianteeman]

sql updates added

[richard67]

Back to pending doe to changes (new update SQL).

@alikon Could you test again? Maybe this time also with updating a 5.0-dev to the update package or custom update URL from Drone. I will do that myself too in a minute or two.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41603.}

[richard67]

I have tested this item ✅ successfully on 7ca4991

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41603.}

[HLeithner]

can you please fix the merge conflict then it can be merged.

[richard67]

can you please fix the merge conflict then it can be merged.

@HLeithner @brianteeman I've allowed myself to do that.

[brianteeman]

thanks